Code Monkey home page Code Monkey logo

Comments (3)

kingdido999 avatar kingdido999 commented on June 29, 2024

Well...this is a known issue/limitation of this library mentioned in README as #22. Basically, images will not be visible after zoom-in if its parents have CSS style overflow: hidden. In your case, the element .carousel-inner is causing the issue.

A potential solution is to remove overflow: hidden before opening the image and add it back once closed:

const carouselInner = document.querySelector('.carousel-inner')

new Zooming({
  onBeforeOpen: function () {
    carouselInner.style.overflow = 'visible'
  },
  onClose: function () {
    carouselInner.style.overflow = 'hidden'
  }
});

I haven't tested it though, just something off the top of my head.

from zooming.

daviddewinter avatar daviddewinter commented on June 29, 2024

Thanks for the quick reply! I have done a static override to overflow: visible on the .carousel-inner element, however it doesn't make a difference, I also updated the codepen.

...
<div class="carousel-inner" style="overflow: visible;">
   ...
</div>
...

from zooming.

kingdido999 avatar kingdido999 commented on June 29, 2024

Hey @winterdedavid I don't think I have bandwidth to investigate this further, so I will close this issue now. As I said it might be a limitation of this library. As a side note, it may not be a good UX choice to combine image zooming and carousel together, seems a bit weird to interact in my opinion.

from zooming.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.