Code Monkey home page Code Monkey logo

containerd-nightlies's People

Contributors

akihirosuda avatar aojea avatar bentheelder avatar dims avatar munnerz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

containerd-nightlies's Issues

zuul was removed upstream in main, need to get go version a different way

containerd/containerd#7369

we can use .github/workflows/nightly.yml GO_VERSION: '1.19.1'

(we don't use upstream nightly builds still because they're harder to automatically consume, with paths like https://github.com/containerd/containerd/suites/8409151131/artifacts/371863559 => latest linux amd64 nightly build in a zip, and release builds)

we might be able to switch to upstream for release versions though and lately we're shipping those more often than early tags, however in the past we needed to pick up fixes ASAP so it's probably still worth maintaining here

cc @aojea

parse runc-version, not go.mod (vendor.conf)

if [ -f go.mod ]; then
RUNC_COMMIT=$(grep opencontainers/runc go.mod | awk '{print $2}')
else
# containerd 1.4 and lower use vendor.conf for the modules
RUNC_COMMIT=$(grep opencontainers/runc vendor.conf | awk '{print $2}')
fi
echo "RUNC_COMMIT=${RUNC_COMMIT}" >> $GITHUB_ENV

This version detection logic is not robust.
As the result, https://github.com/kind-ci/containerd-nightlies/releases/tag/containerd-1.5.1 was released with an unexpected version of runc (expected: rc94, actual: rc93).

The right way is to read script/setup/runc-version.

https://github.com/containerd/containerd/blob/v1.4.5/script/setup/runc-version
https://github.com/containerd/containerd/blob/v1.5.1/script/setup/runc-version

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.