kiamev / rimworld-changedresser Goto Github PK

Usually when drafted, a pawn's clothes will disappear immediately, usually leaving them naked. One would assume they would be going into the nearest change dresser, however all the ones located on the map are empty, and I can only assume the clothing items are being deleted.

Hello,

after activating HugsLib, Humanoid Alien Races and Change Dresser - B18, game crashes whenever I click "close" button in mod list.

Here is crash log and if you need any other info, please, ask.

If a pawn has an item that is Forced, and they visit the change dresser to swap gear, the forced items lose their Forced status. Interestingly, those items are NOT replaced that visit, even if a better one exists, but they will be replaced next visit.

Setup: (the item types are arbitrary)

• Have at least two shirts, one of which is significantly better than the other. Put the better one in the dresser and force-equip the crappy shirt.
• Have at least one pair of pants stored in the dresser.

Repro steps:

1. Have the pawn unequip their pants. They will drop the pants then gain the job "Equipping wooden change dresser".
2. When they reach the dresser and put on the stored pants, their crappy shirt will no longer be Forced, but they will still be wearing it.
3. Toggle draft on the colonist. They will switch to the good shirt from storage.

Variants:

• If you toggle draft after setup or after step 1, nothing unexpected happens. The crappy shirt stays Forced and stays equipped.
• If you give the colonist another job after step 2, they will then run over to change again and will also replace their crappy shirt.

I get about a 10s interruption each time JobGiver_OptimizeApparel.TryGiveJob postfix runs for my pawns with Royal Titles. Forcing very specific outfits helped remove the lag some of the time when drafting/undrafting but not all of the time and the hitch still pops up pretty frequently. I've even been strict on not storing gear I won't equip in ChangeDressers, I think I have a normal amount of apparel stored up for a 16 pawn colony.

I've looked quite a bit at the code and understand in general but I'm not 100% on why this is the current approach. As I understand it, the normal JobGiver_OptimizeApparel.TryGiveJob checks all of the apparel in pawn.Map.listerThings.ThingsInGroup(ThingRequestGroup.Apparel) which is not the same list of apparel you'd like to check. This is where my confusion sets in, because apparel in change dressers is fair game for bills and caravans (this is another thing that confuses me, when WeaponStorage and ChangeDressers dump their inventory for caravan loading, AFAIK, this is not necessary). So, I have a couple of possible suggestions that I'd be happy to try to implement in a PR (or even just a hack in my own version).

1. Stop overriding the results of JobGiver_OptimizeApparel.TryGiveJob, instead, override the contents of pawn.Map.listerThings.ThingsInGroup(ThingRequestGroup.Apparel) in the prefix to whatever gear you'd like and then swap it back in the postfix (this would also have the benefit of being a little more future proof because you're not so dependent on the internals of the apparel optimization system and you benefit from any code optimizations made).
2. Refactor the ApparelUtils.FindBetterApparel method to be more functional (remove the ref parameters so it is easier to memoize and cache) and build data structures that allow you to ignore calculating apparel scores that don't require an update.
3. Use threading to dispatch a new job after you've calculated the best apparel without blocking the UI thread.
4. A combination of 2 & 3 where some threaded-task system is calculating best apparel and the JobGiver_OptimizeApparel.TryGiveJob is just an interrupt to create a job reflecting this apparel
5. Remove this harmony patch entirely because it might not do anything helpful (this is more a question of my understanding of the patch).

So, I don't know what causes this issue so no real easy reproduce steps, but from time to time, a trader won't open the trade screen, unless I save and then load the game again.
Not a big bug but it's kind of annoying.
Here's the logfile:
Bug.txt

Lets say I have 3 different outfits, worker, summer and winter clothing.
If I have someone on "summer" and draft it, after I release him from his duty he'll reset his outfit to "worker" as he changed to "soldier" when he was drafted.

like this.

Dropped Apparel_Duster736060 in a null map.
Verse.Log:Error(String)
Verse.GenDrop:TryDropSpawn(Thing, IntVec3, Map, ThingPlaceMode, Thing&, Action2) RimWorld.GenThing:TryDropAndSetForbidden(Thing, IntVec3, Map, ThingPlaceMode, Thing&, Boolean) ChangeDresser.Building_Dresser:DropApparel(Apparel, Boolean) ChangeDresser.Building_Dresser:DropApparel(List1)
ChangeDresser.Building_Dresser:Dispose()
ChangeDresser.Building_Dresser:DeSpawn()
Verse.ThingContainer:TryAdd(Thing, Boolean)
RimWorld.MinifiedThing:set_InnerThing(Thing)
RimWorld.MinifyUtility:MakeMinified(Thing)
RimWorld.MinifyUtility:Uninstall(Thing)
RimWorld.Designator_Uninstall:DesignateThing(Thing)
RimWorld.c__AnonStorey3CC:<>m__56F()
Verse.Command_Action:ProcessInput(Event)
Verse.GizmoGridDrawer:DrawGizmoGrid(IEnumerable1, Single, Gizmo&) RimWorld.InspectGizmoGrid:DrawInspectGizmoGridFor(IEnumerable1)
RimWorld.MainTabWindow_Inspect:DrawInspectGizmos()
RimWorld.InspectPaneUtility:ExtraOnGUI(IInspectPane)
RimWorld.MainTabWindow_Inspect:ExtraOnGUI()
Verse.WindowStack:WindowStackOnGUI()
RimWorld.UIRoot_Play:UIRootOnGUI()
Verse.Root:OnGUI()

Tried to spawn thing Apparel_Duster736060, but the map provided does not exist.
Verse.Log:Error(String)
Verse.Thing:SpawnSetup(Map)
Verse.ThingWithComps:SpawnSetup(Map)
ChangeDresser.Building_Dresser:DropApparel(Apparel, Boolean)
ChangeDresser.Building_Dresser:DropApparel(List1) ChangeDresser.Building_Dresser:Dispose() ChangeDresser.Building_Dresser:DeSpawn() Verse.ThingContainer:TryAdd(Thing, Boolean) RimWorld.MinifiedThing:set_InnerThing(Thing) RimWorld.MinifyUtility:MakeMinified(Thing) RimWorld.MinifyUtility:Uninstall(Thing) RimWorld.Designator_Uninstall:DesignateThing(Thing) RimWorld.<DrawInspectGizmoGridFor>c__AnonStorey3CC:<>m__56F() Verse.Command_Action:ProcessInput(Event) Verse.GizmoGridDrawer:DrawGizmoGrid(IEnumerable1, Single, Gizmo&)
RimWorld.InspectGizmoGrid:DrawInspectGizmoGridFor(IEnumerable`1)
RimWorld.MainTabWindow_Inspect:DrawInspectGizmos()
RimWorld.InspectPaneUtility:ExtraOnGUI(IInspectPane)
RimWorld.MainTabWindow_Inspect:ExtraOnGUI()
Verse.WindowStack:WindowStackOnGUI()
RimWorld.UIRoot_Play:UIRootOnGUI()
Verse.Root:OnGUI()

I keep getting this red error messages stating that there are duped items around.
I erased them manually but they came back in.
(It may be linked on "forcing" clothes on colonist and then drafting them)
Log:
Error Log duplication bug.txt

On the end, there's a map corruption maybe related to it?
Tell me if you need other mods in the list.
Thanks

Check this forum post:
https://ludeon.com/forums/index.php?topic=37177.msg385488#msg385488
Also this Github Issue:
Rock5/ButchersCanCountMeat#1

I think there's some patching somewhere that makes conflicts with the GUI.

I like to use multiple home bases in my game but doing so apparently means that a change dresser with mending attachment ignores space and time like the closet to narnia and teleports torn clothes right off of colonists to be fixed, and new clothes onto them without any rhyme or reason.
This is especially annoying if people in an arctic tundra base have warm clothes assigned to them and the magical wardrobe replaces them with t shirt and shorts, and you cannot get them back since they are now in the dresser a 4 day caravan away - at least until they get teleported unto someone else.
Worse still some clothes i cannot even find any more.
This happens without the pawns being interrupted in what they do and iirc even to pawns not selected at the time.
This might be related to how the dresser handles clothes, because if someone is ordered to haul clothes to the dresser the mending attachment has no time to kick in because the pawns will grab the clothes right away putting them on again, necessitating tricks with queued orders and whatnot to get them to repair their clothes.

So, I've reported this on forum but I think it's better here for a track on progress and also because I'll attach a video here.
The issue remains the same. Smokebelts and ShieldBelts won't get picked up again after a trade is performed.

I hope the video here is enough for a report:
https://www.youtube.com/watch?v=ToN-uAAAC-g

With the way the mod is currently implemented, the items stored in the dresser are not counted at workbenches. All make X clothing/armor bills at workbenches break.