khoadng / boorusama Goto Github PK

Describe the bug
Some items are rendered underneath the nav bar on my tablet in landscape a portrait mode. By under, I mean a lower layer, not an x-y coordinate location. Like the menu you get from swiping down from the top of the screen (quick settings, notifications, etc.) draws over whatever app you have open. This prevents the user from interacting with the items as they are obscured by the nav bar.

I seem to remember this happening to several things while I was trying to get familiar with the app, but I cannot remember exactly what they are. The most easy to reproduce is the page settings found on the main page with all the image thumbnails.

To Reproduce
Steps to reproduce the behavior:

1. Open the app
2. Tap on the gear in the upper right above the thumbnails
3. Tap any of the settings (page mode, image grid, image list, image quality)
4. The last item in the list of options is always rendered behind the nav bar

For example, if I try to change the image grid setting using the method above, the options small and medium are accessible but large is behind the nav bar and cannot be tapped on.

Expected behavior
Nothing should be rendered under/behind nav bar. Either the entire app window should be located above (x-y coord) the nav bar, or the navbar should auto hide if you want to use the fullscreen/immersive/edge-to-edge interface.

Screenshots

Smartphone (please complete the following information):

• Device: tab s8 ultra
• OS: Android 14
• Version: 3.18.1

Is your feature request related to a problem? Please describe.
When you touch / open an image or a GIF that is large / big (I think bigger than 1000x1000) on a browser on for example rule34.xxx or gelbooru.com, the site displays a smaller version of the image / first frame for a gif and shows a message "This image has been resized. Click here to view the original image. Always view original. Don't show this message." for rule34 and "Click here to expand image." for gelbooru to have the original image or have the animated gif.

In the case of Boorusama, it is always the smaller version / first frame of the gif that is displayed. You can't have the looping gif unless you go to the three dots menu and choose "View original". Except the loading of the gif takes some seconds (I think because of the API).

Describe the solution you'd like
The gif is directly loaded upon touching it, with "minimal" loading times. It can be switched with an option in "Settings > Performance" with something like "Large Image behaviour" with 2 options :

• Show preview image (current behaviour)
• Show original image (with some text showing "This may increase loading time")

Describe alternatives you've considered
Reduce the loading time to display the original GIF (if possible). Otherwise converting the GIF to WEBM but I don't know if making a video without a common ratio aspect (16:9, 9:16...) is a good idea.

Additional context
Examples gifs (both are NSFW and I've added a space after the ":" in case of bots) : https: //rule34.xxx/index.php?page=post&s=view&id=9423110 and https: //gelbooru.com/index.php?page=post&s=view&id=7569089

Describe the bug
No sound while playing videos.

Smartphone (please complete the following information):

• OS: Android 11

Is your feature request related to a problem? Please describe.
Having to go to the hamburger menu at the very far top left corner to open a sidebar is painful and uncomfortable.

Every mean of navigation is on the sidebar, so if I want to do anything I have to go to this corner. This especially becomes a problem with one-handed use.

Also the placement of booru profile, that thing is even further to the left than the hamburger menu, so if I want to quickly switch to another booru it becomes even more frustrating

Describe the solution you'd like

1. Swipe gesture to open a sidebar (https://github.com/NO-ob/LoliSnatcher_Droid) or it can be a setting where the user can set the amount of screen area to trigger a swipe (https://github.com/jiangtian616/JHenTai)

2. Make it floating action button and put it at the bottom right

3. Put the entire search bar to the bottom (https://github.com/nullxception/boorusphere). In fact this can go even further by making another button in the search bar where it can be used as a booru selection

Any change that makes it not focused on the top left corner is fine by me

Describe alternatives you've considered
All the app in the solution

Additional context

Is your feature request related to a problem? Please describe.
Being able to preview images at highrst quality when I'm connected to wifi (or unmetered network), and change to another when not, like low.

Describe the solution you'd like
The current quality setting to be split in two, maybe.

Describe alternatives you've considered
n/a

Additional context
To not consume much data from my data plan by accident.

I'm not sure what is causing this, other apps and viewers works just fine, and this one works great on my phone, however on my galaxy tab s9 ultra, you need to swipe with extreme percision. About 80% of my swipes simply don't register. To get more to register I need to swipe extactly from the middle and directly left or right, without so much as a 5 degree angle. I don't know if it's on all tablets or just mine. Forced to basically use the arrows, which is far from ideal on a tablet.

Describe the bug
When searching tags on Hypnohub on Gelbooru (Not V1 or V2) the Tagging system breaks down and gets "stuck" with whatever tags were previously seen.

To Reproduce
Steps to reproduce the behavior:

1. Add Hypnohub
2. Click on an image
3. See tags
4. Swipe to next Image
5. See bug (Tags not changing)

Expected behavior
Tags switching from image to image.

Screenshots
If applicable, add screenshots to help explain your problem.

Screenshot 1

Screenshot 2

Smartphone (please complete the following information):

• Device: Samsung A73
• OS: Android 13
• Version app: 3.5.0

Additional context
Switching to Gelbooru V2 fixes the problem. This only happens in Gelbooru API not V1 or V2.

Discussed in #316

I noticed than part of text in application dosent have a keys in en.json. Can you add them for better translating experience?

Is your feature request related to a problem? Please describe.
Kinda, When i'm navigating one-handed it gets kinda stubborn sliding to navigate between posts

Describe the solution you'd like
Navigation through volume physical keys

Describe the bug
In settings > edit current profile > download > custom file format the text box and available tokens list are obscured or behind the onscreen keyboard. The user can still input text, but they cannot see what is being typed.

To Reproduce
Steps to reproduce the behavior:

1. Go to settings > edit current profile > download > custom file format
2. Tap to enter text into the bulk download naming box ({index}_{md5:maxlength=8}.{extension} is there by default for me)
3. The onscreen keyboard pops up and covers the text box and the available tokens list

Expected behavior
I am not sure how to describe this properly, but the app window should either scroll up or should be shrunk to make room for the keyboard. I would desribe this as the keyboard pushing the app window up out of the way.

Screenshots

Smartphone (please complete the following information):

• Device: tab s8 ultra
• OS: android 14
• Version: 3.18.1

Is your feature request related to a problem? Please describe.
The video player does not support the same gestures as the image viewer. For example, if I set the swipe down guesture to download the image in the booru profile settings, it does not work when viewing a video. I remember seeing somewhere on github that guestures are not currently supported on videos. This is a vote to get that fixed.

Also, the settings menu while viewing a video is not the same as in the image viewer. In the image viewer I get options to Download, View in Browser, View Tags, etc. In the video viewer there is only an option to change playback speed or cancel.

Describe the solution you'd like
Make guestures and settings menu consistant on both images and videos.

Describe the bug
When clicking on top of images they don't load as full images. Only loads thumbnails.

To Reproduce
Steps to reproduce the behavior:

1. Add AI Booru
2. If asked set the API to Danbooru
3. Click on any image
4. See bug.

Expected behavior
That full sized images would load.

Screenshots
Expectation (Danbooru)
Reality (AI booru)

Smartphone (please complete the following information):

• Device: Samsung A73
• OS: Android 13
• Version app: 3.5.0

Additional context
This is not an API problem.

Describe the bug
There is only bookmark button, but no favorite button when using Gelbooru. Not only that, I found that there's no way to favorite an image. At the "gestures" tab under Gelbooru's booru profile editing page, all of the gestures dropdowns only show: none, download, save, share, toggle bookmark, view tags, view original, and open source (no favorite option).

To Reproduce
Steps to reproduce the behavior:

1. Open app
2. Create a new booru profile (swipe from left edge of screen to right and then click the plus shaped button)
3. Enter https://gelbooru.com/
4. Enter User ID and API Key found in user's Gelbooru profile
5. Press OK
6. Switch the app's profile from the default Danbooru to Gelbooru
7. Click on any image
8. The button to favorite the image is missing. There are only bookmark, download, comment, and share buttons.

Expected behavior
The button to favorite the image should be present.

Screenshots
Gelbooru:

Danbooru:

Smartphone (please complete the following information):

• Device: Samsung Galaxy J3 Pro
• OS: Android 9
• Browser: Brave browser for getting the API, Boorusama for viewing the Gelbooru
• Version: Boorusama version 3.16.0
• Gelbooru API Version: 0.2.5

Is your feature request related to a problem? Please describe.
When you open a video, sometimes it is better to play it faster (or slower), like on Youtube.

Describe the solution you'd like
A play speed icon next to the mute icon that allows to change playback speed like on Youtube (x0.25, x0.5, x0.75, x1, x1.25, x1.5, 1.75, x2).

Describe alternatives you've considered
2 buttons, a fast-forward and a rewind below the seek bar which would allow to increase or decrease the speed of the video. Thing is you change video speed often so the first solution seems better to me.

Additional context
Add any other context or screenshots about the feature request here. (optional)
Nothing to add, basically the same feature that is on Youtube.

Currently when you tap a tag it just opens a new search with that one tag. Often times I want to add that tag to my existing search.

Adding a context menu option when you long press would be nice. Ideally there is a setting to select the default behavior between new search or add to existing.

When viewing media, it streams content from the booru. If the file has been downloaded, stream the media from the downloaded file. If the file has been downloaded but moved to another place and can't be located, stream from the booru again.

If storage is a concern, this could apply to just bookmarks.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

To download a saved search tag, we need to go to saved search, select the tag to do a search and then select buk download.

Describe the solution you'd like
A clear and concise description of what you want to happen. (optional)

Add an option to select one or multiple tags from saved search directory on bulk download window.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered. (optional)

Empty.

Additional context
Add any other context or screenshots about the feature request here. (optional)

Empty.

The gesture overrides have a "None" option which just uses the default, but there doesn't seem to be a way to disable a gesture. For example, disabling the "go back" swipe gesture by flicking the image down (I accidentally do it way too often and prefer to use the screen edge for nav)

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
If I use the page mode pagination and I go on - for example - page 3 and refresh the page (by pulling down) it automatically jumps back to page 1.

To Reproduce
Steps to reproduce the behavior:

1. Enable page mode "Pagination" in Settings -> Appearance
2. Go to a page other than 1 in a Booru; e.g. page 3 of Gelbooru.
3. Pull down the page to refresh

Expected behavior
I expect to stay on the page I was on. If I pull down to refresh on page 3 I expect to stay on page 3; especially if I refresh accidentally.while scrolling.

Smartphone (please complete the following information):

• Device: Samsung Galaxy S23+
• OS: Android 14
• Boorusama: 3.12.2

Is your feature request related to a problem? Please describe.
There is no sort option

Describe the solution you'd like
It would be nice to have a sort images like sort by popularity, sort by date, sort by oldest or newest etc

rule34.xxx downloads stopped working

It would be convenient to have an option for searches to open as new tabs. Right now searches are stack based and you can only go back one at a time. Sometimes I want to search multiple things without having to keep fussing with the search history (which will also reset your scroll)

The UI below the image doesn't appear nicely like a drawer and instead it causes the image to jolt around the screen. It doesn't feel good to use and is kind of nauseating.

Describe the bug
When I scroll through the booru feed and try to access the search at the top, the panel often disappears instead of opening. It feels random and unresponsive, so I have to scroll back to the beginning in order to get reliable access to searching.

To Reproduce
Steps to reproduce the behavior:

1. Open any feed inside the app
2. Scroll down
3. Try to access the search panel until you face this problem

Expected behavior
The search panel should always open the search parameters when being pressed instead of disappearing.

Video recording
https://github.com/khoadng/Boorusama/assets/40635760/1f9d4b8f-60e8-46d7-a4aa-bdcf480942a9

Smartphone:

• Device: OnePlus 11 16/256 EU
• OS: Android 13 (OxygenOS 13.1)

Currently, instead of being cached, video playback is always being streamed repeatedly.

This is an issue for users with limited data plan as the continuous stream could impact their bandwidth usage.

Video caching feature as seen in most internet browsers would be appreciated!

Describe the bug
When the user views the original image in the image viewer and uses the rotate button, the app rotation is locked until the app is force stopped. In my case if I tap the rotate button once the screen is locked to a landscape mode. If I tap the rotate button twice the screen is locked to a inverted landscape mode (upside down).

To Reproduce
Steps to reproduce the behavior:

1. Open an image in the image viewer
2. Tap on the settings icon
3. Choose View Original
4. Tap rotate icon
5. Can tap icon again if wanted

Expected behavior
Using the rotate button should either rotate the image only while the app is not rotated, or the whole app should be rotated but it should revert to auto-rotation when the image is closed.

Screenshots




The final screenshot above was actually taken upside down as you can see by my writing.

Smartphone (please complete the following information):

• Device: tab s8 ultra
• OS: android 14
• Version: 3.18.1

Describe the bug
First of all, you can see the posts in the background before you even start interacting with the password field.
And worst of all, you can just tap on "cancel" and, instead of closing the app, it just lets you use the app normally.
Like it never needed a password.

To Reproduce
Steps to reproduce the behavior:

1. Go to the privacy settings and have biometrics lock on.
2. Open the app
3. Instead of bothering to put the password just click on cancel
4. Now you can use the app normally

Expected behavior
The app should be closed and unable to be accessed until the biometrics have been completed.

Screenshots
Unable to take one as the biometrics screen prevents you from taking screenshots

Smartphone (please complete the following information):**

• Device: Samsung Galaxy Tab A7 Lite
• OS: Android 14
• Browser Google Chrome
• Version 3.13.1 (Google play store)

Additional context
Having an option for secure screen would be good

Is your feature request related to a problem? Please describe.
As of now favorite searches are global.

Describe the solution you'd like
Make searches favorited when browsing Safebooru (e.g.) only visible when Safebooru is selected, hide them when browsing Gelbooru (e.g.)

Describe the bug
The folder select button is not working.

To Reproduce
Steps to reproduce the behavior:

1. Search for any tag
2. Click on Bulk Download or directly open bulk download and select a tag
3. When clicking on Folder Select, nothing happens
4. Also don't work with normal downloader -> settings -> folder

Expected behavior
Should open file explorer to select output folder

Smartphone:

• Device: Samsung Galaxy
• OS: Android

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
While logged in to danbooru, the "saved search" list seems to fail

To Reproduce
Steps to reproduce the behavior:

1. Configure to use danbooru.donmai.us
2. Login to a user account
3. Scroll down to "Saveed search"
4. See error

Smartphone (please complete the following information):

• Device: Galaxy Tab A (8", 2019)
• OS: Android 11

There is something that I have noted, first off this only seems to affect danbooru.donmai.us... safebooru.donmai.us is unaffected by this.
On a side note the saved search meta tag is also not working but only on danbooru.donmai.us.

While viewing an image, the download icon at the bottom registers a tap, but does not download image. When opening the options menu in the top right and tapping download, it registers the tap and closes the menu, but does now download the image. The only way I have found to successfully download an image was by using the menu to view in browser.

Due to heavy load from certain area, e.g. Asia, danbooru site's admin has turned on WAF (Web Application Firewall) as a solution to non-human accesses. But this also affects third-party apps' normal workflow. For example, in Boorusama, it'll report Something went wrong and stop working. Glad that other apps' developers have solved this problem:

• flexbooru/flexbooru@80fc0c4
• flexbooru/flexbooru@f50807c
  • https://github.com/tachiyomiorg/tachiyomi/blob/master/core/src/main/java/eu/kanade/tachiyomi/network/interceptor/CloudflareInterceptor.kt

Hope you can add this exception handling to this app, which, in my opinion, is the best app for accessing danbooru by far.

Is your feature request related to a problem? Please describe.
The current way of doing disjunction (OR) in searches is to prefix each tag with ~ (for example, ~tag1 ~tag2). This works for Danbooru but is deprecated in favour of an infix operator or (the previous example is equivalent to tag1 or tag2).

Additionally, the prefix ~ operator doesn't work with other boorus, such as Gelbooru, which expects the infix ~ operator surrounded by brackets ({tag1 ~ tag2}, or ( tag1 ~ tag2 ) for older versions of Gelbooru; the spaces by the brackets are important).

Describe the solution you'd like
I would like support for these operators in Boorusama

Describe alternatives you've considered
A way to use raw search queries would help. Boorusama automatically does things to tags that don't allow for raw queries, such as automatically inserting underscores into spaces or removing duplicate tags. It's probably best to integrate search operators into Boorusama's native UX, but the fact that edge cases will always appear makes it desirable to be able to use raw search queries for boorus that are not currently natively supported.

Swiping left when on the image list should pull out the side menu as a drawer. It's easy to misclick the drawer icon on a phone. The drawer icon is also not visible once you're in a search.

Is your feature request related to a problem? Please describe.
Explicit content can either be fully visible or filtered completely from search results, there is no option in between.

Describe the solution you'd like
Adding an option to blur explicit materials under the "content filtering" setting in the profile menu with the same options like "None, Aggressive" etc.

Additional context
This feature was inspired by the content blurring option of the "Boorusphere" application:

When I try to download using the bulk option I get an error message

Is your feature request related to a problem? Please describe.
While the app is extremely good and works well, there is a lack of support for certain APIs that competitors like Loli Snatcher provide. It is a very strong contender for me, but thanks to the lack of APIs available I cannot have all my favorite boorus accessible.

Describe the solution you'd like
Try to look at the API list of Lolisnatcher and find a way to implement in future an equivalent API list for more Booru access.

Describe alternatives you've considered
My alternative here would be to slowly add the APIs that are listed, starting with whatever APIs are easier to get to, or the APIs that I need atm.

The booru APIs that I use:

• Danbooru
• e621
• Gelbooru
• Sankaku
• Philomena
• Shimmie
• GelbooruV1

Additional context
APIs that Loli Snatcher has Access to:

https://files.catbox.moe/6y8p0p.jpg

https://files.catbox.moe/9vfisa.jpg

https://files.catbox.moe/geh1ob.jpg

An addendum, sometimes the automatic detection doesn't detect the correct Booru, such as with hypnohub being said that it likely won't work when it uses the same exact API as Gelbooru.