Code Monkey home page Code Monkey logo

spice-of-life-potato-edition's People

Contributors

acgaming avatar cazsius avatar juliand665 avatar kevun1 avatar lewismcreu avatar rover656 avatar seanchengn avatar

Stargazers

 avatar  avatar

spice-of-life-potato-edition's Issues

[Compatibility] Culinary Construct Sandwiches

Hey Kevun1!

My friends and I are really enjoying this incentive towards curated fooding.
One of our other long time favs (since 1.12 anyway) is Culinary Construct - link

It allows you to create compound food items of up to 6 different edibles - any defined "Bread" or a bowl and 5 other ingredients, of which the saturation and hunger restoration are added up and split between a multiple of sandwiches so that the end result restores no more than 10 (5 whole legs lol) of hunger. It also lets you name them!

Right now, SoL:P recognizes each sandwich or bowl as the same, regardless of ingredients, recorded in the log as "Sandwich" and "Bowl of Food"

Could each sandwich with different ingredients be treated as a different SoL:P food item?

My workaround for the SoL:P saturation would be defining the Default to be something higher, and then defining all other known foods to lower values.
But if you have another suggestion, or think something like working ingredients defined values for SoL:P into a similar divided calculation is possible, lemme know!

Cheers!

[1.16.5] Eating Food from Lunchbox Doesn't Add to the Diversity List

Description
When I eat food from the Lunchbox, then check the book to see the diversity, it just has a blank "Air" square there.
image
No matter how many different foods I eat they all show up as a single "Air" entry.

To Reproduce
Eat food directly from the Lunchbox and then check the food book.

Mod version and Forge version
SolPotato: 1.1.0
Forge: 36.0.42

NOTE: This is not a duplicate of #14 as it doesn't involve the Diet mod.

FoodContainerItems do not respect Item#getContainerItem

Description
When eating a food that has a container, like Vanilla Rabbit Stew, from a FoodContainerItem you don't get the bowl back.

Crashlog
No crash

To Reproduce
Be hungry
Put minecraft:rabbit_stew in any of the lunch bag/boxes that is otherwise empty
Eat from the bag/box
Don't get a bowl back

Mod version and Forge version
Forge 1.16.4-35.1.37
SOLPotato 1.16.4-1.0.7

[First Aid Compatibility] Health Depletion on eating foods

So I thought it was happening only when I broke a new threshold, but I guess it's actually any time I eat food if I'm above the first threshold.
It goes, I eat, I take damage, all the debuffs for area damage are applied, and my first aid health gui shows all hearts empty, but then I stay alive until the next dmg instance.

Other mods that are modifying my health system -

First Aid - https://www.curseforge.com/minecraft/mc-mods/first-aid
LevelHearts - https://www.curseforge.com/minecraft/mc-mods/levelhearts
Simple Absorption - https://www.curseforge.com/minecraft/mc-mods/simple-absorption
Stats Keeper - https://www.curseforge.com/minecraft/mc-mods/simple-absorption

If there's any other information I can provide to help, please let me know!

[Crash][1.16.4][MP] Crash when sorting? backpack

Description
I was going through my large backpack, tried sorting with a sorting button, and crashed to desktop

Crashlog
https://pastebin.com/zY2XZNYC

Snippet
Description: Rendering screen

java.lang.NullPointerException: Rendering screen
	at com.kevun1.solpotato.tracking.FoodList.getComplexity(FoodList.java:219) ~[solpotato:1.16.4-1.0.1c] {re:classloading}
	at com.kevun1.solpotato.tracking.FoodList.calculateDiversityContribution(FoodList.java:191) ~[solpotato:1.16.4-1.0.1c] {re:classloading}
	at com.kevun1.solpotato.client.TooltipHandler.onItemTooltip(TooltipHandler.java:44) ~[solpotato:1.16.4-1.0.1c] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraftforge.eventbus.ASMEventHandler_138_TooltipHandler_onItemTooltip_ItemTooltipEvent.invoke(.dynamic) ~[?:?] {}
	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-3.0.5-service.jar:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) ~[eventbus-3.0.5-service.jar:?] {}
	at net.minecraftforge.event.ForgeEventFactory.onItemTooltip(ForgeEventFactory.java:271) ~[forge:?] {re:classloading}
	at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:699) ~[?:?] {re:mixin,re:computing_frames,re:classloading,pl:mixin:APP:quark.mixins.json:ItemStackMixin,pl:mixin:A}
	at net.minecraft.client.gui.screen.Screen.func_231151_a_(Screen.java:123) ~[?:?] {re:computing_frames,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screen.Screen.func_230457_a_(Screen.java:118) ~[?:?] {re:computing_frames,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.gui.screen.inventory.ContainerScreen.func_230459_a_(ContainerScreen.java:164) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.ContainerScreenAccessor,pl:mixin:A,pl:runtimedistcleaner:A}
	at info.u_team.u_team_core.screen.FluidContainerScreen.func_230459_a_(FluidContainerScreen.java:63) ~[uteamcore:3.1.17.191] {re:classloading}
	at info.u_team.u_team_core.screen.UBasicContainerScreen.func_230430_a_(UBasicContainerScreen.java:26) ~[uteamcore:3.1.17.191] {re:classloading}
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:290) ~[forge:?] {re:classloading}
	at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:491) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:976) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.4-forge-35.1.28.jar:?] {re:classloading,pl:runtimedistcleaner:A}
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_271] {}
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271] {}
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_271] {}
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_271] {}
	at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.4-35.1.28.jar:35.1] {}
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.6.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.6.jar:?] {}
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.6.jar:?] {}
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.6.jar:?] {re:classloading}
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.6.jar:?] {re:classloading}

To Reproduce
Will try to reproduce

Mod version and Forge version
MC1.16.4
Forge 35.1.28
SoLPotato 1.0.1c

[suggestion] Try to add support for Appleskin

ik you said that you cant without the api, but I found that another mod uses its saturation overlay system when replacing the game slots (classic health bars)

image

to futher go on appleskins code seems to be open to the public on github for 1.16 and stuff

Right clicking on fence with lead crashes server.

Description
This is a cross post from Vaskii's Quark Github as both that mod and SOL Potato Edition are referenced in the stack trace. As the title states, right clicking with a lead onto a fence is causing players to crash. This is happening in a Server multiplayer environment. Minecraft version is 1.16.5 and Forge version is 36.1.4

Link to report on Vaskii's Quark Github: VazkiiMods/Quark#3218

Link to modpack involve: https://www.curseforge.com/minecraft/modpacks/life-in-the-village-2

Crashlog

latest (5).log
crash-2021-06-03_20.14.54-server.txt

To Reproduce
Right click on a fence with a lead while running the above referenced modpack.

Mod version and Forge version

Minecraft 1.16.5
Forge 36.1.4

Max Health sometimes increases by current bonus when joining after restart.

Description
When the server is restartet and a Player joins it can happen that instead of 15 Harts the player has 20.
This change is permanent and it can happen multiple times (20 -> 25 ...)

I have not been able to reproduce this reliably but it happened two times to only one player and once to two players.

Mod version and Forge version
solpotato-1.16.X-1.1.0
forge-1.16.4-35.1.37

Server Crash when player dead.

Description.
When a player is dead, it caused a crash.
Most of the time, this crash seems to be happening on Mohist, but I was running a forge server on Linux.

Crashlog
https://pastebin.com/UXKpsBfZ

To Reproduce
I was just dead

However, this bug has been seen since the mod was updated, and the mods added are as follows.
ScalingHealth-1.16.5-4.1.5+11
champions-forge-1.16.5-2.0.1.15
BrassAmberBattleTowers-1.16.5-1.6.3
hexblades-1.16.5-0.0.9.3
interactive_corporea-1.2
sanguinearsenal-1.16.5-1.8
eidolon-0.2.7
mowziesmobs-1.5.27
SereneSeasons-1.16.5-4.0.1.127-universal
sereneseasonfix-1.16.5-1.0.5
geckolib-forge-1.16.5-3.0.104
L_Enders Cataclysm-0.48-1.16.5
dungeons_mobs-1.16.5-2.2.1
dungeons_libraries-1.16.5-1.0.0

Mod version and Forge version
solpotato-1.16.X-1.1.0
1.16.5 Forge 36.2.39

Lunchbox consumes bowls [MC v1.16.5]

Is it possible to make the lunchbox return or drop bowls after consuming items like rabbit stew, suspicious stew, etc.?

I also have a mod installed (not sure which, off the top) that allows these items to stack and the lunchbox does not respect stack size--eating once consumed a stack of like 12 rabbit stew, bowls and all. If possible, add a check to preserve stack amt. too?

Thanks!

Stuck at 16.50 diversity

Description
Food diversity stuck at 16.50 and not going up even with best foods of 15-16 value.

To Reproduce
Eat different foods up to 16.50

Mod version and Forge version
1.16.X-1.1.0

Regeneration Issue

I'm having an issue that when a player fills up their hunger bar they won't regenerate and hearts.

Mod Version: 1.1.0
Forge Version: 36.2.0

Mod spams server

Updated today to new version and the mod spams stuff like this whenever anyone eats to the server logger

[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [attribute, generic.max_health, 1.0]
[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [attribute, generic.armor_toughness, 1.0]
[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [attribute, generic.armor_toughness, 1.0]
[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [effect, strength, 1.0]
[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [attribute, generic.max_health, 1.0]
[23:23:59] [Server thread/INFO] [STDOUT/]: [java.util.ArrayList:forEach:-1]: [attribute, generic.max_health, 1.0]

Compability Problem with Quark Item Sharing

Description
Spam sharing any item causes the game to crash.

Crashlog
Crashlog

To Reproduce

  1. Take a random item
  2. Click Shift+T as fast as you can
  3. Server crashes

Mod version and Forge version
Tested with the Modpack Engineers Life 2 1.02a
Mod Version: 1.10
Forge Version: 36.1.0

Game does not fully launch due to mixin conflicts

Description
Game does not finish launching due to mixins

Crashlog
Description: Mod loading error has occurred

java.lang.Exception: Mod Loading has failed
at net.minecraftforge.fml.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:85) ~[forge:?] {re:classloading}
at net.minecraftforge.fml.client.ClientModLoader.completeModLoading(ClientModLoader.java:188) ~[forge:?] {re:classloading,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.lambda$null$1(Minecraft.java:508) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:itlt:CustomWindowTitle,xf:fml:randompatches:RandomPatches Minecraft Transformer,pl:mixin:APP:shutupexperimentalsettings.mixins.json:client.MixinMinecraft,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.util.Util.func_215077_a(Util.java:418) ~[?:?] {re:classloading,xf:OptiFine:default,xf:fml:jmt_mcmt:UtilExecutorListingHack}
at net.minecraft.client.Minecraft.lambda$new$2(Minecraft.java:504) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:itlt:CustomWindowTitle,xf:fml:randompatches:RandomPatches Minecraft Transformer,pl:mixin:APP:shutupexperimentalsettings.mixins.json:client.MixinMinecraft,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.gui.ResourceLoadProgressGui.func_230430_a_(ResourceLoadProgressGui.java:172) ~[?:?] {re:classloading,xf:OptiFine:default}
at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:802) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,xf:fml:astralsorcery:reach_set_client_renderer}
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:976) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:itlt:CustomWindowTitle,xf:fml:randompatches:RandomPatches Minecraft Transformer,pl:mixin:APP:shutupexperimentalsettings.mixins.json:client.MixinMinecraft,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:itlt:CustomWindowTitle,xf:fml:randompatches:RandomPatches Minecraft Transformer,pl:mixin:APP:shutupexperimentalsettings.mixins.json:client.MixinMinecraft,pl:mixin:APP:immersiveengineering.mixins.json:accessors.client.MinecraftAccess,pl:mixin:APP:assets/botania/botania.mixins.json:AccessorMinecraft,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.4.jar:?] {re:classloading,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_242] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_242] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_242] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.4-35.1.13.jar:35.1] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.6.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.6.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.6.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.6.jar:?] {re:classloading}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.6.jar:?] {re:classloading}

To Reproduce
Launch the game with any of the mods listed in the crash report (botania as an example)

Mod version and Forge version
Mod Version: 1.0.0 (still present in v 1.0.1)
Forge Version: 35.1.28

[1.16.5] Excessive Max Health Sometimes Added

Description
Sometimes when I restart my server, I get an extra line of ten hearts, on top of the extra ten I'm getting from being at max diversity! Every time it happens, I get another ten hearts, and I'm now at 50 (100 hp). I tried using the command "/attribute @p minecraft:generic.max_health base set 20" but that doesn't work -- unless I change the number to something lower! If I set it to -40 (hp), it cancels out the 30 extra hearts (60 extra hp) for a while, until I get another set of ten hearts when it happens again.

To Reproduce
Keep up with the dietary diversity to get the ten extra hearts, and periodically exit and return to the world/server for a while and eventually it will happen! I don't know exactly what triggers it.
Oh yes, I have modified the config: https://pastebin.com/Ui6pEF8j

Mod version and Forge version
MC 1.16.5
Forge 36.2.5
SolP 1.1.0

Crashing on Config Edits [Simple Absorb + Survive Compatibility]

After adding attributes to the config with just these three mods installed, the world crashes while trying to load in.

crash-2021-01-04_09.55.25-server.txt

To Reproduce
Changed base absorptoin to 20 in config and added ";attribute,simple_absorption:absorption_max,4" to the first three thresholds (which worked without survive)
Reload into world and it closes down.

Mod version and Forge version
Forge Latest ~ .29
Survive 3.0.7
Simple Absorption 1.2.0
SoL:Potato 1.0.6

Calculating Maximum Diversity

I just wanted to share that I think I've found a formula for calculating maximum diversity, assuming all food items have a contribution of 1.0. Obviously things get complicated when you account for varying contribution.

(QueueSize * Minimum) + (1 - Minimum) * (DecayStart + (DecayEnd - DecayStart + 1) / 2)

Food disappears from lunchbox

Description
Sometimes food disappears from the lunchbox (any).

To Reproduce
It's now happened to two different players on my server. I'm not 100% sure when it happens. For me it seems like if I have it in inventory with food in it, log out and come back but not always. Some else reported it when changing game modes. I realize that's not much to go on but I haven't identified anything more specific yet.

Mod version and Forge version
mod: 1.16.X-1.1.0
forge: 36.1.15

Removing negative effects?

Description
Basically, I'm trying to further incentivise a diverse diet so by only eating 3 foods you get some negative effects. However I'm not sure if what I'm trying to do is just not possible. So for example setting effect hunger 0 at 0.0 threshold causes hunger to always remain. Like basically I want the negative effects to go away after eating 4+ foods.

To Reproduce
thresholds = [0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 10.0, 15.0]
benefitsUnparsed = ["effect,hunger,0", "effect,hunger,-1", "", "", "", "", "", ""]

Mod version and Forge version
forge 36.2.9
sol 1.16.x.1.1.0

Duplicate Keybind

Description
The "Open Food Book" keybind is registered twice in the controls list. This isn't a problem by itself but can cause issues with other mods.

Crashlog
This crash occured when using the mod Controllable
crash-2021-08-08_17.08.41-client.txt

I opened an issue there for it as well #223

To Reproduce

  1. Install Spice of Life: Potato Edition
  2. Navigate to controls menu
  3. See double entry for Open Food Book under Spice of Life: Potato Edition

Mod version and Forge version
Minecraft Version: 1.16.5
Forge Version: 36.2.2
Spice of Life: Potato Edition Version: 1.1.0
Controllable Version: 0.13.3

My best guess is that registerKeybinds() is being called twice from "SOLPotato.java" on line 56 and 57.
Once because it appears in SOLClientRegistry.setup() and then again on line 57, but that's just a guess!

Thanks for any help and for the mod!

Bug / Compatibility suggestion for SoL: Carrot Edition

Description
Food eaten through the lunchbox does not contribute to SoL: Carrot Edition. They do not register as being eaten.

To Reproduce
Eat food through the lunchbox.

Mod version and Forge version
Forge: 35.1.37
SoL: Potato Edition: 1.1.0

small food diversity

Why foods that add 0.5 hunger give the same amount of points as diversity? you have to eat them at least 3 times to fill your hunger bar a bit, completely destroying your diversity. It should be based on hunger the food fills not 1.0 for every food item.
3 watermelon slices should count similarly to 1 steak, not 3 steaks in a row

Player benefits not applied on respawning

Description
The benefits applied to a player are not being set when the player respawns. Leaving and rejoining the server is a temporary fix to this. This is most likely due to the PlayerRespawnEvent event handler not calling updatePlayer(), as done in the onPlayerLogin method.
This is only noticeable if resetOnDeath config is true and some benefit is applied when a player has a diversity of 0.0. For example, I was trying to have max_health adjusted by -14 for a player who has a diversity of 0.0. A player who has just died will have a diversity of 0.0, but upon respawning, their max health has not been adjusted from the default.

To Reproduce

  • In the server config file, add a 0.0 to the thresholds list and some corresponding benefit to the benefitsUnparsed list so a player with 0.0 diversity should have that benefit applied.
  • Also change resetOnDeath to be true.
  • Ensure that minFoodsToActivate is 0.

With this configuration, a player who has died will have their diversity reset to 0.0. As such, once they respawn, the benefit associated with having a diversity of 0.0 should be applied. However...

  • Now in the game, confirm having a diversity of 0.0 applies the benefit you associated with it.
  • Optionally increase your diversity by eating something.
  • Kill yourself with /kill or whatever.
  • Once you respawn, your diversity will be 0.0 as expected, but the associated benefit will not have been applied.

Clearly, there is a problem where a respawning player is not updated by the mod. Interestingly, but not really relevant, the food book assures you that the 0.0 threshold has been passed and the benefit has been applied.

Possible Fix
After having a peek at the code, I think I've spotted an approach for a fix. I'm not familiar with the codebase or Forge but it seems that we just need to add an event handler for a player spawning in BenefitsHandler.java, which would look much like the onPlayerLogin method already present there. (Also see onPlayerRespawn method in CapabilityHandler.java).
Hope you can reproduce easily, it's only a small bug but would be nice to fix!

Mod version and Forge version
Mod: 1.16.X-1.10
Forge: 36.2.2

Getting buffs from food in multiplayer apply to all players

I play on a small server with friends, and whenever someone consumes enough food to get benefits from it, everyone will get the buffs. As far as we're aware this is not an intended feature; we couldn't find any configs relating to it, and there's been no other bug reports relating to this issue either.

Suggestion Diversity By Hunger

Hey would it be possible to make it so that the default diversity contribution of a food was based on its hunger restored?

Lunchbox intelligent auto-restock

Does this function exist in this version of the mod?
If yes, how do I use it?

In case it's not clear what I mean, the Lunchbox had a function where you could shift-rightclick on a container and the lunchbox would auto-fill itself from the container with food items that would give you the most profit on eating.

Diet's Food group nutrition values don't update when eating food from a lunchbag or lunchbox

Description
I recently started using a mod called Diet which adds a system similar to the nutrition mod on 1.12 where each food contributes to a different "food group" like in the pictures below:
2021-02-18_22 05 33
2021-02-18_22 08 00
However, When I eat the food out of the lunchbags and lunchboxes added by your mod they do not contribute to nutrition values that they are supposed to. When I take the food out of the lunchbag/lunchbox then the nutrition values update correctly.

(I've already opened an issue on their github to see what they can do about it: illusivesoulworks/diet#4)

To Reproduce

  1. Start up a world with this mod and diet installed.
  2. Grab a lunchbag or lunchbox and put some food in it.
  3. Eat some food out of the lunchbox/lunchbag
  4. Look at nutrition values to see if they have increased.
  5. They are at the same level as they were before you ate something from the lunchbag/lunchbox

Mod version and Forge version
SolPotato: 1.1.0
Forge: 36.0.42
Diet: 0.2

Server crash

Description
Server crashed and mentions SOL:Potato extensively

Crashlog
https://pastebin.com/x47QhdXn

To Reproduce
Unknown.

Mod version and Forge version
Forge: forge-1.16.4-35.1.37
SOL Potato: solpotato-1.16.X-1.1.0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.