Comments (5)
Use position!()
, which returns the current byte offset into the input string. It usually makes more sense to store these byte offsets in the AST and convert to line:col form only when needed for an error message for performance and storage reasons, but you could do that mapping within the parser if you really needed to.
The implementation in peg used for the default error messages just counts the `\n' in the slice before the position, in linear time, since it's called at most once. That would be slow to run for every AST node. In Signalspec, I build an index of line start offsets, and binary search it to convert byte position to line in logarithmic time.
from rust-peg.
Yes, the current implementation would be inefficient for multiple, successive calls.
Line numbers have been requested by other GitHub users before me. I rather enjoy PEG and would love to see this feature gain more support.
from rust-peg.
You could build the index before parsing, pass it in as a grammar argument, and write a rule that wraps position!()
to do the lookup in the index. Doing that doesn't belong in this library because most users would be better off deferring byte position to line mapping past the AST anyway.
from rust-peg.
Hmm, food for thought.
Thank you for offering (several) workarounds. I admit feeling some anxiety about managing my first AST. I'll see what I can do.
from rust-peg.
You could build the index before parsing, pass it in as a grammar argument, and write a rule that wraps position!() to do the lookup in the index.
Alright, I think that's what I want to do.
Could you please direct me to a working example, such as a unit test? Then I can copy that in detail, into my peg application.
from rust-peg.
Related Issues (20)
- warn on missing .PHONY entry for common target names HOT 1
- general question about thread safety HOT 1
- Use tracing rather than println?
- Binding captured strings? HOT 6
- help with misleading expected set HOT 2
- How do I escape the dot character in [^ pat]? HOT 1
- rustc warning about unused imports HOT 1
- Make the TokenStream wrappers used internally available
- How to escape the " HOT 3
- Mutual recursion with `#[cache_left_rec]` fails
- Case-insensitive literal matches throw off error position HOT 6
- `{? Err("x") }` should not be considered nullable for infinite loop check
- the `#[proc_macro]` attribute is only usable with crates of the `proc-macro` crate type HOT 2
- Automatic whitespace handling? HOT 1
- "rule" but not when HOT 2
- Error recovery when using `precedence!` HOT 2
- What about presenting on Rust Ukraine Conference 2024?
- feat: in rule where clauses support
- feat: mut variable syntax support for TaggedExpr and RuleParam HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-peg.