Using song-keys is super fragile. Maybe artist/album/track?

It's not clear why, because it's specified, but the packaged app (at least for macOS) is getting the default app icon instead of the silly custom one. This is also true when using the developer scenario, but that doesn't matter...

I want port it to Arch Linux.
When I build the program,I got an error:

$ electron-builder
  • electron-builder  version=23.6.0 os=6.1.31-1-lts
  • loaded configuration  file=package.json ("build" field)
  • loaded parent configuration  preset=react-cra
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=23.1.4 appOutDir=dist/linux-unpacked
  ⨯ Application entry file "build/electron.js" in the "${HOME}/.cache/paru/clone/EMP-0.8.7/dist/linux-unpacked/resources/app.asar" does not exist. Seems like a wrong configuration.  failedTask=build stackTrace=Error: Application entry file "build/electron.js" in the "${HOME}/.cache/paru/clone/EMP-0.8.7/dist/linux-unpacked/resources/app.asar" does not exist. Seems like a wrong configuration.
    at error (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/asar/asarFileChecker.ts:7:12)
    at Object.checkFileInArchive (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/asar/asarFileChecker.ts:31:11)
    at LinuxPackager.checkFileInPackage (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/platformPackager.ts:503:7)
    at LinuxPackager.sanityCheckPackage (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/platformPackager.ts:551:5)
    at LinuxPackager.doPack (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/platformPackager.ts:312:5)
    at LinuxPackager.pack (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/platformPackager.ts:136:5)
    at Packager.doBuild (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/packager.ts:441:9)
    at Object.executeFinally (/usr/lib/node_modules/electron-builder/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/packager.ts:376:31)
    at Packager.build (/usr/lib/node_modules/electron-builder/node_modules/app-builder-lib/src/packager.ts:337:12)
    at Object.executeFinally (/usr/lib/node_modules/electron-builder/node_modules/builder-util/src/promise.ts:12:14)

When I execute the following command in the package.json:
yarn prep-release && yarn opt-release && electron-builder --publish=always
I got this,and there was no errors:

$ yarn prep-release && yarn opt-release && electron-builder --publish=always
[1]  tsc -p config/tsconfig.render.rel.json exited with code 0
[0] static/main/AudioDatabase.ts(29,56): error TS2307: Cannot find module 'shared' or its corresponding type declarations.
[0] static/main/AudioDatabase.ts(69,13): error TS2339: Property 'forEach' does not exist on type '{}'.
[0] static/main/AudioDatabase.ts(69,24): error TS7031: Binding element 'type' implicitly has an 'any' type.
[0] static/main/AudioDatabase.ts(69,30): error TS7031: Binding element 'value' implicitly has an 'any' type.
[0] static/main/Communication.ts(6,52): error TS2307: Cannot find module 'shared' or its corresponding type declarations.
[0] static/main/Transcoding.ts(16,8): error TS2307: Cannot find module 'shared' or its corresponding type declarations.
[0] static/main/menu.ts(13,42): error TS2307: Cannot find module 'shared' or its corresponding type declarations.
[0]  tsc -p config/tsconfig.static.rel.json exited with code 2
[
  {
    command: Command {
      close: [Subject],
      error: [Subject],
      stdout: [Subject],
      stderr: [Subject],
      timer: [Subject],
      killed: false,
      exited: true,
      index: 1,
      name: '',
      command: ' tsc -p config/tsconfig.render.rel.json',
      prefixColor: '',
      env: {},
      cwd: '',
      killProcess: [Function (anonymous)],
      spawn: [Function (anonymous)],
      spawnOpts: [Object],
      process: undefined,
      pid: 248340,
      stdin: [Socket]
    },
    index: 1,
    exitCode: 0,
    killed: false,
    timings: {
      startDate: 2023-06-02T09:03:37.779Z,
      endDate: 2023-06-02T09:03:38.835Z,
      durationSeconds: 1.056815719
    }
  },
  {
    command: Command {
      close: [Subject],
      error: [Subject],
      stdout: [Subject],
      stderr: [Subject],
      timer: [Subject],
      killed: false,
      exited: true,
      index: 0,
      name: '',
      command: ' tsc -p config/tsconfig.static.rel.json',
      prefixColor: '',
      env: {},
      cwd: '',
      killProcess: [Function (anonymous)],
      spawn: [Function (anonymous)],
      spawnOpts: [Object],
      process: undefined,
      pid: 248339,
      stdin: [Socket]
    },
    index: 0,
    exitCode: 2,
    killed: false,
    timings: {
      startDate: 2023-06-02T09:03:37.776Z,
      endDate: 2023-06-02T09:03:39.261Z,
      durationSeconds: 1.48595283
    }
  }
]

When I execute the emp in dist/linux-unpacked,I got this:

$ ./dist/linux-unpacked/emp 
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Cannot find module '${HOME}/.cache/paru/clone/EMP-0.8.7/dist/linux-unpacked/resources/app.asar/build/electron.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1002:15)
    at n._resolveFilename (node:electron/js2c/browser_init:2:109797)
    at node:electron/js2c/browser_init:2:115663
    at node:electron/js2c/browser_init:2:115906
    at node:electron/js2c/browser_init:2:115910
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:331:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/loaders:269:10)
    at loadBuiltinModule (node:internal/modules/cjs/helpers:50:9)
    at Module._load (node:internal/modules/cjs/loader:862:15)
    at f._load (node:electron/js2c/asar_bundle:2:13330)

Will you please fixing it ? Thank you!

Pick one of:

• Tauri: Probably have to learn Rust. Maybe would be interesting? The url handler didn't like flac audio last time I checked (and they were unwilling to add a "trust me" bit because Rustaceans want to live at the forefront of the security arms race, I guess...)
• Neutralino: I'd probably just fork the project, because their build system is a fluster-cluck, and writing C++ doesn't scare me in the least (I've already got a CMake fork working...)
• WebView: This is super bare-bones (even lighter than Neutralino). But Neutralino also has a less-than-stellar programming model, so maybe this would be a better starting point. The build is bad (build.sh: wtf, programming people?) and I'd probably have to figure out packaging...
• Fork and strip Electron: This is daunting, but much of the cruft (outside the packaging size) is related to security stuff that I don't care about for something that isn't hostly arbitrary web content. I suspect the other efforts in this space would be faster to complete...

Images seem to scale to width, but the height should be fixed as well. Honestly, just make it a fixed square and call it good.

M3U's seem trivially easy. I should import & export them...

It appears to be always set to 1.0, even when it's not. As soon as you touch the volume slider, it's fixed. Feels like a silly startup problem.

Make playlists expandable & editable inline, instead of requiring that they're Now Playing to edit them.

For songs/albums I just never want to hear. Could make a full on view filter for it :)

The issues is most easily observable by seeing that the scrollbar is screwed up when the list continues off the end of the scree.

Just song controls and nothing else. Probably make it stay on top, too.

Excellent quality player I listen and on windows and rejoice the bass is dense and without distortion and excellent stereo panorama and volume thank you friend

Probably not the default, but it would be pretty cool to edit metadata in-file.

This is basically me being annoyed that I have 12 copies of the same recording of "Smells Like Teen Spirit". If they're the same recording of the same song, I'd like to have some little turd file that indicates that, instead of copying the file around. Something like 'Compilations/VA - 1996 - Eighties Stuff/03 - 80's Band - This File.emp' should contain some json like this:

{
  "original": "../80's Band - 1985 - First Release/05 - This File.flac"
}

with maybe the ability to override stuff in metadata shoved in there for good measure (Album Art might be different, right?)

When adding locations, have a "move to" location and allow songs to be copied/moved to the "storage" location (and organized properly) as an option.

To get stuff to my iPhone (or anywhere else) I need to transcode stuff down to a target bit rate & format. This seems super easy, given that 95% of the code is already in @freik/media-utils

It sure would be nice for newly added music to be easy to discover...

This is just a perf hit. The electron IPC mechanism should just handle everything transparently. Eradiate FTON as much as possible (still needs to live in Persist, but hopefully nowhere else)

Stick a link to the repo in there.

This probably needs to be in the audio database. Currently, if you create a .notranscode file in a directory, it's ignored for 'entire directory' transcoding. It would be nice to a) not have to leave those turd files around, and b) have the same set of things ignored for the music database as for transcoding

I'd like to sort the album list by artist, and also have album sublists in the artist view.

Things should be using relative paths: don't use this thing any more

It shouldn't do that by default. Make it an option or something, maybe? It's annoying.

If you quit EMP while it's on an 'external' screen, then relaunch it when that screen disconnected, it appears to restore to the original (off-screen) location, at least in Windows.

All the views leave quite a bit to be desired. Add some new ones.

Search seems to behave weird after first interaction. (Try searching for "Disc") and see what happens with my default collection-o-stuff)

Instead of needing to rescan, add the ability to have an .emp hidden folder that contains the relevant data. The trouble is that the data might be getting read from & written to by multiple client apps at the same time.
Stuff to put in this location:

• MusicDB
• Playlists
• Image Cache
• Metadata Overrides

Clicking the 'emp Help' menu should go to the wiki, but the thing never launches the click handler :/

Being able to use |, &, !, AND, OR, and NOT would be pretty awesome. Grouping with parentheses maybe, too.

It would be nice to add a 'thumbs down & skip' options. Maybe 'hold a button down when skipping' feature?

This is a pretty big work item, but supporting incremental modification to the music database would be a pretty huge improvement to usability when doing metadata editing

I don't know if it's trying and failing to pull it out of the flac files, but if it's not, it's ignoring the data on the Song objects. Check out index.js and the SongContainer.js for details.

It would be awesome to show files where the filename & the metadata don't match. Some sort of clean-up mode would be incredibly useful.

When you select a group of files, the disk #, even if it's common, doesn't get set to anything.

It's blocked by this issue.

For now, the registerFileHandler continues to be the functional way to deal with seekable audio...

Bjork, Sinead O'Connor, The Blue Oyster Cult all seem to have odd problems between mac & PC as well as from two different machines when the AFI is synchronized. It seems like it can't find the album art, in particular.

Probably a z ordering issue...

This is sort of an 'enhancement' and sort of a 'platform compatibility' bug, but if the file name for cover art starts with a dot, the files should be flagged at hidden for file systems that support it.

Unless focus is in the search bar, typing in a sorted list should scroll to an element. I started this, but it cause weird behavior with FluentUI right-click context menus.

Looks like communication between main and ui process for menus is broken

Allow playlist descriptions involving artists, albums, years, keywords, etc...

Not sure why. Should go fix.

And maybe change the shuffle model so it doesn't mess it up afterward.

Which means living in the .afi is pointless...

Make a playlist with a song, move the song on disk, then try to play the song. Oops.