Comments (6)
When you have parameters Jenkins expects you to POST at the build endpoint with data (your parameters). Currently we POST with no data and Jenkins rejects this with a 400.
The API exposes this - the "properties" array is nonempty for parameterized builds.
Maybe we should fetch data from Jenkins once when the page loads and set variables in the environment.
This will require a bit of work to refactor the existing code, I imagine.
from doony.
Yes, that is my understanding as well. How would you 'set variables in the environment' ? Cookies?
from doony.
No, just javascript
var isParameterized = false;
Kevin Burke | 415-723-4116 | www.twilio.com
On Wed, Oct 2, 2013 at 10:49 AM, Rushi Vishavadia
[email protected]:
Yes, that is my understanding as well. How would you 'set variables in the
environment' ? Cookies?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-25560640
.
from doony.
I'd still show the button, it would just go to the builds page instead of
to the console output, or failing
Kevin Burke | 415-723-4116 | www.twilio.com
On Wed, Oct 2, 2013 at 10:56 AM, Rushi Vishavadia
[email protected]:
Only problem is then you have to wait till the JSON call is completed
before deciding to show the build now button. It looks odd for a button to
just appear next to the h1 after the page loads.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-25561325
.
from doony.
Yep, I realized that, so deleted my post. I had confused myself with
another issue when I wrote that.
On Wed, Oct 2, 2013 at 11:27 PM, Kevin Burke [email protected]:
I'd still show the button, it would just go to the builds page instead of
to the console output, or failing
Kevin Burke | 415-723-4116 | www.twilio.com
On Wed, Oct 2, 2013 at 10:56 AM, Rushi Vishavadia
[email protected]:Only problem is then you have to wait till the JSON call is completed
before deciding to show the build now button. It looks odd for a button
to
just appear next to the h1 after the page loads.—
Reply to this email directly or view it on GitHub<
https://github.com/kevinburke/doony/issues/5#issuecomment-25561325>
.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-25561438
.
from doony.
I'd still show the button, it would just go to the builds page instead of to the console output, or failing.
FYI, #53 takes care of this.
from doony.
Related Issues (20)
- http://doony.org & https://jenkins.doony.org/ show an insecure malicious URL HOT 1
- Doony is attempting to change wrong header bar class/logo field HOT 3
- Doony "build now" button misbehaving (wrong permission?) HOT 8
- doony 2 layout error(s) in IE9 HOT 4
- Chrome extension unfortunately only works on the home page HOT 2
- [FEATURE] Keyboard shortcuts HOT 3
- Update HOT 6
- Doony hides last build from history HOT 2
- doony.min.css rebuild HOT 1
- Demo site down HOT 4
- The "Build Now" button not works with CloudBees Folders Plugin HOT 2
- make this part of jenkins core
- Looking for someone to host an example site HOT 1
- ReferenceError: jQuery is not defined doony.min.js (Zeile 2, Spalte 4539) HOT 1
- path to fix "build now" problems HOT 3
- fixing "build now" misbehaving
- responsive
- Doony (the pet) is being put to sleep HOT 1
- UI is a little off with Jenkins 2.73.3 HOT 1
- Question about the "Custom Color" feature HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doony.