Comments (3)
sounds good! Want to submit a PR
On Wednesday, January 20, 2016, Max Kovgan [email protected] wrote:
NOTE: this is 1 of 2 issues causing these bugs #86
#86 and #73
#73A regex used in several isJob_() methods does: return
path.match(/^/job/.?//) !== null;, or similar.
This regex assumes the value of window.location.pathname on a job page
would always start with /job. This is untrue for various setups, esp.
when jenkins is behind a reverse proxy of nginx/apachehttpd/etc., so the
value of window.location.pathname can be /ci/job, or even nested:
/apps/ci/job. failing to detect we're on a job page results in missing
"Build Now" button.
I'm suggesting this regex: return path.match(/^/(./)?job/._?//), it
allows the above paths, but probably could use some finer-tuning.—
Reply to this email directly or view it on GitHub
#91.
Kevin Burke
925.271.7005 | kev.inburke.com
from doony.
The compile process for this project is kind of a nightmare just make the
change and I can do the rest
On Wednesday, January 20, 2016, Kevin Burke [email protected] wrote:
sounds good! Want to submit a PR
On Wednesday, January 20, 2016, Max Kovgan <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:NOTE: this is 1 of 2 issues causing these bugs #86
#86 and #73
#73A regex used in several isJob_() methods does: return
path.match(/^/job/.?//) !== null;, or similar.
This regex assumes the value of window.location.pathname on a job page
would always start with /job. This is untrue for various setups, esp.
when jenkins is behind a reverse proxy of nginx/apachehttpd/etc., so the
value of window.location.pathname can be /ci/job, or even nested:
/apps/ci/job. failing to detect we're on a job page results in missing
"Build Now" button.
I'm suggesting this regex: return path.match(/^/(./)?job/._?//), it
allows the above paths, but probably could use some finer-tuning.—
Reply to this email directly or view it on GitHub
#91.Kevin Burke
925.271.7005 | kev.inburke.com
Kevin Burke
925.271.7005 | kev.inburke.com
from doony.
@kevinburke I think I can run make,
Actually this patch should be added after the 2nd one, b/c until the 2nd one is constructing good request - this one will expose the button which doesn't work.
from doony.
Related Issues (20)
- http://doony.org & https://jenkins.doony.org/ show an insecure malicious URL HOT 1
- Doony is attempting to change wrong header bar class/logo field HOT 3
- Doony "build now" button misbehaving (wrong permission?) HOT 8
- doony 2 layout error(s) in IE9 HOT 4
- Chrome extension unfortunately only works on the home page HOT 2
- [FEATURE] Keyboard shortcuts HOT 3
- Update HOT 6
- Doony hides last build from history HOT 2
- doony.min.css rebuild HOT 1
- Demo site down HOT 4
- The "Build Now" button not works with CloudBees Folders Plugin HOT 2
- make this part of jenkins core
- Looking for someone to host an example site HOT 1
- ReferenceError: jQuery is not defined doony.min.js (Zeile 2, Spalte 4539) HOT 1
- fixing "build now" misbehaving
- responsive
- Doony (the pet) is being put to sleep HOT 1
- UI is a little off with Jenkins 2.73.3 HOT 1
- Question about the "Custom Color" feature HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doony.