Code Monkey home page Code Monkey logo

space-tourism's Introduction

Space Tourism: A collaboration between Frontend Mentor, Scrimba, and Kevin Powell

This project is a collaboration between Frontend Mentor, Scrimba, and Kevin Powell.

The project was created by Frontend Mentor, with the course being taught by Kevin, and hosted on the interactive platform Scrimba.

space-tourism's People

Contributors

kevin-powell avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

funmi-amusan abstrarthur rasha2019 samiullah1526 sagarmaria ramsey1120 internetsanity femakin dodedom adridwk innocent9712 bavomeister futuresarcade fcr25 richard-chimama ramziosta kabeer-prog trinkel amykarnaze gonelr evansnyawira andriiinovikov bogadeji danimillington alfettox peter-omoyele sayyidradhin rjessick borislavkb olulanke-mainasara cfleenor gzbotii uiftikhar a1ip el-squaz pterameta ky2k gschecho imanojkumar souravdasdip fzcj seyhoover breinstew hs745 villion-wong tiburcekouagou blaqmac kvyu168 mister-ed sinaloid rafliogun49 moorthi07 holutahyour aushateam joetamatthews jesusrl96 ashen16 vineetp6 chris-fo chipohameja nana-prempeh ppilla1 spardano mtranche namcoding10122001 chyna07 rj375 vsagarreddy vicxny jkimkim msrobynm edsonv goke-adekanye hblack25 nikoz84 lu-lucifer ravinaparve emilsultanov sergiogval vishann tiendung690 achionye jirosworld bit0071 framsamm ithanlevin vijen12000 jiribeck rhenaldkarrel joy21fs dristanta-silwal macmullensantiago robmel12 iandev096 soumo16 chuluuu faeezs abdelkarim-ad noelsebastian22 nazrinhajiyeva

space-tourism's Issues

Lesson 53 hidden attribute

hidden attribute not working because it seems picture 'Reset' overrides it

in your index.css there is a typo at row 102

img,
picutre {

hover not working on chrome

Hello Kevin! thanks for the course.
issue i found that on Chrome; Version 95.0.4638.54 (Official Build) (64-bit)
.dot-indicators>:hover or .underline-indicators>:hover not working (chrome does not detect it), and focus only works on tab-list and not on primary-navigation

I tried based on the videos and also downloaded the version from here

"aria-expanded" attribute on the "button" element, but not on the "span" element

What for do we need set a new aria-expanded attribute on the button element? Because in index.js we get exactly the button, not the inner span.

space-tourism/lesson-files/36/02-end/index.js

Lines 2 to 9 in 558f56b

const navToggle = document.querySelector(".mobile-nav-toggle");
navToggle.addEventListener("click", () => {
const visiblity = nav.getAttribute("data-visible");
if (visiblity === "false") {
nav.setAttribute("data-visible", true);
navToggle.setAttribute("aria-expanded", true);

Before click on the button:

image

After click on the button:

image
image

doctype missing on design-system.html

The HTML doctype is missing in design-system.html and index.html (in probably all lesson files). This caused the following CSS to not work:

.underline-indicators > *:hover

.dot-indicators > *:hover

When a doctype is added, the above CSS begins working again. Interestingly, the > *:focus declarations worked fine without a doctype.

I had never realized a missing doctype would have such random issues with CSS declarations, but apparently it does.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.