kenziemac130 / citrustoolbox Goto Github PK
View Code? Open in Web Editor NEWHobby Game Engine
License: Apache License 2.0
Hobby Game Engine
License: Apache License 2.0
Line 94 in df1118f
Go through all files and check for functions that can be made const correct.
It might be better to move the modules and engine to variables of the engine/application. This way the engine could be allocated entirely on the BSS if the application is on the BSS. This would cut down on pointer indirection. The application indirection from the engine would still need to be a pointer back to the owning object (or possibly a reference if that isn't annoying).
On ctrl/shift/alt this happens. Assertion failed: (key_mod_flags == 0 || g.IO.KeyMods == key_mod_flags) && "Mismatching io.KeyCtrl/io.KeyShift/io.KeyAlt/io.KeySuper vs io.KeyMods", file C:\Users\Kenzie\Documents\GitHub\CitrusToolbox\thirdparty\imgui\imgui.cpp, line 7165
[ERROR] VK Validation Layer: [Validation] Code 0 : Validation Error: [ VUID-vkCmdPipelineBarrier-dependencyFlags-01186 ] Object 0: handle = 0x17ca8557e20, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0x97273504 | vkCmdPipelineBarrier(): .dependencyFlags VK_DEPENDENCY_VIEW_LOCAL_BIT must not be set outside of a render pass instance The Vulkan spec states: If fname:vkCmdPipelineBarrier is called outside of a render pass instance, VK_DEPENDENCY_VIEW_LOCAL_BIT must not be included in the dependency flags (https://vulkan.lunarg.com/doc/view/1.2.176.1/windows/1.2-extensions/vkspec.html#VUID-vkCmdPipelineBarrier-dependencyFlags-01186)
Finish design document
The following need attention
Here is where you can leave general feedback not related to any particular bug or issue.
Hello,
as arranged on twitter I took the liberty to test out a fresh build of the project.
Some initial points I encountered:
.\tools\CMakeLists.txt
contains an add_subdirectory(gltf2citrus)
statement, only that the directory doesn't exist. Removing this line from the file fixes this.tracy
git submodule needed to be cloned manually (resp. git submodule init; git submodule update
). This could probably have been documented in the guide, by stating "Clone the project [...] using git clone --recurse-submodules <target>
".CitrusToolbox/engine/renderer/vulkan/VkBackend.cpp
Lines 379 to 381 in 09a2151
vAllocFunction
(and the next two assignments) cannot be converted to PFN_vkAllocationFunction
. I was able to fix this by explicitly casting the function to that typedef, i.e. vkAllocCallback.pfnAllocation = (PFN_vkAllocationFunction) vkAllocFunction
. (I can give you details of my setup, if you can guide me through what you would need.x64
but required for x86
which was completely missing.As these are several smaller/trivially fixable issues, I refrained from posting this in the general feedback issue. Additionally, if you need me to re-formulate a point and/or provide details, let me know.
:)
Note to self: double check code you get online
CitrusToolbox/engine/utilities/Math.hpp
Line 240 in 68cfb2c
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.