Code Monkey home page Code Monkey logo

Comments (7)

kentcdodds avatar kentcdodds commented on July 21, 2024

Hi @KubaJastrz,

Thanks for your work! Maybe we should set the runtimeHelpers to whether they have a dependency on @babel/runtime. That seems more logical.

We have a utility for that.

Want to make a PR?

from kcd-scripts.

KubaJastrz avatar KubaJastrz commented on July 21, 2024

Sure, I can take a look.

What about file extensions? Should we just include them always?

from kcd-scripts.

kentcdodds avatar kentcdodds commented on July 21, 2024

Yeah, I think that's the simplest and doesn't really have a negative impact.

from kcd-scripts.

KubaJastrz avatar KubaJastrz commented on July 21, 2024

Okay, so the only step for the developer would be to create a custom babel.config.js with presets: ['kcd-scripts/babel', '@babel/preset-typescript'] but we can add that to the docs I think.

from kcd-scripts.

kentcdodds avatar kentcdodds commented on July 21, 2024

Yeah, I think that's it. Though we might be able to add that preset automatically if we detect a tsconfig.json. I can't think of a downside to that, so why don't we do that too, so then it works seamlessly :)

from kcd-scripts.

KubaJastrz avatar KubaJastrz commented on July 21, 2024

True, I've actually implemented that as well but basing on typescript dependency. Will submit a PR once I verify it works correctly.

from kcd-scripts.

kentcdodds avatar kentcdodds commented on July 21, 2024

🎉 This issue has been resolved in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from kcd-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.