[pre-commit]: test step hangs due to --watch about kcd-scripts HOT 2 CLOSED

Root cause seems to be dash character (-) used in environment variable naming. After googling this it seems bash does not support dashes in variable names.

$ env | grep -i shell
SHELL=/bin/bash

// index.js
const spawn = require('cross-spawn');

spawn.sync("node", ["echo-environment.js"], {
  stdio: "inherit",
  shell: true,
  env: { first: true, ["SCRIPTS_PRE-COMMIT"]: true },
});

spawn.sync("node", ["echo-environment.js"], {
  stdio: "inherit",
  shell: true,
  env: { second: true, ["SCRIPTS_PRE_COMMIT"]: true },
});

// echo-environment.js
console.log('Echo environment', process.env);

$ node index.js 

Echo environment { first: 'true', PWD: '/<removed-path>' }
Echo environment { second: 'true', SCRIPTS_PRE_COMMIT: 'true', PWD: '/<removed-path> }

I'm not sure why but even by adding shell: false option here the issue persists:

While cross-spawn tries to minimize all these incompatibility issues I don't think it can handle this. I would suggest to rename SCRIPTS_PRE-COMMIT to SCRIPTS_PRE_COMMIT.

I can setup PR if this solution sounds OK.

from kcd-scripts.

Yep, that sounds good to me! Thanks for investigating the issue.

from kcd-scripts.