Endless chain of unfound plugins for ESLint about kcd-scripts HOT 10 CLOSED

from kcd-scripts.

Hi @v1adko! I'm happy you're giving kcd-scripts a try :)

I'm pretty sure kcd-scripts does not need stuff like cssnano to run.

You're correct. I'm not sure why it's trying to read that. My guess is that it's trying to lint files in node_modules. Could you try kcd-scripts lint --debug? The --debug flag will be forwarded to eslint and it'll show you what files it's trying to lint. If it is trying to lint those files, could you look into what it's using for the eslint ignore?

Actually, now that I think of it I remembered there's an existing issue! eslint/eslint#9227

To solve this problem, I've always added an eslintIgnore property to my package.json. I'm hoping that we can solve this issue in ESLint eventually. Maybe I'll take some time to work on that because paypal-scripts will need this fixed as well. But feel free to work on that yourself!

I'm going to go ahead and close this as it's not actionable in this project but will be solved by eslint.

from kcd-scripts.

Thank you, adding eslintIgnore did help (.eslintignore worked too), even though it did require unfound eslint-plugin-babel and eslint-plugin-jest, but thankfully stopped at those two :)

Is it possible to encapsulate those within kcd-scripts too?

Also would be nice if we could pass something like --ignore-path to use .gitignore and not duplicate the ignore paths.
Or extra configuration will increase the complexity of this toolbox and it's better to manage without it?

from kcd-scripts.

Those should definitely be encapsulated within kcd-scripts. I've not had trouble with them. What version of npm are you using?

from kcd-scripts.

I use yarn 1.1.0

from kcd-scripts.

Also would be nice if we could pass something like --ignore-path to use .gitignore and not duplicate the ignore paths.

You can 😉

from kcd-scripts.

I don't use yarn, so I don't plan on supporting that in kcd-scripts. But I'm happy to accept a pull request if it doesn't complicate the codebase too much.

from kcd-scripts.

Of course I can :) Thanks.
OK, I'll try to figure it out.

Interestingly after dropping node_modules and yarn.lock and installing again issue persists.
And funny enough, installing kcd-scripts as a dependency and not a dev dependency it requires only eslint-plugin-jest.

from kcd-scripts.

Well that's totally weird. Sounds like it could be an issue with combining react-scripts and kcd-scripts. Though I haven't had this problem in this project 🤔

from kcd-scripts.

Try yarn why babel-plugin-jest and npm ls babel-plugin-jest. That'll tell you what packages require those packages...

from kcd-scripts.