kenkouot / hapi-i18next Goto Github PK

Thank you so much for writing this plugin.

There are 2 issues with t.js though or I might understand it wrong:

Shouldn't

else if (options.hasOwnProperty(key)) {

be

else if (options.hash.hasOwnProperty(key)) {

as otherwise params will always be emtpy as no hash values are passed?

Also,

params[key] = String(options.hash[key]);

should be

params[key] = options.hash[key];

as otherwise all values are strings and as such i18next helpers that depend on numbers such as "_plural" are not supported anymore?

Mike

Hi,
I'm trying to figure out if there is a way to use this plugin for Hapi with locize backend?
As far as I understand I need to call i18n.use(Locize) somewhere. Not sure if it's possible to call after init call has been made by this plugin?

The Typescript dependency should be listed in devDependencies, not dependencies.

Hi,

Thanks for publishing this module.

As it stands, it is useful for basic layouts. However, the way the helper is written depends on context injection, but Hapi exposes stuff only in the root context… the first time you have a template inclusion ({{> subtemplate}}), this is redefined and i18n is not accessible anymore.
The only work around I see is to always pass it around when including sub templates, but that's pretty cumbersome.

If you see a better workaround, it would be most welcome. Otherwise, a note in the documentation would be good too, to avoid wasting time if you depend on template inclusion.