Code Monkey home page Code Monkey logo

ember-macro-helpers's Introduction

ember-macro-helpers

npm version Build Status

Ember macro helpers for making your own fancy macros!

Check out the following projects to see this addon in use:

Compatibility

  • Ember.js v3.8 or above
  • Ember CLI v2.13 or above
  • Node.js v8 or above

Installation

ember install ember-macro-helpers

Usage

import nameOfMacro from 'ember-macro-helpers/name-of-macro';
// or
import { nameOfMacro } from 'ember-macro-helpers';

Contents

API

computed

computed behaves like Ember.computed with some extra benefits.

It will pass you resolved values:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';

export default Component.extend({
  key: 'my value',

  result: computed('key', {
    get(value) {
      console.log(value); // 'my value'
      // do something else
    },
    set(newValue, value) {
      console.log(newValue); // 'new value'
      console.log(value); // 'my value'
      return newValue;
    }
  }),

  actions: {
    doSomething() {
      this.set('result', 'new value');
    }
  }
});

You can compose using any of Ember's built-in macros:

import Component from '@ember/component';
import { or } from '@ember/object/computed';
import computed from 'ember-macro-helpers/computed';

export default Component.extend({
  key1: false,
  key2: true,

  result: computed(or('key1', 'key2'), value => {
    console.log(value); // true
    // do something else
  })
});

or you can compose using a macro library like ember-awesome-macros:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';
import { conditional, gt, sum, difference } from 'ember-awesome-macros';

export default Component.extend({
  key1: 345678,
  key2: 785572,

  result: computed(conditional(gt('key1', 'key2'), sum('key1', 'key2'), difference('key1', 'key2')), value => {
    console.log(value); // -439894
    // do something else
  })
});

It respects enumerable helpers:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';

export default Component.extend({
  key1: [{ key2: 1 }, { key2: 2 }],

  computed1: computed('key1.[]', value => {
    console.log(value); // [{ key2: 1 }, { key2: 2 }]
    // do something else
  }),
  computed2: computed('[email protected]', value => {
    console.log(value); // [{ key2: 1 }, { key2: 2 }]
    // do something else
  }),
});

It resolves property expansion for you:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';

export default Component.extend({
  key1: { key2: 1, key3: 2 },

  result: computed('key1.{key2,key3}', (value1, value2) => {
    console.log(value1); // 1
    console.log(value2); // 2
    // do something else
  })
});

This is also your best friend if you want to make your own macros that support composing out-of-the-box.

For example, here is an implementation of a macro that adds two numbers together:

// app/macros/add.js
import computed from 'ember-macro-helpers/computed';

export default function(key1, key2) {
  // The incoming keys can be key strings, raw values, or other macros.
  // It makes no difference to you.
  // `computed` will resolve them for you.
  return computed(key1, key2, (value1, value2) => {
    // At this point, the keys no long matter.
    // You are provided the resolved values for you to perform your operation.
    return value1 + value2;
  });
}

Then you can use it like this:

import Component from '@ember/component';
import add from 'my-app/macros/add';

export default Component.extend({
  key1: 12,
  key2: 34,
  key3: 56,

  result: add(add('key1', 'key2'), add('key3', 78)) // 180
});
createClassComputed

This creates a class-based computed. This is useful when not the value, but the key being watched is variable. It rewrites your computed property when needed.

See ember-classy-computed for the inspiration source.

If you want an array macro that will respond when someone changes the array property they want to watch:

// app/macros/filter-by.js
import createClassComputed from 'ember-macro-helpers/create-class-computed';
import computed from 'ember-macro-helpers/computed';

export default createClassComputed(
  // the first param is the observer list
  // it refers to incoming keys
  // the bool is whether a value change should recreate the macro
  [
    // the array key
    false,

    // the array property is dynamic, and is responsible for the macro being rewritten
    true,

    // any static properties after the last dynamic property are optional
    // you could leave this off if you want
    false
  ],
  // the second param is the callback function where you create your computed property
  // it is passed in the values of the properties you marked true above
  (array, key, value) => {
    // when `key` changes, we need to watch a new property on the array
    // since our computed property is now invalid, we need to create a new one
    return computed(`${array}.@each.${key}`, value, (array, value) => {
      return array.filterBy(key, value);
    });
  }
);

And then we consume this macro like normal:

import Component from '@ember/component';
import { A as emberA } from '@ember/array';
import EmberObject from '@ember/object';
import filterBy from 'my-app/macros/filter-by';

export default Component.extend({
  myArray: emberA([
    EmberObject.create({ myProp: 0 }),
    EmberObject.create({ myProp: 1 })
  ]),

  // this could change at any time and our macro would pick it up
  myKey: 'myProp',

  result: filterBy('myArray', 'myKey', 1)
});
curriedComputed

This is a shorthand version of computed. It allows you to create macros like this:

// app/macros/add.js
import curriedComputed from 'ember-macro-helpers/curried-computed';

export default curriedComputed(function(value1, value2) {
  // At this point, the keys no long matter.
  // You are provided the resolved values for you to perform your operation.
  return value1 + value2;
});
lazyComputed

This is the lazy resolving version of computed. The difference is instead of being provided the resolved values, you are provided the unresolved keys and a resolving function. This is useful if you want to optimize your macros and have early returns without calculating every key eagerly.

The API differs only slightly from computed:

// app/macros/and.js
import lazyComputed from 'ember-macro-helpers/lazy-computed';

export default function(key1, key2) {
  return lazyComputed(key1, key2, (get, key1, key2) => {
    // Where normally you get the values, now you have to calculate yourself.
    // The second key won't calculate if the first resolved value is falsy.
    return get(key1) && get(key2);
  });
}
lazyCurriedComputed

This is the combination of lazyComputed and curriedComputed.

literal

alias for raw

raw

This allows you to escape string literals to be used in macros.

Normally, a string means it will look up the property on the object context:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';

export default Component.extend({
  key: 'value',

  result: computed('key', value => {
    console.log(value); // 'value'
    // do something else
  })
});

But if you just want to use the value without making an object property, you can use the raw macro:

import Component from '@ember/component';
import computed from 'ember-macro-helpers/computed';
import raw from 'ember-macro-helpers/raw';

export default Component.extend({
  key: 'value',

  // Even though we are using a string that is the same name as a property on the object,
  // the `raw` macro will ignore the object property and treat the string as a literal.
  result: computed(raw('key'), value => {
    console.log(value); // 'key'
    // do something else
  })
});

The usefulness is more apparent when using complex macros, for example, when using the string split macro from ember-awesome-macros:

import Component from '@ember/component';
import raw from 'ember-macro-helpers/raw';
import split from 'ember-awesome-macros/array/split';

export default Component.extend({
  key: '1, 2, 3',

  result: split('key', raw(', ')) // [1, 2, 3]
});
reads

alias for writable

writable

This is a setting API for read-only macros.

Given the following read-only macro called sum:

import computed from 'ember-macro-helpers/computed';

export default function(key1, key2) {
  return computed(key1, key2, (value1, value2) => {
    return value1 + value2;
  }).readOnly();
}

and its usage:

key1: 1,
key2: 2,
result: sum('key1', 'key2')

If you try and set result, you will get a read-only exception.

If you want to bring back the setting functionality, you can wrap it in the writable macro:

key1: 1,
key2: 2,
result: writable(sum('key1', 'key2'))

Now, setting result will remove the macro and replace it with your value.

If you want to do something unique when setting, you can provide a set callback:

key1: 1,
key2: 2,
result: writable(sum('key1', 'key2'), {
  set() {
    // do something
    return 'new value';
  }
}), // setting this will not overwrite your macro

or:

key1: 1,
key2: 2,
result: writable(sum('key1', 'key2'), function() {
  // do something
  return 'new value';
}) // same as above, but shorthand

Setting result here will not remove your macro, but will update result with the return value.

Custom macros

The addon provides a way of creating your own custom macros. The easiest way is to use the blueprint generator:

ember generate macro my-custom-macro

This will generate an example macro and its associated test. The comments in these files will get you started.

More explanation is given in the introduction video.

Test helpers

This comes with a compute helper. Here is a sample usage:

import myMacro from 'my-app/macros/my-macro';
import compute from 'ember-macro-helpers/test-support';

// ...

test('it works', function(assert) {
  compute({
    assert,
    computed: myMacro('key1', 'key2'),
    properties: {
      key1: 1,
      key2: 2
    },
    strictEqual: 3
  });
});

View all the possible ways to use here.

Contributing

See the Contributing guide for details.

License

This project is licensed under the MIT License.

ember-macro-helpers's People

Contributors

clekstro avatar dubistkomisch avatar ember-tomster avatar esbanarango avatar greenkeeper[bot] avatar lolmaus avatar mriska avatar mwpastore avatar oskarrough avatar renovate-bot avatar shamcode avatar spieker avatar turbo87 avatar yoranbrondsema avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

ember-macro-helpers's Issues

An in-range update of ember-cli-qunit is breaking the build 🚨

Version 4.1.0 of ember-cli-qunit was just published.

Branch Build failing 🚨
Dependency ember-cli-qunit
Current Version 4.0.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-qunit is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 20 commits ahead by 20, behind by 2.

There are 20 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Consider exporting a collected object

In the same way that we can use:

import nameOfMacro from 'ember-awesome-macros/name-of-macro';
// or
import { nameOfMacro } from 'ember-awesome-macros';

in ember-awesome-macros, do you think it would be possible to support:

import { raw } from 'ember-macro-helpers'

in ember-macro-helpers?

Lazy Computed with get/set

I'm trying to make a computed that will accept 2 values - a property, and a defaultProperty. When you get the computed, if property is not null/undefined, it will return the property - otherwise defaultProperty. However I also want to allow set on this computed, if set it will set the property to the set value.

alarmState: defaultGet('reportConfig.alarm_state', raw([1,2,3]) ),
something2: defaultGet('reportConfig.show_state','showState'),
something3: defaultGet(conditional('something2','something2','alarmState'), raw('abc') ) // Allowing this would be nice too, but not required

So far I have

export default function(property, defaultProperty) {
  return lazyComputed(property, defaultProperty, {
    get(get, property, defaultProperty) {
      return isNone(get(property)) ? get(defaultProperty) : get(property);
    },
    set(newValue, get, property, defaultProperty) {
    // ???
    }
  });
}

I think I've done the get correctly (??) but I am a bit confused as to what to do in the set, can anyone help me out? Is what I'm trying to do even possible?

I've tried looking at examples at ember-awesome-macros and in this project, but none seem to do what I'm trying to do.

Thanks.

An in-range update of ember-cli-babel is breaking the build 🚨

Version 6.9.0 of ember-cli-babel was just published.

Branch Build failing 🚨
Dependency ember-cli-babel
Current Version 6.8.2
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-babel is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 9 commits.

  • bf50699 v6.9.0
  • c933081 Add v6.9.0 to CHANGELOG.md.
  • f579f1b Merge pull request #176 from locks/ember-string-skip
  • fde084c Blacklists @ember/string modules if package is present
  • f354bf4 Merge pull request #186 from alvincrespo/patch-1
  • 7b08fdb Updates link to the Babel mono-repo
  • 88145d7 Merge pull request #185 from Turbo87/changelog
  • c2ef71a Add CHANGELOG file
  • 0de753c Add "lerna-changelog" dev dependency

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Readme documentation for `createClassComputed` seems to be erroneous

Hey.

Tried to understand the usage example of createClassComputed in the readme and it made no sense to me.

Actual usage example does make sense and is different from the readme:

  1. The second-argument-callback receives all arguments and not only the ones marked as true like readme claims.
  2. The CP returned from the callback uses dynamic values as dependencies while readme uses hardcoded strings "array" and "value".

Not sending a PR because I'm not fully confident in my understanding of createClassComputed.

[Question] Update to work against ember 3.28+ ?

Hello,

I'm working with @NullVoxPopuli on updating ember-moment. It turns out the test suite doesn't pass because of this addon not beeing compatible with ember >3.28. The question is, since I believe (maybe I'm wrong) we want to move away from computed properties, do you want to make it compatible with ember 3.28+, or deprecate it ?
For information, this addon is erroring when we want to compose macros.
For example, this test, https://github.com/kellyselden/ember-macro-helpers/blob/master/tests/acceptance/monkey-patch-test.js
Capture d’écran 2021-09-07 aΜ€ 09 10 01

An in-range update of ember-cli-eslint is breaking the build 🚨

Version 4.2.2 of ember-cli-eslint was just published.

Branch Build failing 🚨
Dependency ember-cli-eslint
Current Version 4.2.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v4.2.2
  • Fix file deletion bug. (#222)
Commits

The new version differs by 12 commits.

  • d48ff17 v4.2.2
  • 11c7571 Update CHANGELOG
  • 229265b Merge pull request #222 from Turbo87/update-broc-plugin
  • 7fd34f6 Update broccoli-lint-eslint to v4.2.1
  • 48413a6 Merge pull request #221 from Turbo87/update-yarn
  • 6c2e798 Update "ember-cli-qunit" to v4.0.1
  • 31f7c93 Update "ember-cli-babel" to v6.8.2
  • 5fd1993 Update "yarn.lock" file
  • 66f8291 Merge pull request #217 from ember-cli/greenkeeper/ember-cli-2.16.0
  • ff63649 Merge pull request #216 from ember-cli/greenkeeper/ember-source-2.16.0
  • 7341c12 chore(package): update ember-cli to version 2.16.0
  • 2ee36e8 chore(package): update ember-source to version 2.16.0

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of ember-weakmap is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 3.2.0 of ember-weakmap was just published.

Branch Build failing 🚨
Dependency ember-weakmap
Current Version 3.1.1
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-weakmap is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 6 commits.

  • 8a381a1 Version bump to 3.2.0
  • 9af08a5 Merge pull request #25 from thoov/3.0.0-upgrade
  • dd478ad [IMPR] Upgrade to 3.0 and add OVERRIDE_WEAKMAP
  • 96fe300 Merge pull request #23 from thoov/2.17.upgrade
  • 1c2b6c9 Adding back package.json contents
  • 7fdf55d Upgrading to 2.17

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of mocha is breaking the build 🚨

Version 4.0.1 of mocha was just published.

Branch Build failing 🚨
Dependency mocha
Current Version 4.0.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes v4.0.1

4.0.1 / 2017-10-05

πŸ› Fixes

Commits

The new version differs by 6 commits.

  • eb8bf8d Release v4.0.1
  • 3b485ea update CHANGELOG.md for v4.0.1 [ci skip]
  • 96e5c1a upgrade eslint to v4.8.0
  • d7cff37 Update growl to 1.10.3
  • 0cdd921 remove preversion script; test on publish; closes #2999
  • f49c0ce Fix changelog issues/pr URLs (#3047)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of mocha is breaking the build 🚨

Version 4.1.0 of mocha was just published.

Branch Build failing 🚨
Dependency mocha
Current Version 4.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v4.1.0

4.1.0 / 2017-12-28

This is mainly a "housekeeping" release.

Welcome @Bamieh and @xxczaki to the team!

πŸ›: Fixes

  • #2661: progress reporter now accepts reporter options (@canoztokmak)
  • #3142: xit in bdd interface now properly returns its Test object (@Bamieh)
  • #3075: Diffs now computed eagerly to avoid misinformation when reported (@abrady0)
  • #2745: --help will now help you even if you have a mocha.opts (@Zarel)

πŸŽ‰ Enhancements

  • #2514: The --no-diff flag will completely disable diff output (@CapacitorSet)
  • #3058: All "setters" in Mocha's API are now also "getters" if called without arguments (@makepanic)

πŸ“– Documentation

πŸ”© Other

Commits

The new version differs by 409 commits.

  • 6b9ddc6 Release v4.1.0
  • 3c4b116 update CHANGELOG for v4.1.0
  • 5be22b2 options.reporterOptions are used for progress reporter
  • ea96b18 add .fossaignore [ci skip]
  • adc67fd Revert "[ImgBot] optimizes images (#3175)"
  • ae3712c [ImgBot] optimizes images (#3175)
  • 33db6b1 Use x64 node on appveyor
  • 4a6e095 Run appveyor tests on x64 platform. Might enable sharp installation
  • 3abed9b Lint netlify-headers script
  • 119543e Add preconnect for doubleclick domain that google analytics results in contacting
  • bd5109e Remove crossorigin='anonymous' from preconnect hints. Only needed for fonts, xhr and es module loads
  • 123ee4f Handle the case where all avatars are already loaded at the time when the script exexecutes
  • 64deadc Specific value for inlining htmlimages to guarantee logo is inlined
  • 8f1ded4 https urls where possible
  • d5a5125 Be explicit about styling of screenshot images

There are 250 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

When I add ember-macro-helpers to my addon, I get lots of strange errors in my app using it

I have an addon that uses createClassComputed in the class KojacEmberCache, and all the addon tests pass. But when I try to use the addon and KojacEmberCache in my app, I get all these errors.

See the full log below, but I think the most interesting bit is "Could not find module ember-macro-helpers imported from ember-kojac/utils/ember/KojacEmberCache"

The tests in the addon pass fine, but somehow the app using the addon has these problems.

Any ideas ?

arys-MBP:browser gary$ ember test
β ™ Building[API] Warning: The .read and .rebuild APIs will stop working in the next Broccoli version
[API] Warning: Use broccoli-plugin instead: https://github.com/broccolijs/broccoli-plugin
[API] Warning: Plugin uses .read/.rebuild API: Filter
β ‹ BuildingDEPRECATION WARNING on line 64, column 8 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/app.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

DEPRECATION WARNING on line 67, column 8 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/app.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

DEPRECATION WARNING on line 632, column 56 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/sing-sass/_bootstrap-override.scss:
The value "#ffffff26" is currently parsed as a string, but it will be parsed as a color in
future versions of Sass. Use "unquote('#ffffff26')" to continue parsing it as a string.

DEPRECATION WARNING on line 632, column 63 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/sing-sass/_bootstrap-override.scss:
The value "#fff0" is currently parsed as a string, but it will be parsed as a color in
future versions of Sass. Use "unquote('#fff0')" to continue parsing it as a string.

β ™ BuildingDEPRECATION WARNING on line 76, column 8 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/app.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

DEPRECATION WARNING on line 77, column 8 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/app.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

DEPRECATION WARNING on line 78, column 8 of /Users/gary/repos/2018/ASDDriver/browser/tmp/sass_compiler-input_base_path-VABwSeal.tmp/0/app/styles/app.scss:
Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

cleaning up...
Built project successfully. Stored in "/Users/gary/repos/2018/ASDDriver/browser/tmp/class-tests_dist-4UCVFUad.tmp".
ok 1 Chrome 67.0 - [0 ms] - ESLint | app app.js
ok 2 Chrome 67.0 - [0 ms] - ESLint | app components/chat-widget.js
ok 3 Chrome 67.0 - [0 ms] - ESLint | app components/content-block.js
ok 4 Chrome 67.0 - [0 ms] - ESLint | app components/ember-power-select.js
ok 5 Chrome 67.0 - [0 ms] - ESLint | app components/home-layout.js
ok 6 Chrome 67.0 - [1 ms] - ESLint | app components/instructor-layout.js
ok 7 Chrome 67.0 - [0 ms] - ESLint | app components/login-form.js
ok 8 Chrome 67.0 - [0 ms] - ESLint | app components/md-text-renderer.js
ok 9 Chrome 67.0 - [0 ms] - ESLint | app components/md-text.js
ok 10 Chrome 67.0 - [0 ms] - ESLint | app components/simple-image.js
ok 11 Chrome 67.0 - [0 ms] - ESLint | app components/simple-layout.js
ok 12 Chrome 67.0 - [0 ms] - ESLint | app components/sing-navbar.js
ok 13 Chrome 67.0 - [0 ms] - ESLint | app components/sing-sidebar.js
ok 14 Chrome 67.0 - [0 ms] - ESLint | app components/student-select.js
ok 15 Chrome 67.0 - [0 ms] - ESLint | app components/task-to-student-button.js
ok 16 Chrome 67.0 - [0 ms] - ESLint | app components/title-1-column-layout.js
ok 17 Chrome 67.0 - [0 ms] - ESLint | app components/video-player.js
ok 18 Chrome 67.0 - [0 ms] - ESLint | app components/visual-with-text.js
ok 19 Chrome 67.0 - [0 ms] - ESLint | app controllers/members.js
ok 20 Chrome 67.0 - [0 ms] - ESLint | app controllers/members/instructor.js
ok 21 Chrome 67.0 - [0 ms] - ESLint | app controllers/members/student.js
ok 22 Chrome 67.0 - [0 ms] - ESLint | app controllers/page.js
ok 23 Chrome 67.0 - [0 ms] - ESLint | app controllers/play.js
ok 24 Chrome 67.0 - [0 ms] - ESLint | app controllers/session/login.js
ok 25 Chrome 67.0 - [0 ms] - ESLint | app initializers/environment.js
ok 26 Chrome 67.0 - [0 ms] - ESLint | app lib/FirebaseKojacStore.js
ok 27 Chrome 67.0 - [0 ms] - ESLint | app lib/index-route-with-default.js
ok 28 Chrome 67.0 - [0 ms] - ESLint | app mixins/waitable.js
ok 29 Chrome 67.0 - [0 ms] - ESLint | app models/AppCache.js
ok 30 Chrome 67.0 - [0 ms] - ESLint | app models/Chat.js
ok 31 Chrome 67.0 - [0 ms] - ESLint | app models/Person.js
ok 32 Chrome 67.0 - [0 ms] - ESLint | app models/Role.js
ok 33 Chrome 67.0 - [0 ms] - ESLint | app models/Task.js
ok 34 Chrome 67.0 - [0 ms] - ESLint | app resolver.js
ok 35 Chrome 67.0 - [0 ms] - ESLint | app router.js
ok 36 Chrome 67.0 - [0 ms] - ESLint | app routes/application.js
ok 37 Chrome 67.0 - [0 ms] - ESLint | app routes/index.js
ok 38 Chrome 67.0 - [0 ms] - ESLint | app routes/members.js
ok 39 Chrome 67.0 - [0 ms] - ESLint | app routes/members/index.js
ok 40 Chrome 67.0 - [0 ms] - ESLint | app routes/members/instructor.js
ok 41 Chrome 67.0 - [0 ms] - ESLint | app routes/members/manager.js
ok 42 Chrome 67.0 - [0 ms] - ESLint | app routes/members/page.js
ok 43 Chrome 67.0 - [0 ms] - ESLint | app routes/members/student.js
ok 44 Chrome 67.0 - [0 ms] - ESLint | app routes/members/timeline.js
ok 45 Chrome 67.0 - [0 ms] - ESLint | app routes/mock.js
ok 46 Chrome 67.0 - [0 ms] - ESLint | app routes/mock/lesson.js
ok 47 Chrome 67.0 - [0 ms] - ESLint | app routes/page.js
ok 48 Chrome 67.0 - [0 ms] - ESLint | app routes/play.js
ok 49 Chrome 67.0 - [0 ms] - ESLint | app routes/session/begin.js
ok 50 Chrome 67.0 - [0 ms] - ESLint | app routes/session/login.js
ok 51 Chrome 67.0 - [0 ms] - ESLint | app routes/session/restore.js
ok 52 Chrome 67.0 - [0 ms] - ESLint | app services/firebase.js
ok 53 Chrome 67.0 - [0 ms] - ESLint | app services/kojac.js
ok 54 Chrome 67.0 - [0 ms] - ESLint | app torii-adapters/application.js
ok 55 Chrome 67.0 - [0 ms] - ESLint | app torii-adapters/firebase.js
ok 56 Chrome 67.0 - [0 ms] - ESLint | app torii-adapters/firebaseui.js
ok 57 Chrome 67.0 - [0 ms] - ESLint | app torii-providers/firebase.js
ok 58 Chrome 67.0 - [89 ms] - Integration | Component | chat-widget renders
ok 59 Chrome 67.0 - [10 ms] - Integration | Component | sing-sidebar renders
ok 60 Chrome 67.0 - [5 ms] - Integration | Component | task-to-student-button renders
not ok 61 Chrome 67.0 - [39 ms] - Integration | Kojac "before each" hook for "login and read own Person"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
...
not ok 62 Chrome 67.0 - [0 ms] - Integration | Kojac "after each" hook for "login and read own Person"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'exports\' of undefined\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at requireModule (http://localhost:7357/assets/vendor.js:32:18)\\n at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)\\n at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)\\n at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)\'\n' }
...
not ok 63 Chrome 67.0 - [0 ms] - Unit | Controller | members "before each" hook for "exists"
---
message: >
Cannot read property 'subject' of undefined
stack: >
TypeError: Cannot read property 'subject' of undefined
at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)
at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)
at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)
at new Promise (http://localhost:7357/assets/vendor.js:60004:35)
at nextStep (http://localhost:7357/assets/test-support.js:25276:18)
at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)
at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)
at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)
at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)
at http://localhost:7357/assets/vendor.js:59563:16
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'subject\' of undefined\n at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)\\n at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)\\n at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)\\n at new Promise (http://localhost:7357/assets/vendor.js:60004:35)\\n at nextStep (http://localhost:7357/assets/test-support.js:25276:18)\\n at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)\\n at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)\\n at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)\\n at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)\\n at http://localhost:7357/assets/vendor.js:59563:16\'\n' }
...
not ok 64 Chrome 67.0 - [0 ms] - Unit | Controller | members "after each" hook for "exists"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'exports\' of undefined\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at requireModule (http://localhost:7357/assets/vendor.js:32:18)\\n at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)\\n at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)\\n at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)\'\n' }
...
not ok 65 Chrome 67.0 - [0 ms] - Unit | Controller | members/instructor "before each" hook for "exists"
---
message: >
Cannot read property 'subject' of undefined
stack: >
TypeError: Cannot read property 'subject' of undefined
at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)
at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)
at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)
at new Promise (http://localhost:7357/assets/vendor.js:60004:35)
at nextStep (http://localhost:7357/assets/test-support.js:25276:18)
at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)
at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)
at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)
at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)
at http://localhost:7357/assets/vendor.js:59563:16
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'subject\' of undefined\n at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)\\n at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)\\n at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)\\n at new Promise (http://localhost:7357/assets/vendor.js:60004:35)\\n at nextStep (http://localhost:7357/assets/test-support.js:25276:18)\\n at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)\\n at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)\\n at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)\\n at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)\\n at http://localhost:7357/assets/vendor.js:59563:16\'\n' }
...
not ok 66 Chrome 67.0 - [0 ms] - Unit | Controller | members/student exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:884:29)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 67 Chrome 67.0 - [0 ms] - TestLoader Failures asddriver/tests/unit/models/app-cache-test: could not be loaded
---
message: >
Could not find module ember-macro-helpers imported from ember-kojac/utils/ember/KojacEmberCache
stack: >
Error: Could not find module ember-macro-helpers imported from ember-kojac/utils/ember/KojacEmberCache
at missingModule (http://localhost:7357/assets/vendor.js:252:11)
at findModule (http://localhost:7357/assets/vendor.js:263:7)
at Module.findDeps (http://localhost:7357/assets/vendor.js:173:24)
at findModule (http://localhost:7357/assets/vendor.js:267:11)
at Module.findDeps (http://localhost:7357/assets/vendor.js:173:24)
at findModule (http://localhost:7357/assets/vendor.js:267:11)
at Module.findDeps (http://localhost:7357/assets/vendor.js:173:24)
at findModule (http://localhost:7357/assets/vendor.js:267:11)
at requireModule (http://localhost:7357/assets/vendor.js:29:15)
at TestLoader.require (http://localhost:7357/assets/test-support.js:24574:9)
Log: |
...
not ok 68 Chrome 67.0 - [0 ms] - Unit | Route | members/index exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:985:24)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 69 Chrome 67.0 - [0 ms] - Unit | Route | members/instructor exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:1000:24)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 70 Chrome 67.0 - [0 ms] - Unit | Route | members/manager exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:1015:24)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 71 Chrome 67.0 - [0 ms] - Unit | Route | members/page exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:1030:24)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 72 Chrome 67.0 - [0 ms] - Unit | Route | members/timeline exists
---
message: >
this.subject is not a function
stack: >
TypeError: this.subject is not a function
at Context. (http://localhost:7357/assets/tests.js:1063:24)
at invoke (http://localhost:7357/assets/test-support.js:21921:21)
at Context.method (http://localhost:7357/assets/test-support.js:21986:13)
at callFnAsync (http://localhost:7357/assets/test-support.js:13190:8)
at Test.Runnable.run (http://localhost:7357/assets/test-support.js:13142:7)
at Runner.runTest (http://localhost:7357/assets/test-support.js:13630:10)
at http://localhost:7357/assets/test-support.js:13736:12
at next (http://localhost:7357/assets/test-support.js:13550:14)
at http://localhost:7357/assets/test-support.js:13560:7
at next (http://localhost:7357/assets/test-support.js:13492:14)
Log: |
...
not ok 73 Chrome 67.0 - [1 ms] - Unit | Service | firebase "before each" hook for "set then get"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
...
not ok 74 Chrome 67.0 - [1 ms] - Unit | Service | firebase "after each" hook for "set then get"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'exports\' of undefined\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at requireModule (http://localhost:7357/assets/vendor.js:32:18)\\n at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)\\n at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)\\n at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)\'\n' }
...
not ok 75 Chrome 67.0 - [0 ms] - Unit | Service | kojac "before each" hook for "exists"
---
message: >
Cannot read property 'subject' of undefined
stack: >
TypeError: Cannot read property 'subject' of undefined
at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)
at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)
at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)
at new Promise (http://localhost:7357/assets/vendor.js:60004:35)
at nextStep (http://localhost:7357/assets/test-support.js:25276:18)
at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)
at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)
at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)
at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)
at http://localhost:7357/assets/vendor.js:59563:16
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'subject\' of undefined\n at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)\\n at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)\\n at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)\\n at new Promise (http://localhost:7357/assets/vendor.js:60004:35)\\n at nextStep (http://localhost:7357/assets/test-support.js:25276:18)\\n at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)\\n at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)\\n at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)\\n at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)\\n at http://localhost:7357/assets/vendor.js:59563:16\'\n' }
...
not ok 76 Chrome 67.0 - [0 ms] - Unit | Service | kojac "after each" hook for "exists"
---
message: >
Cannot read property 'exports' of undefined
stack: >
TypeError: Cannot read property 'exports' of undefined
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at Module._reify (http://localhost:7357/assets/vendor.js:148:59)
at Module.reify (http://localhost:7357/assets/vendor.js:135:27)
at Module.exports (http://localhost:7357/assets/vendor.js:109:10)
at requireModule (http://localhost:7357/assets/vendor.js:32:18)
at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)
at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)
at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'exports\' of undefined\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at Module._reify (http://localhost:7357/assets/vendor.js:148:59)\\n at Module.reify (http://localhost:7357/assets/vendor.js:135:27)\\n at Module.exports (http://localhost:7357/assets/vendor.js:109:10)\\n at requireModule (http://localhost:7357/assets/vendor.js:32:18)\\n at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:133432:20)\\n at Class.resolveOther (http://localhost:7357/assets/vendor.js:133134:32)\\n at Class.superWrapper [as resolveOther] (http://localhost:7357/assets/vendor.js:53391:28)\'\n' }
...
not ok 77 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
text: ''TypeError: Cannot read property \'subject\' of undefined\n at exports.default.teardownSubject (http://localhost:7357/assets/test-support.js:26139:32)\\n at Ember.RSVP.Promise.resolve (http://localhost:7357/assets/test-support.js:25277:26)\\n at initializePromise (http://localhost:7357/assets/vendor.js:59524:7)\\n at new Promise (http://localhost:7357/assets/vendor.js:60004:35)\\n at nextStep (http://localhost:7357/assets/test-support.js:25276:18)\\n at exports.default.invokeSteps (http://localhost:7357/assets/test-support.js:25283:14)\\n at invokeSteps.then (http://localhost:7357/assets/test-support.js:25240:21)\\n at tryCatcher (http://localhost:7357/assets/vendor.js:59327:21)\\n at invokeCallback (http://localhost:7357/assets/vendor.js:59499:33)\\n at http://localhost:7357/assets/vendor.js:59563:16\'\n' }
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...
ok 78 Chrome 67.0 - [0 ms] - ESLint | tests helpers/destroy-app.js
ok 79 Chrome 67.0 - [0 ms] - ESLint | tests helpers/resolver.js
ok 80 Chrome 67.0 - [0 ms] - ESLint | tests helpers/start-app.js
ok 81 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/chat-widget-test.js
ok 82 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/ember-power-select-test.js
ok 83 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/md-text-test.js
ok 84 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/simple-image-test.js
ok 85 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/sing-sidebar-test.js
ok 86 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/student-select-test.js
ok 87 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/task-to-student-button-test.js
ok 88 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/video-player-test.js
ok 89 Chrome 67.0 - [0 ms] - ESLint | tests integration/components/visual-with-text-test.js
ok 90 Chrome 67.0 - [0 ms] - ESLint | tests integration/kojac.spec.js
ok 91 Chrome 67.0 - [0 ms] - ESLint | tests integration/kojac/kojac-firebase-login-test.js
ok 92 Chrome 67.0 - [0 ms] - ESLint | tests test-helper.js
ok 93 Chrome 67.0 - [0 ms] - ESLint | tests unit/controllers/members-test.js
ok 94 Chrome 67.0 - [0 ms] - ESLint | tests unit/controllers/members/instructor-test.js
ok 95 Chrome 67.0 - [0 ms] - ESLint | tests unit/controllers/members/student-test.js
ok 96 Chrome 67.0 - [0 ms] - ESLint | tests unit/controllers/page-test.js
ok 97 Chrome 67.0 - [0 ms] - ESLint | tests unit/models/app-cache-test.js
ok 98 Chrome 67.0 - [0 ms] - ESLint | tests unit/models/role_test.js
ok 99 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members-test.js
ok 100 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members/index-test.js
ok 101 Chrome 67.0 - [1 ms] - ESLint | tests unit/routes/members/instructor-test.js
ok 102 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members/manager-test.js
ok 103 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members/page-test.js
ok 104 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members/student-test.js
ok 105 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/members/timeline-test.js
ok 106 Chrome 67.0 - [0 ms] - ESLint | tests unit/routes/mock/lesson-test.js
ok 107 Chrome 67.0 - [0 ms] - ESLint | tests unit/services/firebase-test.js
ok 108 Chrome 67.0 - [0 ms] - ESLint | tests unit/services/kojac-test.js
not ok 109 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'exports' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'exports' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...
not ok 110 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...
ok 111 Chrome 67.0 - [0 ms] - Role rolesContain leaf must only match whole word
ok 112 Chrome 67.0 - [0 ms] - Role rolesContain leaf must match first
ok 113 Chrome 67.0 - [0 ms] - Role rolesContain leaf must match last
ok 114 Chrome 67.0 - [0 ms] - Role rolesContain leaf must match middle
not ok 115 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...
not ok 116 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'exports' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'exports' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...
not ok 117 Chrome 67.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887
---
Log: |
{ type: 'error',
testContext: { name: '', state: 'complete' },
text: 'Uncaught TypeError: Cannot read property 'subject' of undefined at http://localhost:7357/assets/test-support.js, line 21887\n' }
...

1..117

tests 117

pass 95

skip 0

fail 22

Testem finished with non-zero exit code. Tests failed.

Garys-MBP:browser gary$

add debug and log macros

The debug would put a debugger; call in the middle of a macro tree for you:

foo: conditional('bar', debug(or('qwer', 'yui')), 'asdf')

log would be very similar. It would log out vitals for you (keys, values, etc.):

foo: conditional('bar', log(or('qwer', 'yui')), 'asdf')

They should be stripped from production builds, since they're only meant as temporary debugging helpers.

Broken in IE11 as of version 4.1.0

The addition of https://github.com/kellyselden/ember-macro-helpers/blob/v4.1.0/vendor/monkey-patch-ember-computed.js in version 4.1.0 seems to be breaking this addon in IE11 due to that file containing ES6 code that isn't being compiled by ember-cli-babel.

If required I can setup a reproduction repo to demonstrate the issue, but here are the basic steps to verify the problem:

  • Create a new ember app with ember-cli (I used [email protected]): ember new my-app
  • Update the config/targets.js file to include IE11 by default:
diff --git a/config/targets.js b/config/targets.js
index 8ffae36..03c1395 100644
--- a/config/targets.js
+++ b/config/targets.js
@@ -3,16 +3,10 @@
 const browsers = [
   'last 1 Chrome versions',
   'last 1 Firefox versions',
-  'last 1 Safari versions'
+  'last 1 Safari versions',
+  'ie 11'
 ];

-const isCI = !!process.env.CI;
-const isProduction = process.env.EMBER_ENV === 'production';
-
-if (isCI || isProduction) {
-  browsers.push('ie 11');
-}
-
  • Add ember-macro-helpers: ember install ember-macro-helpers
  • Serve the app and try viewing in IE11: ember serve
  • A syntax error is shown in console for the monkey patch file

It'd be great if this addon could continue to support IE11, but if not then the incompatibility should probably be added to the README to let people know that the latest version doesn't support IE.

An in-range update of ember-data is breaking the build 🚨

Version 2.17.0 of ember-data was just published.

Branch Build failing 🚨
Dependency ember-data
Current Version 2.16.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-data is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes Ember Data 2.17.0

Release 2.17.0 (November 19, 2017)

  • #5216 [BUGFIX beta] invalid record becomes loaded when property is reset
  • #4998 [DOC beta] Assert that both modelName and id are passed to peekRecord (#4998)
  • #5217 [BUGFIX beta] RecordReference returns null when not yet loaded
  • #5166 [DOC] Remove mention of bower install from README
  • #5114 Make import stripping smarter to resolve #5019
  • #5165 [DOC] Update README build step script name
  • #5212 Do not show feature flag improved-ajax methods in the api docs
  • #5183 [DOCS release] Add missing "relationship" field to RESTAdapter.findBelongsTo docs
  • #5176 fix node 4
  • #5172 [DOC] Remove parameter from BelongsToReference.value
  • #5178 Ignore included resources without that don't have a corresponding ember-data model
  • #5213 [BUGFIX beta] proxy meta on PromiseArray
  • #5197 Fix ember-data Node 4.x builds
  • #5191 Remove feature flagging for ds-extended-errors.
  • #5184 Update LICENSE through 2017
  • #5196 [BUGFIX beta] Avoid cache related warnings during builds.
  • #5206 [BUGFIX beta] Fix broccoli-babel-transpiler cache warnings
  • #5216 [BUGFIX beta] invalid record becomes loaded when property is reset
  • #5220 Remove (unnecessary) ember-inflector peer dependency
  • #5223 [BUGFIX release] Cleanup test only dependencies.
  • #5224 Add missing dependency for travis build
  • #5232 Update documentation in model.js
Commits

The new version differs by 43 commits ahead by 43, behind by 21.

  • 01760fe Release Ember Data 2.17.0
  • cc7a1aa Update changelog for 2.17.0 release
  • ea4397e [DOC beta] Assert that both modelName and id are passed to peekRecord (#4998)
  • d806319 Release Ember Data 2.17.0-beta.2
  • 6792b6f Update changelog for Ember Data 2.17.0-beta.2
  • 9f5236a Remove ember-inflector peer dependency
  • e3c93d1 Update model.js
  • 691eeb6 [BUGFIX beta] Normalize model names during push
  • 1559f39 Fixup DS.Store.pushPayload example (#5243)
  • 3c079d6 [BUGFIX beta] setProperties to clear errors works (#5248)
  • 3b3e325 [doc] Update links to Ember Guide (#5250)
  • e45e0f1 Do not show feature flag improved-ajax methods in the api docs
  • 9bc16ae [BUGFIX beta] invalid record becomes loaded when property is reset
  • 723f4e6 [BUGFIX beta] RecordReference returns null when not yet loaded
  • d0c8128 Fix docs link. (#5221)

There are 43 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import

Thanks for all of your great addons! I'm seeing the following error during our build - it doesn't happen in dev or testing (I assume because babel not required?). This is the error:
Note: we are on ember 2.18, ember-cli-babel 6.6

  - broccoliBuilderErrorStack: SyntaxError: ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import
> 1 | import { expandProperties } from '@ember/object/computed';
    | ^
  2 | 
  3 | export default function(property) {
  4 |   let newPropertyList = [];
    at File.buildCodeFrameError (/Users/alex/proj/desktop-fe/node_modules/broccoli-babel-transpiler/node_modules/babel-core/lib/transformation/file/index.js:427:15)
    at NodePath.buildCodeFrameError (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/index.js:140:26)
    at ImportDeclaration.specifiers.forEach.specifierPath (/Users/alex/proj/desktop-fe/node_modules/babel-plugin-ember-modules-api-polyfill/src/index.js:123:26)
    at Array.forEach (native)
    at PluginPass.ImportDeclaration (/Users/alex/proj/desktop-fe/node_modules/babel-plugin-ember-modules-api-polyfill/src/index.js:88:22)
    at newFn (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/context.js:150:16)
  - codeFrame: > 1 | import { expandProperties } from '@ember/object/computed';
    | ^
  2 | 
  3 | export default function(property) {
  4 |   let newPropertyList = [];
  - errorMessage: Build Canceled: Broccoli Builder ran into an error with `Babel` plugin. πŸ’₯
ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import
  - errorType: Build Error
  - location:
    - column: 0
    - line: 1
  - message: Build Canceled: Broccoli Builder ran into an error with `Babel` plugin. πŸ’₯
ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import
  - name: Error
  - nodeAnnotation: Babel
  - nodeName: Babel
  - originalErrorMessage: ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import
  - stack: SyntaxError: ember-macro-helpers/expand-property.js: @ember/object/computed does not have a expandProperties import
> 1 | import { expandProperties } from '@ember/object/computed';
    | ^
  2 | 
  3 | export default function(property) {
  4 |   let newPropertyList = [];
    at File.buildCodeFrameError (/Users/alex/proj/desktop-fe/node_modules/broccoli-babel-transpiler/node_modules/babel-core/lib/transformation/file/index.js:427:15)
    at NodePath.buildCodeFrameError (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/index.js:140:26)
    at ImportDeclaration.specifiers.forEach.specifierPath (/Users/alex/proj/desktop-fe/node_modules/babel-plugin-ember-modules-api-polyfill/src/index.js:123:26)
    at Array.forEach (native)
    at PluginPass.ImportDeclaration (/Users/alex/proj/desktop-fe/node_modules/babel-plugin-ember-modules-api-polyfill/src/index.js:88:22)
    at newFn (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/alex/proj/desktop-fe/node_modules/babel-traverse/lib/context.js:150:16)

An in-range update of ember-resolver is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 4.5.1 of ember-resolver was just published.

Branch Build failing 🚨
Dependency ember-resolver
Current Version 4.5.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-resolver is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 22 commits.

  • 4fbf54a v4.5.1
  • 0d3a85d Merge pull request #225 from ember-cli/expandLocalLookup
  • 338680a Implement MU sources and namespaces with expandLocalLookup
  • ecc4748 glimmer-resolver v0.4.3
  • 04f47d5 Add new types for new Ember releases
  • d7dc4dd Merge pull request #224 from 201-created/isaac/fallback-normalization
  • e38f353 normalize specifiers before passing to fallback
  • 13f05eb Merge pull request #221 from 201-created/isaac/fix-main-service-lookup
  • b2357af Merge pull request #222 from SergeAstapov/document-pluralizedTypes
  • 000bc2b [DOCS] Adds example about pluralizedTypes usage
  • 9b5e679 fix requires registry for main services/components
  • 9937486 Add template-options type to config
  • 7f3fbcf Merge pull request #220 from 201-created/isaac/namespace-argument
  • b57afa8 Add tests for main add-on lookup
  • 50036c2 glimmer-wrapper resolver to take targetNamespace

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of ember-data is breaking the build 🚨

Version 2.16.0 of ember-data just got published.

Branch Build failing 🚨
Dependency ember-data
Current Version 2.15.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 123 commits ahead by 123, behind by 58.

  • 1dd87cb Release Ember Data 2.16.0
  • c1d1ac8 Update changelog for Ember Data 2.16.0 release
  • fc07119 Update changelog on master.
  • 83a4826 [BUGFIX beta] Avoid cache related warnings during builds.
  • 0dd5d47 Release Ember Data 2.16.0-beta.1
  • 9a1cb7d Update changelog for Ember Data 2.16.0-beta.1 release
  • aabaa1a Merge pull request #5192 from bmac/rebase-5107-beta
  • 62b6fdf Remove feature flagging for ds-extended-errors.
  • ffeb55a Merge pull request #5162 from emberjs/locks-patch-1
  • 22b5154 Update RELEASE.md
  • d3139da Merge pull request #5150 from emberjs/only-enumerate-relationships-provided
  • 7a7bafa Merge pull request #5151 from emberjs/reduce-duplicate-signals-to-record-array-manager-on-record-push
  • 441e48c Merge pull request #5153 from emberjs/fix-destroy-relationship
  • 5f5d5d1 [BUGFIX release] ensure inverse async HasMany is correctly maintained
  • 01113a0 [CLEANUP] PERF prevent duplicate recordArrayManager signals on push of a new record

There are 123 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Unexpected behavior with Ember.ArrayProxy

The computed macro does not play well with the proxied array properties of Ember.ArrayProxy. For example:

foo: computed('[]', (bar) => {
  // `bar' is always undefined
})

Ideally, the first argument to the callback in the above example would resolve to the content property of the ArrayProxy, or even better, the ArrayProxy object itself. Unfortunately, it's undefined (actually, I think @each gives you undefined, [] gives you an error about calling Ember.get with an empty string). The workaround is to do this:

foo: computed('content.[]', (bar) => {
  // `bar' is the content array
})

So maybe we can consider this a "nice to have" for the future. Here's a Twiddle that demonstrates the behavior. Thank you!

Doesn't work with async observers

I recently had to downgrade my applications ember version from 3.13 due to very slow performance from synchronous observers. When I enabled async observers I noticed that ember-awesome-macros were no longer computing correctly. This repo is a fork of ember-macro-helpers which has failing tests from using async observers.

RFC: lazyComputed API

Regarding kellyselden/ember-awesome-macros#275

I'm trying to decide the best API. Options:

// need two versions because the version of `getValue` is bundled
import lazyComputed from 'ember-macro-helpers/lazy-computed';
import lazyComputedUnsafe from 'ember-macro-helpers/lazy-computed-unsafe';

{
  val1: lazyComputed('key1', 'key2', (getValue, key1, key2) => {
    return getValue(key1) || getValue(key2);
  }),
  val2: lazyComputedUnsafe('key1', 'key2', (getValue, key1, key2) => {
    return getValue(key1) || getValue(key2);
  })
}

Or:

import lazyComputed from 'ember-macro-helpers/lazy-computed';
import getValue from 'ember-macro-helpers/get-value';
import getValueUnsafe from 'ember-macro-helpers/get-value-unsafe';

{
  val1: lazyComputed('key1', 'key2', (key1, key2) => {
    return getValue(key1) || getValue(key2);
  }),
  val2: lazyComputed('key1', 'key2', (key1, key2) => {
    return getValueUnsafe(key1) || getValueUnsafe(key2);
  })
}

cc @JackCA @Turbo87

An in-range update of ember-source is breaking the build 🚨

Version 2.15.2 of ember-source just got published.

Branch Build failing 🚨
Dependency ember-source
Current Version 2.15.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As ember-source is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 4 commits.

  • 60542b1 Release 2.15.2.
  • 636604c Add 2.15.2 to CHANGELOG.
  • 9c85b50 [BUGFIX release] Avoid creating event dispatcher in FastBoot with Engines
  • f9fa076 Data Adapter: Only trigger model type update if the record live array count actually changed

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset name not found within published preset config (monorepo:angularmaterial). Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Computed properties not triggering re-render

Seems like the change in #142 causes no re-renders in my app at all after upgrading to 0.16.3. This happens on ember 2.13 and 2.16 at least. Everything renders fine on load and after refreshing, but for example created items don't appear in {{#each}} loops bound to array.filterBy'd arrays.

Here's the relevant parts of my code, I may be doing something wrong but it was working fine on 0.16.0: noutube/backend@d632270 (I can update ember-awesome-macros and it still works, only breaks after updating ember-macro-helpers.)

I can come up with a stripped down reproduction if this isn't helpful.

An in-range update of ember-load-initializers is breaking the build 🚨

Version 1.1.0 of ember-load-initializers was just published.

Branch Build failing 🚨
Dependency ember-load-initializers
Current Version 1.0.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-load-initializers is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 14 commits.

  • 3f1f39b 1.1.0
  • 234964c Add 1.1.0 to CHANGELOG.
  • f9c3eac Merge pull request #53 from GavinJoyce/gj/allow-colocated-test-files
  • 6b6e40c allow colocated test files
  • d3e4a88 Merge pull request #52 from eliasmelgaco/update-ember-cli
  • 85adf6c Update ember-cli to 3.1.2
  • 69fe4b4 Merge pull request #51 from efx/bump-ember-cli
  • fb82460 bump dependencies, refactor tests slightly
  • d73c0b6 Merge pull request #49 from efx/fix-linting
  • 3a87918 fix linting config
  • bff6ff6 Merge pull request #48 from efx/topic-contributer-cleanup
  • ea41645 internal clean up for contributing
  • 043dbb9 Merge pull request #46 from efx/fix-coduct-markdown
  • 9c41f09 fix code of conduct markdown

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of ember-cli-dependency-checker is breaking the build 🚨

Version 2.1.0 of ember-cli-dependency-checker was just published.

Branch Build failing 🚨
Dependency ember-cli-dependency-checker
Current Version 2.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-dependency-checker is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 13 commits.

  • 4e9748c v2.1.0
  • fad5b91 Merge pull request #82 from rwjblue/updates
  • 86de2a6 Use yarn --non-interactive --no-lockfile in CI.
  • eb0b4f1 Remove browser related packages from devDependencies.
  • 615632f Remove build related files.
  • 7e917c4 Remove browser related testing infrastructure.
  • a0009ac Remove unused directories.
  • 351f694 Drop 0.12 from supported engines.
  • 68294ff Use current node versions in CI.
  • e22f28f Merge pull request #81 from ef4/module-resolution
  • ee038c7 Use correct node_module resolution
  • 94711af Merge pull request #80 from knownasilya/patch-1
  • b41f7a7 Better error messaging for version errors

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of ember-cli-shims is breaking the build 🚨

Version 1.2.0 of ember-cli-shims was just published.

Branch Build failing 🚨
Dependency ember-cli-shims
Current Version 1.1.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-shims is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Changelog please

Updated from 0.5.0 to 0.14.0 and my project broke. Figured I had to update ember-awesome-macros as well, but having a list of breaking changes would be nice.

Upgrading ember-awesome-macros from 0.31.3 to 0.33.0 results in error when importing `ember-weakmap`

Worked with ember-awesome-macros 0.31.3. After upgrade to 0.33.0 I'm getting an error from ember-macro-helpers:

Error while processing route: app.repos.repo.index Could not find module `ember-weakmap` imported from `ember-macro-helpers/create-class-computed` Error: Could not find module `ember-weakmap` imported from `ember-macro-helpers/create-class-computed`

Strangely, npm ls shows [email protected] installed:

...
β”œβ”€β”¬ [email protected]
β”‚ β”œβ”€β”¬ [email protected]
β”‚ β”‚ β”œβ”€β”¬ [email protected]
β”‚ β”‚ β”‚ └── [email protected]
β”‚ β”‚ └── [email protected]
β”‚ β”œβ”€β”¬ [email protected]
β”‚ β”‚ └── [email protected]
β”‚ β”œβ”€β”€ [email protected]
β”‚ β”œβ”€β”¬ [email protected]
β”‚ β”‚ └── [email protected]
β”‚ └── [email protected]
...

An in-range update of loader.js is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 4.7.0 of loader.js was just published.

Branch Build failing 🚨
Dependency loader.js
Current Version 4.6.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

loader.js is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 9 commits.

  • 27b4098 release v4.7.0 πŸŽ‰
  • d42a2c7 Merge pull request #137 from 2hu12/patch-1
  • 367dbfc Update define.alias API description
  • d5fb086 Merge pull request #133 from tmquinn/find-alias-modules-with-index
  • ffacdb4 Add test for quz/index
  • 933c7c8 Merge pull request #134 from ember-cli/add-test
  • ed8c85a Fix typo and add tests
  • 5141a0f Add test ensuring /index doesn’t invokes callbacks the appropriate number of times
  • f8b282b Find aliases whose target is at index

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

double render

It looks like the current solution to detect double renders does not work in newer ember versions. A lot of your travis builds are failing. I'm hoping this has something todo with the double render assertions I'm getting a lot of in my applications.
I've currently disabled them with ember features (EMBER_GLIMMER_DETECT_BACKTRACKING_RERENDER set to false), but I think Ember 3 might have stricter behaviour on this. So I was hoping there would be a solution to this problem.

I think meta.readableLastRendered is not used anymore by ember? (https://github.com/kellyselden/ember-macro-helpers/blob/master/addon/create-class-computed.js#L71)

The best I could find was https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/transaction.js where the assertion is raised and some other meta variable could be used instead of readableLastRendered. But I feel like detecting double renders is kind of iffy. Shouldn't this be handled in a better way by ember in general?

[edit]
I think the double render is causing troubles even without doing the click in the current test. https://github.com/kellyselden/ember-macro-helpers/blob/master/addon/create-class-computed.js#L153 seems to trigger an invalidation of the 'parent' property when setting up the computed property.

Remove arrow function usage in README

The README shows the following example:

import Ember from 'ember';
import computed from 'ember-macro-helpers/computed';

export default Ember.Component.extend({
  key1: false,
  key2: true,

  result: computed(Ember.computed.or('key1', 'key2'), value => {
    console.log(value); // true
    // do something else
  })
});

But as you know, using an arrow function for result's callback will not allow access to the current object instance as this. In this case, you are not using this so the example is technically correct, but it seems to be tripping folks up a bit (saw some convo in slack about this).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.