kay-zee / be_music_kan_zhang Goto Github PK

• json files at root folder (and they are not loaded at tests?)
• node_modules should be in the repo either, rather, npm installed
• views, do you use them?
• controllers associated with the above
• mongodb binary
• client assets ..

These are the most striking so far, but also please take some time to think this further.

Your routes are a bit overloaded with huge functions.

Separate some of the logic to models that behave in a harmonious way to both persist the data given to them and taken form them in a format that makes the manipulation way cleaner

the answers should be served in JSON format, no HTML, and also tested accordingly

Please note that save in exceptional situations, the DB don't go inside the repo.
Instead, having a script to load the data is much preferred. If you go with that, also find a way to reset the data.

A hardcoded url such as mongodb://localhost:27017/BE_music_db is fine for development tho =)

Please make sure that there is a certain setup for the tests that allow then to run repeatably without need of manual arrangements such as dropping tables

• load data sets form json files
• use the library request to make your requests
• when above is done, look into lib async to make the code more clean

We found your solution with tracker>=counter smart anyway =)

when I run node app.js it doesn't work, can fix why?

~/eclipse_workspace/BE_music_Kan_Zhang $ node app.js 

module.js:333
    throw err;
          ^
Error: Cannot find module 'debug'
    at Function.Module._resolveFilename (module.js:331:15)
    at Function.Module._load (module.js:273:25)
    at Module.require (module.js:357:17)
    at require (module.js:373:17)
    at Object.<anonymous> (/Users/flockonus/eclipse_workspace/BE_music_Kan_Zhang/node_modules/express/node_modules/connect/lib/proto.js:14:13)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:349:32)
    at Function.Module._load (module.js:305:12)
    at Module.require (module.js:357:17)

Also got the same error trying to run via the IDE you pointed.

When working in a collaborative project, you have to mind people with different configurations and clear instructions