katef / kmkf Goto Github PK

This enables things like ASAN poisoning/unpoisoning for custom allocators.

This precludes a build where both ASAN and optimizations are enabled.

See

this should show useful variables, and list targets

The dependency generation in dep.mk, some of the ASAN/UBSAN rules, and probably other things fail in subtle ways if you set CC to a version-suffixed name, such as clang-10, because the makefile rules only compare against exactly "clang", "gcc", "emcc", and so on. They should probably be more flexible.

It looks like you intend that when sid exits with a non-zero status, you remove the generated parser files and then halt (false;), but it does not, because sid returns 0 on error.

(This is a sid bug, not a kmkf bug, but kmkf might be able to work around it.)

I have frequently run into nondetermistic build failures in CI caused by the install target attempting to install build/pc/${PC}.pc files before sed has created them from their .pc.in template. This is also easy to reproduce locally by building with -j > 1.

After sifting through output from bmake -dA I found that the problem appears to be redundant target creation. When loops over targets say install::, test::, etc., instead of adding another dependency to an existing build target, they are creating a new target. install depending on the .pc file being created is associated with a particular instance of install (in my debug log, it's install#4), but it appears in the list of files installed by a different install target. If I'm understanding the logs properly, the dependency is not set for all instances of install, just one, and others will still attempt to install it before it has been created.

Aside from builds breaking due to the race condition, probably the easiest way to check if this has been fixed is by looking for duplication in Global:.ALLTARGETS -- the log has 519x test targets, 25 x install, 410 x dep, 67 x clean, etc.

The CI build for libfsm is currently failing due to the macos configuration here:

2021-12-03T21:35:12.0936020Z ld -o build/lib/libfsm.dylib -dylib -flat_namespace -undefined dynamic_lookup -macosx_version_min 10.6  build/lib/adt.opic build/lib/print.opic build/lib/libfsm.opic
2021-12-03T21:35:12.1003940Z ar cr build/lib/libfsm.a build/lib/adt.o build/lib/print.o build/lib/libfsm.o
2021-12-03T21:35:12.1103140Z ld: warning: building for macOS 10.6 is deprecated
2021-12-03T21:35:12.1155970Z ld: dynamic main executables must link with libSystem.dylib for architecture x86_64
2021-12-03T21:35:12.1165600Z *** [build/lib/libfsm.dylib] Error code 1

10.6 is from over 10 years ago, also the dynamic library configuration needs updating. (It may not with a newer -macosx_version_min?)