kaszub09 / zabap_table_edit Goto Github PK

zcx_exception is not included in this repo and is used in two spots in class ZCL_ZABAP_TABLE_EDIT

When testing with example 1 (tcode ZABAP_TABLE_EDIT_EX1) entering invalid values in "created by" creates a short dump in function module CHANGEDOCUMENT_MULTIPLE_CASE2.

Steps to reproduce:
Enter value 555 in "created by", then save:

This is just a suggestion.

In the constructor of zcl_zabap_table_edit an extension class can be passed to parameter class_name. Instead of this, I think it would be better to just pass an instance of zif_zabap_table_edit to the constructor.

This would enable the caller to use existing instances or handle instance creation etc themselves. Also would enable to pass instances of local classes.

Even if creating a bespoke class, the caller can just pass NEW zcl_some_extension( ) to the parameter.

If the class does not implement interface zif_zabap_table_edit, syntax check will prevent activation.

What do you think?

I will fork and try to fix this, but I also want to open this issue to record this.

Some texts in gui status DYNAMIC_COMMANDS are in what looks like polish to me.

I am logged in in German.

The texts at the top of the screen are program texts of class zcl_zabap_table_edit_screen, the buttons at the bottom are from the gui status mentioned above.
The original language is set as english, so I think these texts should be english also. I can't find the original language of the gui status in the xml, though.