Fix render issue. if use the MultiShaderBufferedDrawNode about osu-framework-font HOT 10 CLOSED

I guess it will have the same issue if set the scale to 2.
But not that obviously.

from osu-framework-font.

Should test with step shader with no outline shader.

from osu-framework-font.

Damn, that weird shader effect is out of the lyric sprite text itself.

I guess karaoke sprite text is a sus.

Also, should deal with ComputeScreenSpaceDrawQuad() in the KaraokeSpriteText

from osu-framework-font.

Look at the border, it's sus.
It seems like two 2D image overlapping.

Maybe should test masking container with to re-product the same issue:

• two frame buffer container.
• TestShaderContainer with masking container?
• osu sprite text with masking container?

[edited]

even KaraokeSpriteText has the same issue, so maybe focus on MultiShaderBufferedDrawNode first.
TestSceneStepShader has the same issue.

from osu-framework-font.

Note:
Maybe write SingleShaderBufferedDrawNode first for checking if step shader will caused the same issue.
Because MultiShaderBufferedDrawNode has recycle issue, and it might not be used in the V1 karaoke system.

[update]
Seems GC issue has been fixed in the #245, so maybe it's the time to swap to the SingleShaderBufferedDrawNode again 🎉

from osu-framework-font.

https://github.com/karaoke-dev/osu-framework-font/blob/master/osu.Framework.Font/Graphics/MultiShaderBufferedDrawNode.cs#L115

Guess i got the reason:
Should not use source and target as same frame buffer.

But got no idea why not got the error in the windows before.

from osu-framework-font.

Guess it will not happened after #169 merged.
But this issue will be closed until fixed in the MultiShaderBufferedDrawNode.

from osu-framework-font.

Trying to solve in the #247
So this issue can be close.

from osu-framework-font.

Wait.
Re-open it because this issue is focus on render broken.

from osu-framework-font.

Guess implemented in the #331.

from osu-framework-font.