kallstadt-usgs / seisk Goto Github PK

install.sh looks for environment_osx.yml, which doesn't exist. Running

$ ./install.sh -r

uses the environment.yml file, but conflicts are found and it's slow to solve. I removed the ipython and python version restrictions in environment.yml and then bypassed install.sh by running

$ conda env create
$ conda activate seisk
$ pip install -e .

in the head of the repo. Things are (tentatively) working. Not sure if removing those version restrictions will cause problems, but at least interactive plotting is working with the Qt5Agg backend after calling e.g.

$ ipython
In [1]: import matplotlib.pyplot as plt
In [2]: plt.scatter(47, 47)

with no optional flags.

If there end up being no issues with the less-restricted environment.yml, I'd suggest making those changes since conda is a whole lot happier...

There is no return statement for axes within this function — only for fig. So in e.g. reviewDatademo.ipynb the line

fig3, axes = reviewData.make_spectrogram(st, maxPower=10**-11, minPower=10**-18, freqmax=15, log1=True)

gives an error since axes are not returned.