Code Monkey home page Code Monkey logo

lightkeeper's People

Contributors

b1ek avatar kalaksi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

lightkeeper's Issues

TODOs

A list of tasks you can do if you want to help the project.
Also you can check out the issues section for bug reports!

Dont forget to reference this issue when submitting a task fixing PR!

  • Don't store sensitive info (let modules choose if they contain any of that): src/cache.rs:62
  • Open external terminal without freezing the UI thread: src/command_handler.rs:345,356
  • Support for multiple commands per module (take a look at monitor_manager.rs): src/command_handler.rs:401,450,483
  • Check that destination file hasn't changed when uploading remote edits: src/command_handler.rs:451
  • Check if remote_text_editor and text_editor are valid executables: src/configuration.rs:44,46
  • Don't block the thread unnecessairly: src/connection_manager.rs
  • Validate path string: src/file_handler.rs:92,99
  • Refactor src/frontend/frontend.rs: src/frontend/frontend.rs:11
  • Use HostState instead?: src/frontend/frontend.rs:35
  • Use camelCase with QML models: src/frontend/qt/models/config_manager_model.rs:15, src/frontend/qt/models/host_data_manager_model.rs:15
  • Consider version too: src/frontend/qt/models/config_manager_model.rs:632
  • Add parent window id in src/frontend/qt/models/desktop_portal_model.rs:146,169
  • Don't use deprecated property: src/frontend/qt/models/theme_model.rs:48
  • Use Kirigami instead of hex colors?: src/frontend/qt/models/theme_model.rs:77

I collected those from code comments that are like this:

// TODO: blah blah blah

To view all comments like this, do this:

$ grep -n TODO $(find src -type f)

Ping issue on 0.4.4 version

$> flatpak run io.github.kalaksi.Lightkeeper 
[2023-09-10T09:57:46Z INFO  lightkeeper] Lightkeeper starting...
[2023-09-10T09:57:46Z INFO  lightkeeper::module::module_factory] Validating modules
[2023-09-10T09:57:46Z INFO  lightkeeper::module::module_factory] Loaded 28 command modules, 19 monitoring modules and 2 connector modules
[2023-09-10T09:57:46Z INFO  lightkeeper::configuration] Reading main configuration from /home/oktay454/.var/app/io.github.kalaksi.Lightkeeper/config/config.yml
[2023-09-10T09:57:46Z INFO  lightkeeper::configuration] Reading host configuration from /home/oktay454/.var/app/io.github.kalaksi.Lightkeeper/config/hosts.yml
[2023-09-10T09:57:46Z INFO  lightkeeper::configuration] Reading group configuration from /home/oktay454/.var/app/io.github.kalaksi.Lightkeeper/config/groups.yml
Gtk-Message: 12:57:46.408: Failed to load module "xapp-gtk3-module"
Gtk-Message: 12:57:46.427: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:57:46.428: Failed to load module "canberra-gtk-module"
[2023-09-10T09:57:46Z WARN  default] Qt: Session management error: Could not open network socket
[2023-09-10T09:57:46Z INFO  lightkeeper::module::connection::ssh] Connected to 127.0.0.1:22
[2023-09-10T09:57:46Z WARN  lightkeeper::module::connection::ssh] Password is not set, trying authentication with first key found in SSH agent
[2023-09-10T09:57:47Z ERROR lightkeeper::monitor_manager] [example-host] Error from monitor ping: oping::PingError::LibOpingError: İşleme izin verilmedi

image

Improve flatpak/desktop icon

Hi,
square icons are not really nice to see nowadays. I attach a rounded version.
You can easily get it by using ImageMagick:

io github kalaksi Lightkeeper-rounded

$ convert io.github.kalaksi.Lightkeeper-128px.png \
     \( +clone  -alpha extract \
        -draw 'fill black polygon 0,0 0,30 30,0 fill white circle 30,30 30,0' \
        \( +clone -flip \) -compose Multiply -composite \
        \( +clone -flop \) -compose Multiply -composite \
     \) -alpha off -compose CopyOpacity -composite io.github.kalaksi.Lightkeeper-rounded.png

Also remember that only 128x128 icons are required for Flathub apps right now.

Has the code been independently reviewed?

I would love to try out an application like this, but the idea of running it on my machine freaks me out since it would immediately have ssh access to a lot of servers which is insecure for obvious reasons

My point being is that there should be some independent reviews attached to every release/version. Of course everyone could just study the code for themselves but that's just basically too much work.

Also the readme has no explanation whatsoever what access level is required, and how the data is fetched.

Not run v0.7.0

Even though I deleted the ~/.var/app/io.github.kalaksi.Lightkeeper/ directory, it does not work after the update.
Debian 12 Gnome (X11)

flatpak run io.github.kalaksi.Lightkeeper 
[2023-11-04T19:18:08Z INFO  lightkeeper] Lightkeeper starting...
[2023-11-04T19:18:08Z INFO  lightkeeper::module::module_factory] Validating modules
[2023-11-04T19:18:08Z INFO  lightkeeper::module::module_factory] Loaded 30 command modules, 23 monitoring modules and 3 connector modules
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Created new main configuration file /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/config.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Created new host configuration file /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/hosts.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Created new group configuration file /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/groups.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading main configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/config.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading host configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/hosts.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading group configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/groups.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Updated main configuration file /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/config.yml
[2023-11-04T19:18:08Z INFO  lightkeeper] Lightkeeper starting...
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: SendError { .. }', ../src/host_manager.rs:232:24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[2023-11-04T19:18:08Z INFO  lightkeeper::module::module_factory] Validating modules
[2023-11-04T19:18:08Z ERROR lightkeeper::connection_manager] Stopped receiver thread: receiving on a closed channel
[2023-11-04T19:18:08Z INFO  lightkeeper::module::module_factory] Loaded 30 command modules, 23 monitoring modules and 3 connector modules
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading main configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/config.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading host configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/hosts.yml
[2023-11-04T19:18:08Z INFO  lightkeeper::configuration] Reading group configuration from /home/USER_NAME/.var/app/io.github.kalaksi.Lightkeeper/config/groups.yml
[2023-11-04T19:18:08Z WARN  qt.qpa.xcb] could not connect to display 
[2023-11-04T19:18:08Z INFO  qt.qpa.plugin] Could not load the Qt platform plugin "xcb" in "" even though it was found.
[2023-11-04T19:18:08Z ERROR default] This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
    
    Available platform plugins are: eglfs, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

SSH Connection on v0.5.0

[2023-09-17T20:05:13Z WARN  default] Qt: Session management error: Could not open network socket
[2023-09-17T20:05:13Z INFO  lightkeeper::module::connection::ssh] Connected to 127.0.0.1:22
[2023-09-17T20:05:13Z WARN  lightkeeper::module::connection::ssh] Password is not set, trying authentication with first key found in SSH agent
[2023-09-17T20:05:13Z ERROR lightkeeper::connection_manager] [example-host] Error while connecting 127.0.0.1: Error when communicating with SSH agent: [Session(-18)] Username/PublicKey combination invalid
[2023-09-17T20:05:13Z WARN  lightkeeper::monitor_manager] No response messages received for monitor _internal-platform-info-ssh
[2023-09-17T20:05:13Z ERROR lightkeeper::monitor_manager] [example-host] Error from monitor _internal-platform-info-ssh: Error while connecting: Error when communicating with SSH agent: [Session(-18)] Username/PublicKey combination invalid

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.