kajogo777 / duckygrill Goto Github PK

Could you include a README explaining to your fellow developers:

• How to {run, compile, build, test}
• On which platforms does it run. Any bugs with certain USB controllers/hubs? (Known bugs)
• Features list
• Your future plans. If someone would like to contribute, what could he/she work on?
• Perhaps, a YouTube demo as in: https://github.com/guc-cs/Z-Rootkit

It looks from the code that you are trying to implement a finite state machine in order to block or unblock the USB ports. As you are doing it from scratch, the code is a bit unreadable and harder to follow. Perhaps, you could use an explicit state machine library to abstract this behavior in an object-oriented way.

For example: https://github.com/tyarkoni/transitions

Docopt is a nice pythonic way of parsing input parameters in a standard and well-recognized way in the community whilst providing both: a nice docstring as well as a usage string to the users at runtime. Perhaps, it could be a good idea to use docopt instead of the regular opt parser which might be prone to errors due to string manipulation and adds redundancy in your code due to the need to print the usage string again.

See: https://github.com/docopt/docopt

Hi,

Maybe some people would like to use this hack but, are worried about the licensing. Please choose and add an appropriate license to your project.

http://choosealicense.com/