kajacx / wasm-bridge Goto Github PK

The from_js_value procedural macro, used within bindings! does not handle parameterized types

Occurs when a compound type (e.g; record) contains a parameterized type.

The from_js_value derive macro generating FromJsValue does not properly qualify the type, in this example, it uses

Vec<u32>::method which is not valid Rust syntax, rather than <Vec<u32>>::method

To reproduce (wasm32-unknown-unknown):

wasm_bridge::component::bindgen!({ path: "./wit", world: "bindings" });

package host:bindings

interface core {
    record build {
        a: list<u32>,
    }

    foo: func(q: build) -> u64
}

world bindings {
    import core
}

I'd love to help and open a PR to resolve this, are there any other areas I could tackle while I am at it?

Title :)

Chrome up to v114 disallows wasm sync compilation on main thread unless they are less than 4KB. This may lead to wasm-bridge adopted application crash at runtime on Chrome. I think the JS api should still keep these async methods so users could decide if they need them or not.