Code Monkey home page Code Monkey logo

Comments (4)

jeehoonkang avatar jeehoonkang commented on August 28, 2024

ART is a pointer-based data structure, and in my opinion, you cannot avoid unsafe blocks altogether. I'd recommend you avoid unsafe blocks as much as possible, but you don't need to eradicate them.

I'd also recommend you debug your program with CLion or VSCode.

from cs431.

tomtomjhj avatar tomtomjhj commented on August 28, 2024

I believe we should use UnsafeCell<NodeBox<V>> for cursor.child instead of &mut NodeBox<V> to avoid UB.
See https://rust-lang.github.io/rust-clippy/master/index.html#cast_ref_to_mut .

from cs431.

jeehoonkang avatar jeehoonkang commented on August 28, 2024

While it is generally advisable to use UnsafeCell instead of raw pointers, replacing &mut Nodebox<V> with UnsafeCell<NodeBox<V>> is wrong: the former is essentially a pointer, while the latter is essentially a data.

from cs431.

tomtomjhj avatar tomtomjhj commented on August 28, 2024

oh that's right. I guess I mixed this up with something unrelated.

from cs431.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.