Code Monkey home page Code Monkey logo

Comments (15)

Curt-Park avatar Curt-Park commented on September 13, 2024 1

The example doesn't look like a test case.

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024 1

Test case should be as follows:

x = 1.0 # real value
y = 1.0 # real value

assert result == x+y
assert calc.add(x, y) == 2.0

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

Why are the numbers integer values in the example test case?

from practice_collaboration.

whikwon avatar whikwon commented on September 13, 2024

Comment updated # input can be any real number

from practice_collaboration.

whikwon avatar whikwon commented on September 13, 2024

The above example represents code behavior not test case.

from practice_collaboration.

whikwon avatar whikwon commented on September 13, 2024

Test case added

from practice_collaboration.

mch5048 avatar mch5048 commented on September 13, 2024

The example doesn't look like a test case.

modified the example code but not sure about how the test case may look like. please re-check

from practice_collaboration.

mch5048 avatar mch5048 commented on September 13, 2024

Test case should be as follows:

x = 1.0 # real value
y = 1.0 # real value

assert result == x+y
assert calc.add(x, y) == 2.0

reflected comment

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

@mch5048 not yet. please see the input values in the test case

from practice_collaboration.

whikwon avatar whikwon commented on September 13, 2024
x = 1.0
y = 1.0

input values int to float updated

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

Looks good to me. I will make a feature branch for you now.

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

@mch5048 Please add this card on the project board (In progress condition)

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

I have made a feature branch: feat/calculator/add
Let's get started.

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

@mch5048 Please remove the last print line in your test case.

from practice_collaboration.

Curt-Park avatar Curt-Park commented on September 13, 2024

Merged by 413a1ed

from practice_collaboration.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.