Can't replace loader icon without restarting IDE. about intellij-pokemon-progress HOT 6 OPEN

Yeah would love it if someone else takes a look into it to see if it has become possible again! As a hint, the code lives in PokeballLoaderIconReplacer. It's all done by reflection. If I remember correctly, the issue is that the makeFieldNonFinal method had to actually use reflection on the Field class itself, in order to change the modifiers field to be accessible.

Newer versions of IntelliJ use a newer version of Java, which no longer allows you to do that (I believe they prevent reflection on anything in the java.lang package).

from intellij-pokemon-progress.

@HashimotoRyuga I believe this is because of #89, I will be addressing this soon hopefully.

As for the loader icon, I'm going to take another look at it, possibly with newer versions of IDEA it might have become possible again. I'm also not sure how well it plays with the new UI; might also need special handling for that!

If it isn't an easy win (which I suspect it won't be, unfortunately) I'll likely hide the option from the configuration UI in the next release, so it doesn't mislead people.

from intellij-pokemon-progress.

Hi, thanks for the feedback! The mechanism I used for changing the loader icon is super hacky; I won't get into details but Jetbrains definitely didn't intend for it to be replacable. I suspect you're on an older version of IDEA - can you confirm?

The "replace loader icon" checkbox doesn't work at all on newer versions of it, and I should just remove it.

That being said, I'm still surprised you're seeing this behavious, as I never did, however it's probably a moot point by now :)

from intellij-pokemon-progress.

Hey !
So sad to hear this.
I'm indeed on older versions (2021 and 2022).
I was asking this to you because I created a Naruto plugin from yours and was trying to implement some new features on the loader replacement when I saw this bug.
I should have checked what happened in last Idea releases...

I'll try to see if a workaround is possible anyway... and I'll tell you in this thread if I do someday !

Thanks for your reply ;)

from intellij-pokemon-progress.

I update intelij to 2023.3, the progress bars change back to the default

I reinstalled this plugin, progress bars changed,but once I restart Intelij IDEA,bars still changed back to default

from intellij-pokemon-progress.