Code Monkey home page Code Monkey logo

Comments (7)

kagof avatar kagof commented on July 20, 2024 1

Hi @liyiwei979621500,

I recently changed this behaviour with the 2.0.0 release, in order to keep the sprites looking nice instead of becoming blurry as they're scaled down.

That being said, I can understand why this would be desired to keep them at a fixed size.

I can see how I would go about doing this. The sprites might look a bit different than they used to as I'll be scaling them at runtime, but it should be possible to add this as a feature in a 2.1.0 release.

In the mean time, if you want to avoid the larger progress bars, you can disable the Pokémon with larger sprites (which I do realize is a bit of a pain).

from intellij-pokemon-progress.

kagof avatar kagof commented on July 20, 2024 1

Hi @B0BAI, I understand why you don't like the change. I should be able to work on this over the weekend, so hopefully it'll be available early next week.

Also, why not use SVG if you are concerned about blurry images?

I've looked into this quite a bit, and done an extensive amount of testing with it. There's two main issues.

  1. the rendering of SVGs seems to just look worse than the GIFs even when they're unscaled. I'm not really certain why this is, since IntelliJ does use SVGs for a lot of their own icons.
  2. at the end of the day, these are 32x32 pixel art images (or in some cases 64x64) that are trying to be displayed in a 20px high progress bar. Some of the sprites don't take up the full 32px of height, and so they display just fine. But some of them do. If you take a pixel art image that is 32x32 and try to make it smaller than that, you're going to lose information. This is regardless of the format, SVG doesn't help here. Imagine trying to squeeze an SVG into a 1x1px space; it's impossible to do that without losing something in the process, and it's a similar concept here.

I do still actually want to transition this project to using SVGs over GIFs (assuming I figure out the first point) as I think I could do some cool things with them and it would likely reduce the package size of this plugin, but it isn't a silver bullet for this issue unfortunately.

from intellij-pokemon-progress.

bobaikato avatar bobaikato commented on July 20, 2024 1

Thanks @kagof for responding and also considering a fix. Either gif or SVG, I still think you have a fantastic plugin, and I can't wait for the update next week.

from intellij-pokemon-progress.

bobaikato avatar bobaikato commented on July 20, 2024 1

Thanks for the flexibility you put in place. Love it.

from intellij-pokemon-progress.

Liyw979 avatar Liyw979 commented on July 20, 2024 1

Thanks

from intellij-pokemon-progress.

kagof avatar kagof commented on July 20, 2024 1

Thanks both, appreciate the kind words!

from intellij-pokemon-progress.

bobaikato avatar bobaikato commented on July 20, 2024

I uninstall because of this too. The size disparity is unattractive and distracting, too, when working.

Please update us when you have fixed it.

Also, why not use SVG if you are concerned about blurry images?

from intellij-pokemon-progress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.