kaesonho / twitter Goto Github PK

👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

• The model classes look good. I mentioned Mantle already for the Week 1 assignment as an example of another technique that some developers use for mapping JSON to models.
• NSDateFormatters are expensive to instantiate, so you can instantiate it once and use the same one, as long as you're using it from the same thread.
• Header files look good, nice encapsulation.
• Views shouldn't handle navigation. Instead of having a property for the view controller in TwitterTableViewCell, you should have a custom delegate with any view events that you want to fire. The view controller should be the delegate, and there's navigation required, it should handle it.
• Instead of having a public updateUI function, you could just call that method yourself in a custom setter for the tweet property.
• Consider moving properties like getReletiveTime to an Objective-C category on NSDate.
• In general, Auto Layout constraints look good. Generally, you shouldn't set a height constraint for labels, or it'll be too sensitive to the font. You can let the intrinsic content size drive the label height.
• Nice work handling the retweet label by dynamically modifying the constraint. Alternatively, you could have use a stack view to handle this case.

Overall, the other classes look good.