Code Monkey home page Code Monkey logo

music-player-assignment's Introduction

skoove-assignment

Welcome to the music player assignment!

Demo

Screen.Recording.2022-09-05.at.03.07.43.mov

Getting Started

This project uses Expo dev client and configured for iOS.

Rest of the document assumes that you have mobile environment setup ready. React Native Setup Guide

Clone and Install

  git clone https://github.com/kaanoner3/skoove-assignment.git 
  cd skoove-assignment 
  yarn install 
  npx pod-install

Run on iOS

 yarn ios

Run Tests

yarn test

To see the code coverage

yarn test --coverage

Screen Shot 2022-09-05 at 02 45 13

Important pieces

Packaging system

Yarn workspace is being used on the Project as packaging architecture. It helps us to create structure in which we can draw strict lines in terms of responsibilities, so, every team can control its own territory. It's especially important when lots of people starts working on the same codebase. Our music player assignment have 4 different packages (Potentially have 4 different teams).

@skoove/design-system

Responsible for building widely used components like such as button, text, image etc. Also responsible of best UI-best practices and standarts such as theme support. Due to limited time I implemented only spacing module which provide us consistency in margin and paddings.

@skoove/platform

Responsible for vital packages and utilities like http, cache manager, storage, performance tracking, i18n etc. We have http, error handling, screen hocs,redux, and navigation

@skoove/home

Responsbile for listing musics

@skoove/music-player

This part is responsible for music player. Tech: react-native-track-player, slider.

Things to improve on

  • Due to time limitations e2e tests have not been implemented.

  • When we play a song, it continues to play even if we close the music player screen. However, we don't have any control to stop the music on the HomeScreen. This is obviously not desirable. Another thing to add would be extending the app functionality to control the music on HomeScreen.

  • react-native-track-player supports background event listeners but the current implementation does not use it. Implementing these listeners would provide the users a better control over the music player.

  • There are some unhandled rejections throwed from TrackPlayer. Displaying the alert banners would improve the user experience.

music-player-assignment's People

Contributors

kaanoner3 avatar

Stargazers

Mustafa Gilli avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.