Code Monkey home page Code Monkey logo

Comments (4)

somaritane avatar somaritane commented on May 28, 2024 2

@ytsarev @kuritka As I was trying upgrade to v0.16.0, the idea to opt out from vendoring came to my mind too :)
The work is in https://github.com/AbsaOSS/ohmyglb/tree/upgrade-operator-sdk-v0.16.0 branch, PR is coming soon...

from k8gb.

kuritka avatar kuritka commented on May 28, 2024

In package dependency tree you can find github.com/openshift/api v3.9.1 but github.com/openshift/api is no longer tagged. After cleaning package cache go clean -modcache && make build you obtain something like this github.com/openshift/[email protected]+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found

You can bypass error by downloading newest operator framework and running go mod download to populate go cache or upgrading GSLB to newer version

from k8gb.

ytsarev avatar ytsarev commented on May 28, 2024

@somaritane @kuritka maybe we should deprecate /vendor completely as part of the upgrade

from k8gb.

kuritka avatar kuritka commented on May 28, 2024

@somaritane @ytsarev - Hi deprecating /vendor is step right way.

module versions are kept within go.mod and modules are physically in src/pkg/mod/.... Regarding pipeline \vendor folder is skipping anyway because go build . in Go 1.13 reads modules from src/pkg/mod/... (viz demo below). Also package verification (go mod verify) is impossible on vendoring folders (plan is go 1.15). /vendor is fine when your build server cannot download from internet etc..

viz demo:

## <= go 1.13

go mod edit -go 1.13

go run -mod=vendor ./main.go
# HELLO FROM VENDOR

go run ./main.go
# Hello from /src/pkg/mod/github.com/kuritka/gext

## <= go 1.14

go mod edit -go 1.14

go run  ./main.go
# HELLO FROM VENDOR

Also we should consider upgrading Go to 1.14

from k8gb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.