inViewportAction seems to run outside of NgZone about ng-in-viewport HOT 6 CLOSED

I think that it would be not optimal to run changes detection whenever something changes it's visibility. Especially when you have many elements that are tracked. So to have best performance I think that change detection should be run based of a results from inViewportAction and then inside it user of library would call ChangeDetectorRef.detectChanges(); when needed as explicit task.

from ng-in-viewport.

I'm not an expert in NgZone and change detection. I assumed based on issue #176, that it was the intention for the loadOnIntersection event to emit inside Zone. It seemed to me that the behavior now is what the poster in issue #176 was asking for as an option. But I could definitely be misunderstanding this.

My use case isn't about change detection, but about dispatching an action to NGRX inside of NgZone, as described here: https://ngrx.io/guide/store/configuration/runtime-checks#strictactionwithinngzone.

I can always fix this at my end by calling dispatch inside of ngZone.run, but I reported this here because it seemed like there was a significant change between version 13 and 15, and that it might be a breaking change for those relying on the previous behavior. It may well be that there is no change, and I am misunderstanding it. It may also be that there is a change, and it is a good one for performance.

from ng-in-viewport.

@all-contributors please add @karptonite for bug

from ng-in-viewport.

@k3nsei

I've put up a pull request to add @karptonite! 🎉

from ng-in-viewport.

Thanks! As I mentioned, this might be a negative for performance, and it might be better to either ask people to handle the events with NgZone themselves, or add an option to take it out of NgZone, as requested in #176. I'm not sure, honestly, but this should restore the previous behavior for my use case, anyway!

from ng-in-viewport.

The library should not expect Angular users to use advanced strategies and should work with the framework's defaults. It was also a nice way of testing automatic releasing.

from ng-in-viewport.