Error when several instances with different root configurations about ng-in-viewport HOT 8 CLOSED

@Jonnyprof could you tell more about your environment? Because I don't see a way how isPlatformBrowser would return false in any browser? this in function which isn't an instance and isn't bound function should always return Window instance.

And can you prepare some example on stackblitz by forking this project https://stackblitz.com/edit/ng-in-viewport-example?embed=1&file=src/main.ts

from ng-in-viewport.

Sorry, I didn't notice your reply.
I don't understand your question, sorry for my english. It happens with angular dev-server (ng serve) or in a web server with production build.
I've created a fork of your stackblitz where you can see (debugging or adding a logPoint) that your function isPlatformBrowser is false. You can see it here https://stackblitz.com/edit/ng-in-viewport-example-6cpco8.
I've attached a screenshot too.

I'm logging config.hash console.log('hash:', config.hash, 'rootMargin:', config.rootMargin); and it returns always false in a webserver environment but not in stackblitz because there global is defined. global is undefined normally in a browser environment. I've attached a screenshot.

You can download the stackblitz code and run it on a webserver and hash will be always false.
I've done more tests in a fork of your repository (https://github.com/Jonnyprof/ng-in-viewport/tree/hash-false) on branch hash-false and hash is always false (console.log too).

I hope this help.

from ng-in-viewport.

I will switch to btoa as now node.js lts have that function in its global scope.

from ng-in-viewport.

@all-contributors please add @Jonnyprof for bug

from ng-in-viewport.

@k3nsei

I've put up a pull request to add @Jonnyprof! 🎉

from ng-in-viewport.

Should be fixed in v15.0.0

from ng-in-viewport.

Great, thanks! Tell me if you need some testing help.

from ng-in-viewport.

@Jonnyprof You can install it and test if it works for you. As it was complete rewrite of library, it's now have 100% coverage. But unit tests are not real world scenarios. So it would be beneficial to see if it works in real app.

from ng-in-viewport.