juullabs-oss / cbgo Goto Github PK

Hello!

Thanks for the great library!

While 32bit UUIDs aren't super common, they are out there; as-is, cbgo will panic if one's discovered https://github.com/JuulLabs-OSS/cbgo/blob/master/core.go#L104, so simply being in an environment where a 32bit UUID device is powered on will break anything using this library.

I've proposed a patch #3 to address this; it simply "upscales" a 32bit UUID to a 128bit UUID by appending the 128bit base UUID. It's tested locally and working; in fact, I'm using it to connect to a device broadcasting a 32bit UUID.

I wasn't sure how you might want this structured, so I figured I'd keep it dumb simple.

Cheers,

Garrett

I was trying to call the DiscoverServices() in order to retrieve only a specific list of services based on the UUIDs. However, it was consistently refusing to return any results.

This is the code that I was attempting to use:

	cbuuids := []cbgo.UUID{}
	for _, u := range uuids {
		uuid, _ := cbgo.ParseUUID(u.String())
		cbuuids = append(cbuuids, uuid)
	}

	d.prph.DiscoverServices(cbuuids)

If I pass an empty slice it returns all services as expected. However, when I try to use a slice of UUID strings, it does not return any results.

Please see tinygo-org/bluetooth#50

Hey,

I'm trying to connect to a device using the example program. Connection works good but I don't retrieve any services nor characteristic. I'll get the correct list of services and characteristics with for example https://github.com/jnross/Bluetility

Any idea on what can be the problem?

/Erik