justwhit3 / arsenalgear-cpp Goto Github PK

I'm interested in checking out osmanip and so I need arsenalgear-cpp due to a dependency.

My daily driver is OpenBSD 7.1... which isn't supported by your Makefile. After hacking up your Makefile to add support for OpenBSD, I was able to compile arsenalgear-cpp with clang and gmake. The tests appear to pass.

$ bin/tests
[doctest] doctest version is "2.4.9"
[doctest] run with "--help" for options
Test================================================================================
[doctest] test cases: 21 | 21 passed | 0 failed | 0 skipped
[doctest] assertions: 59 | 59 passed | 0 failed | 
[doctest] Status: SUCCESS!

While I understand there's a certain appeal to the simplicity of Makefiles, I myself used them for my thesis project some 20 years ago until I discovered scons, they're almost always a bad idea IMHO.

You would do well to consider adopting tools to generate your build files, e.g.:

• CMake
• Meson Build

CMake is basically the de facto standard for C++ projects (unfortunately). I personally prefer meson, but I've never used it on Windows so I'm not sure how it fairs on that OS.

The power of generating the build scripts is that it allows developers to generate the build for their preferred environment / toolchain.

Let me know if you have any interest in meson, I'd be happy to put together a branch using it so you could check it out.

NULL is implementation defined. This means every compiler is free to choose how the macro expands. IMHO, you should try to avoid implementation defined behavior as they don't have the best portability, and may change between compilers or even different versions of the same compiler.

Most compilers since C++11 expand NULL to nullptr which is a nullptr_t type and cannot be assigned to non-pointer types; i.e., use of int max = NULL; is an error.

error: cannot initialize a variable of type 'int' with an rvalue of type 'nullptr_t'
    int max = NULL;
        ^     ~~~~

Check out cppreference article on NULL for information about the changes to NULL.

That said, it looks like you should be using 0 in most of this code b/c you're assigning NULL to integer/floating point types, which is an compile-time error on compilers expanding NULL to nullptr.

Describe the bug
Assigning NULL to non-pointer types.
Assigning nullptr to non-pointer types.

Fix
Without refactoring the code, worked around the problem by changing uses of NULL to 0 and nullptr to 0.

Environment

• OS: OpenBSD
• Version: 7.1
• Clang: OpenBSD clang version 13.0.0