justinlettau / react-undraw Goto Github PK

Type

What kind of issue is this?

[x] Bug report.
[ ] Feature request.

Current Behavior

Can't execute react-undraw-cli

I have manually write path to .bin folder

Steps to Reproduce

Install current version using yarn on Debian OS

Would be really great to be able to put the undraw folder anywhere out of root, and set a custom path to it

Type

What kind of issue is this?

[x] Bug report.
[ ] Feature request.

Current Behavior

The react-undraw-cli throw this:

(node:5996) UnhandledPromiseRejectionWarning: Error: Command failed: tsc -p ./tsconfig.json
(node:7172) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

Catching that error and logging it, the correct error was:

src/undraw/Undraw.test.tsx(2,22): error TS7016: Could not find a declaration file for module 'react-dom'. '<myproject>/node_modules/react-dom/index.js' implicitly has an 'any' type.\r\n Try npm install @types/react-dom if it exists or add a new declaration (.d.ts) file containing declare module \'react-dom\';\r\nsrc/undraw/Undraw.test.tsx(6,1): error TS2582: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try npm i @types/jest or npm i @types/mocha.

Expected behavior

At this point, it should generate the components,

Steps to Reproduce

• mkdir react-undraw-issue
• cd react-undraw-issue
• npm i [email protected] (the error appears here too)
• add "undraw": "react-undraw-cli", in scripts of package.json
• npm run undraw

Other Information

After installing those @types/... in _phantomChildren field of package.json of your project, it creates the components as should.
EDIT: idk any more what I did to make it work

Hello,

Type

What kind of issue is this?

[ ] Bug report.
[x] Feature request.

I'd like to apply extra styles to the svg illustration but there is no way to pass a className or style prop.

Is it possible to add them?

Type

What kind of issue is this?

• Bug report.
• Feature request.

Current Behavior

When using an SVG downloaded with a different color besides the default unDraw color (#6C63FF), the primaryColor prop doesn't work.

Expected behavior

The primaryColor prop should replace whatever color was in the original SVG file.

Steps to Reproduce

• Change the color on unDraw before downloading
• Place in the /undraw folder
• Run npm install and npm build
• Insert the Undraw component and add a primaryColor prop

Other Information

It looks like the problem is in build.js where it replaces the SVG attributes based on the default unDraw hex code. Haven't looked into this yet but a possible fix could be first finding the hex code that is in the same location as the default hex code, then using that in replaceAttrValues.

Hello,

is there a way to directly require each illustration?

I think using the <Undraw name="coding" /> approach will include all the illustrations in the bundle with no tree shaking?

Type

What kind of issue is this?

• Bug report.
• Feature request.

Current Behavior

Currently, only an es6 bundle is exported. Would be nice if there could also be a non es6 bundle that would play nicer when using this in environments that are not ready for es6 without having to compile this specific module.

BUG

[x] Bug report.
[] Feature request.

Current Behavior

I Downloaded the svg file from undraw repo website, created a folder called undraw in the project root, renamed the svg to remove the suffix, prefix, and tried to render the svg with

 <Undraw
   name="signin"
 />

i've put the "react-undraw-cli" in start and build scripts.
The svg is not rendering., nothing happens.

Expected behavior

SVG being rendered.

Steps to Reproduce

• Download the SVG that i've tried from Undraw
• Create a folder inside the project root called undraw, and paste the file in there.
• Try to render it with the undraw component.

Other Information

One fact is that i've tried to run yarn react-undraw-cli, but it seems that the cli command is not working.

• React version: 16.13.1
• Using typescript 3.7.2

The project structure:

Pieces of code:

• The component that i've trying to render the undraw svg

const Signin: React.FC = () => {
    return (
        <div>
            <Undraw
                name="test"
            />
        </div>
    );
}

• My Scripts:

  "scripts": {
    "start": "react-scripts start && react-undraw-cli",
    "build": "react-scripts build && react-undraw-cli",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
    "prebuild": "react-undraw-cli"
  },

The repo is actually public, that's an open source project, you can also check there if want to.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency husky to v8
• chore(deps): update react monorepo to v18 (major) (react, react-dom)
• fix(deps): update dependency @types/node to v18
• fix(deps): update dependency @types/react to v18
• fix(deps): update dependency @types/react-dom to v18
• fix(deps): update dependency del to v7
• fix(deps): update dependency glob to v8
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency ajv to 6.12.3 [security]
• chore(deps): update dependency ansi-regex [security]
• chore(deps): update dependency glob-parent to 5.1.2 [security]
• chore(deps): update dependency jsdom to 16.5.0 [security]
• chore(deps): update dependency minimatch to 3.0.5 [security]
• chore(deps): update dependency minimist [security]
• chore(deps): update dependency semver-regex to 3.1.4 [security]
• chore(deps): update dependency trim-off-newlines to 1.0.3 [security]
• chore(deps): update dependency yargs-parser to 13.1.2 [security]
• chore(deps): update dependency standard-version to v9
• fix(deps): update dependency @svgr/core to v6
• fix(deps): update dependency @svgr/plugin-jsx to v6
• fix(deps): update dependency @svgr/plugin-prettier to v6
• fix(deps): update dependency @svgr/plugin-svgo to v6
• fix(deps): update dependency fs-extra to v10
• fix(deps): update jest monorepo to v29 (major) (@types/jest, jest, ts-jest)
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency dot-prop to 4.2.1 [security]
• chore(deps): update dependency handlebars to 4.7.7 [security]
• chore(deps): update dependency hosted-git-info to 2.8.9 [security]
• chore(deps): update dependency ini to 1.3.6 [security]
• chore(deps): update dependency json-schema to 0.4.0 [security]
• chore(deps): update dependency lodash to 4.17.21 [security]
• chore(deps): update dependency merge-deep to 3.0.3 [security]
• chore(deps): update dependency node-notifier to 8.0.1 [security]
• chore(deps): update dependency nth-check to 2.0.1 [security]
• chore(deps): update dependency path-parse to 1.0.7 [security]
• chore(deps): update dependency standard-version to 8.0.1 [security]
• chore(deps): update dependency tmpl to 1.0.5 [security]
• chore(deps): update dependency trim-newlines to 3.0.1 [security]
• chore(deps): update dependency ws to 7.4.6 [security]
• chore(deps): update dependency y18n to 4.0.1 [security]
• chore(deps): update dependency pretty-quick to v3
• chore(deps): update dependency tslint-react to v5
• chore(deps): update dependency typescript to v4

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Type

What kind of issue is this?

[x] Bug report.
[ ] Feature request.

Current Behavior

Added import Undraw from 'react-undraw' to a page and i get the error.

Expected behavior

Module error should not occur given that react-undraw is on package.json.

Steps to Reproduce

npm install react-undraw