Code Monkey home page Code Monkey logo

dm-challenge's People

Contributors

justinhennessy avatar tvanderpol avatar

Watchers

 avatar  avatar  avatar

dm-challenge's Issues

Some small considerations re. your tests

As a general rule when using time in tests, get a reference timestamp (like Time.now or really anything) at the start of the test, and use it throughout. You do it in the tests by having end_date be defined from start_date but I change it below to be explicit.

On https://github.com/justinhennessy/dm-challenge/blob/master/spec/features/dashboard_spec.rb#L14 , current_date is a local and as far as I can see is not being used, you should be able to delete it.

https://github.com/thoughtbot/factory_girl_rails would help to clean up your tests if you use it. Specifically, between the two suggestions the first test would look like this:

  it "shows the number of days until the challenge starts" do
    now = Time.now

    challenge = FactoryGirl.create :challenge, start_date: now + 6.days, end_date: start_date + 31.days

    visit "/dashboard"

    expect(page).to have_text("5 days to start!")
  end

README

This is one of my biggest pet peeves - a repository without a decent README (in your case you have 2 of them lol, delete the .rdoc one).

Lucky for you smarter people than I have recently written on the topic. In my opinion I've done a good job on the fundraiser README.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.