The poisjuoksu from juliusikkala

poisjuoksu's People

Contributors

Watchers

poisjuoksu's Issues

Casual code review on behalf of COMP.530 Bare Metal Rust 2020-2021 at TUNI

Works on my machine!
Use of lifetime constrained types seems smart.
Adding a file "rust-toolchain" with content "nightly" at project root could reduce work with setup.
Same for using the sdl2 feature "bundled".
You might want to try out cargo clippy (https://github.com/rust-lang/rust-clippy).
There's a considerable amount of raw math. You might consider using something like Embedded Graphics or just nalgebra. Possibly contributing what they're missing.

poisjuoksu/src/lib.rs

Lines 266 to 267 in 6643b88

    
           let road_begin = road_left.max(line.begin as i32).min(line.end as i32); 
        
           let road_end = road_right.max(line.begin as i32).min(line.end as i32);

.max(_).min(_) -> .clamp(_)

poisjuoksu/src/lib.rs

Lines 151 to 155 in 6643b88

    
           x_offset: &mut i32, // FP1 
        
           y_offset: &mut i32, // FP1 
        
           z_offset: &mut i32, // FP1 
        
           x_slope: &mut i32,  // FP1 
        
           y_slope: &mut i32,  // FP1

The compiler's usually smart about this sort of stuff but perhaps you benchmarked it and figured this is optimal despite the inergonomicness. As also hinted by the comment FP1 :)

Related: criterion, #[bench] & native bench.

Some primitives could be combined for brevity, e.g. x: i32, y: i32 -> co: Co with basic operation implementations or some such. Even better if you can use existing implementations.