julianpoemp / oc-backup Goto Github PK

``In this part of the code (the echo is something I inserted), it appears to be trying to exclude warning errors from mysqldump, but it's indicating that the dump experienced an error.

 if [ "${#stderr}" -gt 0 ]; then
    echo "mysqldump error: ${stderr}"
    if ! [[ "${stderr}" =~ ^mysqldump:[[:space:]]\[Warning\] ]]; then
      log "Error: SQL backup failed."
      log "_${stderr}_"
      errors_found=$((errors_found + 1))
    fi
  fi

Here is the logging output:

root@conf:/var/www/owncloud# ./oc_backup.sh
* 2023-02-15_14-52-45 | Start oc-backup v1.0.2...
* 2023-02-15_14-52-45 | -> Backup owncloud configuration file...
* 2023-02-15_14-52-45 | -> Read owncloud configuration file...
* 2023-02-15_14-52-45 | -> Enable maintenance mode...
* 2023-02-15_14-52-45 | -> Create backup folder
* 2023-02-15_14-52-45 | -> Create database backup...
* 2023-02-15_14-52-46 | mysqldump: [Warning] Using a password on the command line interface can be insecure.
mysqldump error: mysqldump: [Warning] Using a password on the command line interface can be insecure.
* 2023-02-15_14-52-46 | Error: SQL backup failed.
* 2023-02-15_14-52-46 | _mysqldump: [Warning] Using a password on the command line interface can be insecure._
* 2023-02-15_14-52-46 | -> Create zip archive of owncloud files...

Am I missing something, here?

Hello Julian and thx for you work.

I had a problem with the script. It didnt turn off the maintenance mode.
Is there really the need for escaping?

`enable_maintenance_mode() {
log "-> Enable maintenance mode..."
configFile="${configFile//\'maintenance\' => false/\'maintenance\' => true}"
echo "${configFile}" > "${configPath}"
}

disable_maintenance_mode() {
log "-> Disbale maintenance mode..."
configFile="${configFile//\'maintenance\' => true/\'maintenance\' => false}"
echo "${configFile}" > "${configPath}"
}`

My Installation (Debian on a Raspberry) only works without:

`enable_maintenance_mode() {
log "-> Enable maintenance mode..."
configFile="${configFile//'maintenance' => false/'maintenance' => true}"
echo "${configFile}" > "${configPath}"
}

disable_maintenance_mode() {
log "-> Disbale maintenance mode..."
configFile="${configFile//'maintenance' => true/'maintenance' => false}"
echo "${configFile}" > "${configPath}"
}`

• Check all required and optional constants at startup
• Add argument for config-path
• Add argument for help
• Improve error handling
• Append log file next to the backup
• If OC_DATA path is empty, data folder is in owncloud folder and no additional backup needed
• Add explanation of how to add a cronjob