julialang / bumpstdlibs.jl Goto Github PK

It'd be nice to be able to look at the stdlib repo and see at a glance where julia master is.
Perhaps this bot could handle that?

Some ideas:

• Post a comment on the commit via sha, when the PR is merged, so the comments can be seen in the github commit history view
• A markdown badge? This bot could update the badge?

I guess one problem is that it'd need updating on merge, not on creation of the PR, which this bot is currently limited to

Also, the above would break if it's bumped manually, not by this bot

It would be nice if this would group stdlib updates and create a single PR for each batch, in case there are dependencies between the updates (e.g. JuliaLang/julia#38808).

But here's another thought: what if this always pushed to the same branch? Hear me out. If you push to a branch that already has an open PR, then it just updates that PR. Which is fine since if someone updates a bump PR when an older one is already open, we want to close the old one anyway; why not just update it instead? What happens if you push to a PR branch after that PR has been merged? Works just fine and you can create a new PR from the same branch. This would enforce that there is at most one stdlib bump PR at a time.

One tweak that would be needed with that approach is that you'd want stdlib bumps to be done relative to what's already in that branch: i.e. if an old bump updates a stdlib and you trigger a new bump that doesn't include that stdlib, you don't want to accidentally roll it back to what's on master since someone else asked for it to be bumped already. Perhaps the logic could be this: if there's no open bump PR (i.e. the branch doesn't exist or the PR's been closed), then a new bump starts from the master state of stdlibs; if there's an open bump PR, then a new bump starts from there, re-bumping what's requested.

Currently, if you re-run the workflow, it will force-push to all of the existing PR branches.

As a result, every time you re-run the workflow, it restarts Base Julia CI on all of the existing PRs, even if there wasn't actually any change.

Instead, if the PR exists and is open, and if we don't have any changes to make to the existing PR branch, we shouldn't force-push to the existing PR branch.

See for example JuliaPackaging/Yggdrasil#6095 (comment). I think these links are more useful than printing the title of commits (which are still useful for future reference in the git commit message), people can more easily see the actual code.

Personally, I think that BumpStdlibs.jl is working pretty well. But it only has the ability to update stdlibs.

It might be useful to also have a bot that does the other external dependencies that we have in Julia that aren't stdlibs.

JuliaLang/julia#42474

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Cloning into 'STDLIB'...
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

E.g. https://github.com/JuliaLang/BumpStdlibs.jl/actions/runs/1412783247

I don't believe this is currently possible @DilumAluthge ?

E.g.

DilumAluthgeBot changed the title 🤖 Bump the Downloads stdlib from 98922d7 to 2f0d46f 🤖 Bump the Downloads stdlib from 98922d7 to 2f0d46f 17 minutes ago

This shouldn't have been closed given it targets master JuliaLang/julia#48091 (comment)