Error in Test Case about imagefeatures.jl HOT 10 CLOSED

Sometimes you do have to change the test values when algorithms update. In JuliaImages/Images.jl#596 I found a test that essentially "froze in" the exact behavior of the algorithm we'd had before, rather than more broadly testing "sensible behavior." The tricky part is that sometimes it's pretty hard to define "sensible."

@annimesh2809, I'd say begin by commenting out failing tests and then we can discuss.

from imagefeatures.jl.

The most expedient approach is to call parent on the OffsetArray; that will return a conventionally-indexed array. In the longer run, non-1 indices allow you to express filtering operations easily with clearer intent; there's a WIP blog post here.

from imagefeatures.jl.

Are there other test failures too?

from imagefeatures.jl.

@mronian Sorry I did not see your comment so didn't reply sooner.

I have fixed some warnings and I have printed the value returned by the algorithm and the expected value of a test case.

The failing test case is at line 55 of /test/brief.jl.
What to do with this test case?

from imagefeatures.jl.

Its a very simple test case which is already covered by the ones after it in the Descriptor Calculation part. You can comment it out for now. I'll submit a modification.

from imagefeatures.jl.

Another failing test on line 253 and 259 of file /test/lbp.jl. Both the results of "Descriptor" are different from expected value. Here is a screenshot of the test failure and the returned vs expected value:

from imagefeatures.jl.

Initial tests in test/corner.jl call the corner_orientations(img::AbstractArray) function from line 49, ImageFeatures/src/corner.jl. Here the function Kernel.gaussian (previously gaussian2d) is called from line 134, ImageFiltering/src/kernel.jl which calls KernelFactors.gaussian from line 269, ImageFiltering/kernelfactors.jl and returns an object of type OffsetArray by a call to centered from line 14, ImageFiltering/src/utils.jl. The problem arises due to the fact that the function
corner_orientations(img::AbstractArray{T, 2}, corners::Keypoints, kernel::Array{K, 2})
(Line 16, ImageFeatures/src/corner.jl) which is called after creating the kernel by the above process must have kernel of type Array{K,2} but the kernel is of type OffsetArray. Hence a MethodError occurs:

Should I write a function to convert the OffsetArray to Array{K,2} in corner_orientations or should I write another version of centered function to return an Array instead of OffsetArray? Please suggest.

from imagefeatures.jl.

All warnings have been removed. Only 4 failing test cases remain. 😄

from imagefeatures.jl.

Only 2 test case failures remain which are present in LBP as mentioned in #24 (comment). These tests cannot be removed as it can lead to decrease in coverage. Kindly suggest what to do.

from imagefeatures.jl.

I commented out the 2 failing test cases and then tried doing a coverage test but travis failed stating that some tests were taking too much time. Indeed the tests for "orb.jl" were taking too much time (> 30 mins) so I commented that too and got a coverage of about 88%, with all orb.jl tests and some lbp.jl tests turned off.
https://coveralls.io/github/annimesh2809/ImageFeatures.jl

Should I remove the "Descriptor" tests of lbp that are failing for now?

from imagefeatures.jl.