Code Monkey home page Code Monkey logo

Comments (7)

Evizero avatar Evizero commented on July 4, 2024 1

With the 0.7 fixes you would also bump the minimum julia version in REQUIRE to 0.7 and then tag.
As a consequence every 0.6 user who Pkg.add this package would only install the latest version that supported 0.6 in its REQUIRE, while everyone on 0.7 and later would install the newer version

from imagefeatures.jl.

timholy avatar timholy commented on July 4, 2024

At the moment my priorities are ImageView and Interpolations. I am sure someone will get to it, but that someone could be you! If you want to give it a whirl, I recommend installing Julia 0.7 since you'll get deprecation warnings that will tell you how to change the code.

from imagefeatures.jl.

gzhang8 avatar gzhang8 commented on July 4, 2024

This is error is due to x * cos(t) + y * sin(t) = r https://github.com/JuliaImages/ImageFeatures.jl/blob/master/src/houghtransform.jl#L10

What is the reason that * needs to be escaped? What is the new way to escape?

from imagefeatures.jl.

zygmuntszpak avatar zygmuntszpak commented on July 4, 2024

@timholy Could you please clarify how we should proceed with the 1.0 upgrade? Do we just merge the required fixed with the master branch and then tag a release? Anyone who wants to use 0.6.4 would then need to checkout the previous version?

(I didn't mean to close the issue...accidental misclick)

from imagefeatures.jl.

timholy avatar timholy commented on July 4, 2024

General procedure:

  • open a pull request where you just set REQUIRE to have julia 0.7 as a minimum requirement
  • wait for femtocleaner to submit a pull request that fixes the "obvious" issues. If it looks good merge to your branch
  • fix remaining errors and deprecations from building the package and/or running the tests
  • if needed include at least versions 0.7, 1.0, and nightly in the .travis.yml and/or appveyor.yml tests
  • once tests pass, merge to master
  • tag a new release bumping the minor version

However, I see that a couple of PRs have been submitted while I was out. If there is anything any of the folks with commit access can do to check those over and see if they are mergeable (or close to it), that would be a huge help. It would be nice to get that done before starting on the 0.7 upgrade, so that people's work isn't left out in the cold. (This is only applicable if the PRs are close to being mergeable.)

from imagefeatures.jl.

timholy avatar timholy commented on July 4, 2024

Oh, I see @gzhang8 has already been working on this! 👍 Well, we can always migrate people's PRs for them, so don't let me stand in the way of progress 😄.

from imagefeatures.jl.

gzhang8 avatar gzhang8 commented on July 4, 2024

#56

from imagefeatures.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.