jukkahell / nestlogger Goto Github PK

I found that warning, when i run npm audit command!
Does is critical?

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High │ Incorrect Comparison in axios │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ axios │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.21.2 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ nest-logger │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ nest-logger > @nestjs/common > axios │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ GHSA-cph5-m8f7-6c5x │
└───────────────┴──────────────────────────────────────────────────────────────┘

Currently logging Map entries prints only {}. Should print key-value-pairs.

I just tried to extend your module with a level option for transports, which winston apparently supports.

Quickly found out that neither console nor rotate actually pass the supplied options to winston's transport constructors.

In case of console it's just empty:

public static console(options?: LoggerOptions): ConfiguredTransport {
...
    const transport = new winston.transports.Console();
...
}

In case of rotate some explicitly specified options are passed, the rest is discarded?

  public static rotate(options?: LoggerOptions): ConfiguredTransport {
    const defaultOptions = Object.assign({}, LoggerService.DEFAULT_LOGGER_OPTIONS);
    const fileLoggerOptions = Object.assign(defaultOptions, options);
    const transport = new DailyRotateFile({
...
      maxFiles: fileLoggerOptions.maxFiles,
      options: { flags: "a", mode: "0776" },
    });
    return { transport, options: fileLoggerOptions };
  }

Is there something I'm missing? For example, shouldn't console look something like the following?

  public static console(options?: LoggerOptions): ConfiguredTransport {
    const defaultOptions = Object.assign({}, LoggerService.DEFAULT_LOGGER_OPTIONS);
    const consoleLoggerOptions = Object.assign(defaultOptions, options);
    const transport = new winston.transports.Console(consoleLoggerOptions);
    return { transport, options: consoleLoggerOptions };
  }

Hi,
Thanks for this great library.
I hope if I can use LoggerService as an Interceptor for logging incoming Http Requests. Is there any built-in functionality for that purpose?
something like morgan

Hi!

Noticed that the log file is also prints the color in the format.

Just want to ask if there's a way to configure the transports to colorized in the transport console but not in transport file?

Thanks!

Hi,
is there a way to add multiple log levels to a single logger? something like this:
const logger = new LoggerService( 'info error warning', loggers, );

export class SecurityService {
  constructor(
    private readonly logger: LoggerService
  ) {
    this.logger.setContext(`SecurityService`);
  }
}

export class SecurityService1 {
  constructor(
    private readonly logger: LoggerService
  ) {
    this.logger.setContext(`SecurityService1`);
  }
}

it alway get context is SecurityService

Hi Can you please add an example how to import the LoggerService in any controller or service ?