juftin / lunchable Goto Github PK

• lunchable version: 1.0.0
• Python version: 3.10
• Operating System: Debian GNU/Linux 12

Description:

I'm getting
{"name":"SyntaxError","message":"Unexpected token \'t\', \\"transactio\\"... is not valid JSON"}
when trying to create a transaction, this is what I do:

211 B->	            result = self.lunch_money.insert_transactions(
212  	                transactions=transaction_insert,
213  	                apply_rules=True,
214  	                skip_duplicates=False,
215  	                debit_as_negative=ScotiabankCreditCard._debit_as_negative(transaction),
216  	                skip_balance_update=False,
217  	            )
(Pdb) transaction_insert
TransactionInsertObject(date=datetime.date(2023, 11, 17), amount=9585.0, category_id=None, payee='', currency='crc', asset_id=12345, recurring_id=None, notes='some notes', status=None, external_id='some-id-123', tags=None)
(Pdb) ScotiabankCreditCard._debit_as_negative(transaction)
False

This is what happens:

319  	        response = self.request(
320  	            method=method,
321  	            url=url,
322  	            params=json_safe_params,
323  	            data=json_safe_payload,
324  	            **kwargs,
325  	        )
326 B->	        data = self.process_response(response=response)
327  	        return data
(Pdb) method
'POST'
(Pdb) url
'https://dev.lunchmoney.app/v1/transactions'
(Pdb) json_safe_params
(Pdb) json_safe_payload
{'transactions': [{'date': '2023-11-17', 'amount': 9585.0, 'payee': '', 'currency': 'crc', 'asset_id': 12345, 'notes': 'some notes', 'external_id': 'some-id-123'}], 'apply_rules': True, 'skip_duplicates': False, 'check_for_recurring': False, 'debit_as_negative': False, 'skip_balance_update': False}
(Pdb) pp kwargs
{}
(Pdb) n
Client error '400 Bad Request' for url 'https://dev.lunchmoney.app/v1/transactions'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400
Traceback (most recent call last):
  File "/home/__/.cache/pypoetry/virtualenvs/lunchcr-UnUZhfHU-py3.10/lib/python3.10/site-packages/lunchable/models/_core.py", line 263, in process_response
    response.raise_for_status()
  File "/home/__/.cache/pypoetry/virtualenvs/lunchcr-UnUZhfHU-py3.10/lib/python3.10/site-packages/httpx/_models.py", line 758, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Client error '400 Bad Request' for url 'https://dev.lunchmoney.app/v1/transactions'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400
{"name":"SyntaxError","message":"Unexpected token 't', \"transactio\"... is not valid JSON"}
lunchable.exceptions.LunchMoneyHTTPError: {"name":"SyntaxError","message":"Unexpected token 't', \"transactio\"... is not valid JSON"}
> /home/__/.cache/pypoetry/virtualenvs/lunchcr-UnUZhfHU-py3.10/lib/python3.10/site-packages/lunchable/models/_core.py(326)make_request()
-> data = self.process_response(response=response)
(Pdb) response.content
b'{"name":"SyntaxError","message":"Unexpected token \'t\', \\"transactio\\"... is not valid JSON"}'
(Pdb) response.status_code
400

• Python version: conda 3.9
• Operating System: Mac zsh

Description

I'm interested in using your library as I migrate some of the projects I've created based on Mint to LunchMoney.

I use conda instead of pip for my python virtual environments.

Could you publish your package to conda-forge as well? This document describes why and how: https://www.pyopensci.org/python-package-guide/package-structure-code/publish-python-package-pypi-conda.html

With your permission I could fork and publish, but I think the ideal would be for you to publish so the packages stay in sync.

• lunchable version: 0.9.0
• Python version: 3.11

Description

Lunchmoney API (/v1/categories/group/{category_id}/add in this case) sometimes seems to send back some escaped characters (eg. / instead of /), which results in pydantic max_length validations to sometimes fail as string length is not counted correctly.

Imo this is probably a bug on the lunchmoney API side though

What I Did

1. Create a new category that is of 40 characters long and add it to a category group
2. Add a new category in same category group with insert_into_category_group method
3. Error will be raised as the children[] will fail instantiation due to having a length > 40 characters.

Replace nasty old sphinx with mkdocs

There was an update on the lunchmoney docs that's uncovered: lunch-money/developers@ad87916

The latest docs changes should be present in lunchable. CI/CD to periodically check for detect unknown fields might be useful too - this would be an integration test with access to real data.

OAuth2 is coming

• lunchable version: 1.1.1
• Python version: 3.8.18
• Operating System: Windows 11

Description

Describe what you were trying to get done.
Trying to execute the lunch.get_assets command

Tell us what happened, what went wrong, and what you expected to happen.

Received an error shown below:

ValidationError: 1 validation error for AssetsObject
balance_as_of
Input should be a valid datetime [type=datetime_type, input_value=None, input_type=NoneType]
For further information visit https://errors.pydantic.dev/2.5/v/datetime_type

It appears the issue is LunchMoney allows assets to have NULLs in the balance_as_of field for manually created assets, but when Lunchable calls them it doesn't like it.

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

• lunchable version: 0.9.0
• Python version: 3.10
• Operating System: Debian GNU/Linux 12

Description

I insert transactions to LM manually since my bank does not provide any API. I weekly download last 30 days transaction list in CSV format file and process it using custom scripts. Most of transactions are duplicated and I'm ok with that since I ensure transaction IDs are unique.

What I Did

When trying to insert duplicated transaction it seems like API is now responding with empty content and 204 status code, since lunchable expects JSON content then it is breaking with error:
JSONDecodeError('Expecting value: line 1 column 1 (char 0)') in

• lunchable version: 1.1.0
• Python version: 3.12.1
• Operating System: MacOS

Description

I tried to install and use Lunchable as a CLI without trying it as a package. The steps I expected to be enough for making it work were:

1. Having the LUNCHMONEY_ACCESS_TOKEN variable available;
2. Executing any lunchable command in a shell with the package installed.

In all trials (detailed below) I got a ModuleNotFoundError: No module named 'numpy'. As a hypothesis, I believe it can have to do with the combination of the ways I installed it and the fact that pandas (and therefore numpy) is a optional dependency in pyproject.toml.
I eventually made it work by manually running poetry add pandas to my project.

I expected to be able to use Lunchable's CLI directly from the installation methods I chose, which are analogous to pip install.

What I Did

Trial 1

pipx install lunchable
lunchable --version

Trial 2 (in a poetry project)

poetry add lunchable
poetry install
poetry run lunchable --version

In both trials, the env variable LUNCHMONEY_ACCESS_TOKEN was available, and both returned the ModuleNotFoundError.

Descriptions are stored as private class attributes - they should be removed from the core data models.

https://github.com/juftin/lunchable/blob/f94e01a2dbc92344a4f814cd1babfbd7727551d9/lunchable/models/assets.py

Refactor hatch to correspond to https://github.com/juftin/cookiecutter-python

• lunchable version: 1.3.1
• Python version: 3.8.18
• Operating System: Windows 11

Description

The budgets endpoint is timing out on every run, I get a 'The read operation timed out' response when trying to run the simple Python code below.

This call works fine on the LunchMoney native API (although it is historically slower than other calls).

What I Did

import pandas as pd
from lunchable import LunchMoney

lunch = LunchMoney(access_token="")

budgets = lunch.get_budgets(start_date='2024-02-01', end_date='2024-02-29')

print(budgets)

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

timeout Traceback (most recent call last)
File c:\Users\Jon Crosby.conda\envs\lunchmoneyEnv\lib\site-packages\httpcore_exceptions.py:10, in map_exceptions(map)
9 try:
---> 10 yield
11 except Exception as exc: # noqa: PIE786

File c:\Users\Jon Crosby.conda\envs\lunchmoneyEnv\lib\site-packages\httpcore_backends\sync.py:126, in SyncStream.read(self, max_bytes, timeout)
125 self._sock.settimeout(timeout)
--> 126 return self._sock.recv(max_bytes)

File c:\Users\Jon Crosby.conda\envs\lunchmoneyEnv\lib\ssl.py:1259, in SSLSocket.recv(self, buflen, flags)
1256 raise ValueError(
1257 "non-zero flags not allowed in calls to recv() on %s" %
1258 self.class)
-> 1259 return self.read(buflen)
1260 else:

File c:\Users\Jon Crosby.conda\envs\lunchmoneyEnv\lib\ssl.py:1134, in SSLSocket.read(self, len, buffer)
1133 else:
-> 1134 return self._sslobj.read(len)
1135 except SSLError as x:

timeout: The read operation timed out
...
81 raise
83 message = str(exc)
---> 84 raise mapped_exc(message) from exc

ReadTimeout: The read operation timed out

Not an issue, just wanted to say thank you!!

Planning to use this in my venmo-auto-cashout tool

Testing is currently difficult because it requires assets to exist in an account. The tests were created before separate budgets were created so I now have access to a sandbox where the snapshots can be more easily generated

This one will be large and may include a new major version release.