jubessin / com.ikonoclast.common Goto Github PK

The ObservableBlackboard currently only invokes the PropertyChanged(string propertyName) method when a value is set. As a result, the previous value cannot be known unless an observer had observed the previous setting of a blackboard's value.

Possible solutions:

• Separate method for invoking the more detailed IObserver method created on the ObservableBlackboard
• The ObservableBlackboard is modified to always invoke the more detailed method.

When comparing values for equality, the == operator is used which, by default, uses the .ReferenceEquals() function to test for if two values share the same instance.

As this check is used in the ObservableBlackboard class to determine whether or not to inform observers of changes to a key's value, this type of equality is not appropriate, especially since values are boxed within the internal Dictionary<string, object> object, and often results in observers being alerted when values have actually not been changed.

The equality should instead utilize the .Equals() function that tests for data equality.

Should only be available in Editor.

This will cause a NullReferenceException when trying to access Event.current.

i.e., for example, when serializing a file with maps it can only grow in size.

When the blackboard is serialized after being deserialized, data will be lost.

Add pictures of usage and installation process.

Issue with the logic in the ObservableBlackboard script.