jstockwin / matlab-gmlread Goto Github PK

We should really be checking inputs etc etc

e.g.

% Validate input args
narginchk(1,Inf);

% Get Filename
if ~ischar(filename) && ~(isstring(filename) && isscalar(filename))
    error(message('MATLAB:csvread:FileNameMustBeString')); 
end
filename = char(filename);

% Make sure file exists
if exist(filename,'file') ~= 2 
    error(message('MATLAB:csvread:FileNotFound'));
end

It is possible that we have the following:

node
[
    id 1
    graphics
    [
        x 1
        y 1
    ]
   label "test"
]

This sort of nested structure is not supported.

• It will try to add a graphics column to the NodeProps, but finding the value for graphics may error, or it may just be blank
• The [ after graphics will be ignored
• The x and y will be added to NodeProps, although with no information about being nested under graphics.
• The ] of graphics will set interpreting_node = 0; which will lead to label either being ignored, or throwing some kind of errors.

We probably need some concept of depth.

Not sure GML actually "supports" weighted networks in the spec, but "Weight" attributes are clearly possible.

The Matlab class also has NormWeight, which we could also support/add.

Currently, the code is very linear and explicit. There are a few lines that are duplicated, specifically between handling edges and handling nodes.

It might be worth having some additional util functions, or maybe combining the edge/node logic into one.

cc:/ @Tom-Johnston

We could handle any given property e.g. using regexp(tline, '(?<=^\s*)([^ \t]+)', 'match').

For a tline of

                    some_property some_value

that regexp code will result in 'some_property'. We'll then be able to create a list of all properties present in the gml file on the first run through, then initialise the NodeProps table with these columns.

If we're lucky, on the second run through we might be able to do something like

prop = regexp(tline, '(?<=^\s*)([^ \t]+)', 'match');
NodeProps.eval(prop){current_node} = some_other_reg_exp_to_get_some_value