film-night's People
film-night's Issues
Need to be able to enable/disable pages as appropriate from admin console
Need to implement roll call page
The profile image divider is different heights on different pages.
Attending users could get a notification an hour before voting closes if they've not yet voted
Custom 404
We need a custom 404 page. This might need to be done on jstockwin.github.io, as filmnight is hosted as a folder within that site?
Can we make custom forbidden pages too? (https://jakestockwin.co.uk/filmnight/admin/execute.php)
Check votes are valid.
Votes of the wrong form can cause the JavaScript to get stuck in an infinite loop and crash.
e.g.
- AV (and presumably the other runoff voting methods) loop forever if the only films to remove are not in the listOfCandidates.
- Borda count can't cope if a film isn't in a vote.
We should sanitise the votes either on the server, in the Javascript voting methods or both.
Fortunately the members are too nice and/or too incompetent to ruin film night by submitting votes of the wrong form. Unfortunately they have almost managed to ruin film night by submitting terrible films.
Coombs' Method
Check if the person has already proposed a film.
At the moment submitting the same film multiple times would fill up the strings for who proposed the film and who wants to veto it.
The winning film should have frequency set to 0
Need to implement film selection page/function
Settings updates should have error handling
Searching shouldn't return another instance of films already selected
Voting information is not aligned properly
Settings.php needs styling
The indicator doesn't slide properly
It needs entirely redoing so that it can persist across page loads.
You can't sign out.
When you click log out, you are logged out. However, google automatically signs you straight back in.
Submitting films should have error handling
Will probably just change the text of the "Submit" button. If things go well, it will be "Submit" -> "Submitting" -> "Submitted", else it will be "Submit" -> "Submitting" -> "Error"
AV
Contingent Voting
Results table needs styling
Favicon is the same colour as the theme
Plot descriptions are being cut off.
Most places do not check if the user is active.
Should probably also only continue to send voting emails etc if the user has said they're attending film night.
Nanson is not working.
Bucklin Method
Users should be able to get notifications on multiple browsers.
This should be a simple case of comma separating the end points.
- May need to make the end point field in the SQL DB longer? (It's currently 255)
- Users should be able to remove each individual browser from getting notifications. This should simply be removing the correct entry from the list. Should also have an "unregister all" button.
- What happens if e.g. the user gets a new pc/phone. They'll end up with unwanted end points. Is this an issue? Presumably nothing will break, but could eventually cause problems?
The top voting card should have a top margin
First-Past-the-Post
It is used in each step of AV so it will be implemented as an function anyway.
execute.php doesn't actually check the users email settings
Split files
- Move the JS into separate files that are either linked or included.
- Split the styles.
9f5795fff90cbf229051df72b87281b827590012
- IDs should be lowercase.
- Shouldn't override the padding
- Only one of the buttons gets updated so the reveal is ruined. This also causes the problem which was "fixed" by overriding the padding.
Move settings into the profile drop down?
Nanson
Colours
Check the colours used and create a global palette. Is the purple used for the veto in voting the same as the purple used in node colours?
Anti-plurality
Going to used in Coombs' Method.
Need to add favicon and page titles
Strange things happen when you interrupt the animation by changing page again too early
Add "withdraw vote" functionality
Voting should have error handling
Should be able to click the veto and selected buttons.
In particular these should toggle the value that they represent and not just pass the click through.
Organise files
Results graph needs a key.
Titanic II Plot breaks imdb pull
Titanic II plot contains double quotes. Other plots contain single quotes. Will need to start URLEncoding/Decoding plots.
The scores for baldwin/nanson are not helpful or intuitive.
It shows the score that the borda count assigns to it when it is eliminated. When a candidate is removed the borda count now has less candidates so the score for coming first is reduced etc. Hence the scores are often decreasing although at each step a higher score is better. In Nanson candidates below the average are eliminated so having scores which are not monotonic occurs quite frequently. This could be fixed by specifying the top score in the borda count but it doesn't quite fit with the idea of removing a candidate and running the count as if the candidate was never there.
Show 4 decimal places for times.
Push API support?
Support for the w3c Push API could be cool for notifying us of roll-call/start of voting/results availability. Currently has basic support in Chrome 42 and more complete support in Firefox 44 https://developer.mozilla.org/en/docs/Web/API/Push_API
Ranked Pairs
Should be able to hit enter to search
Possibly use a search input type for the name as that you get a nice search icon on the keyboard. I would go for tel over search for the year to force numbers.
Add runoff voting chart
Like this one:
"sign in" goes wrong if you are signed out when changing page using topnav
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.