jschomay / elm-bounded-number Goto Github PK

It seems as if this code puts a dependency on the regex package, but I cannot figure out for what. If there is no reason for it to be a dependency then it should probably be removed so the package is unaffected by changed in said package.

https://media.tenor.com/images/f4698806ab131f3c326c6fd1d6dfebc7/tenor.gif

Hey! First of all, great work on elm-bounded-number using it, loving it.

It is very common for having a way to map a value of a data structure. Most data structures allow it, such as Maybe, Result, Dict, and so on. It would be great to have an update or map function so that you can more easily chain bounded number operations.

I have added a function similar to this one to one of the projects I'm working on:

mapBounded fn bounded =
    let
        value = Number.Bounded.value bounded
    in
    Number.Bounded.set (fn value) bounded

This let's me refactor things like this:

-operation : Int -> Int
+operation : Bounded Int -> Int
 operation =
-    (*) 20 >> (+) 10
+    Number.Bounded.update <| (*) 20 >> (+) 10

It also makes it easier to refactor from Number.Bounded.inc. Such as: https://github.com/hugobessaa/nanotimers/pull/11/commits/696171908045a3d369a25dd0855ec8eccf474e0e

I'm not sure if the proper name should be either map or update.

What do you think about adding this function? I could send a PR.