jrochkind / borrow_direct Goto Github PK

I’ve come across a bug in the borrow_direct gem when trying to do a find with multiple ISBNs for the same item. It took me a while to pin it down, but I finally realized what’s going on.

Currently, doing something like this:

isbns = [‘9780821419755’, ‘0821419757’]
BorrowDirect::FindItem.new.find(:isbn => isbns)

produces a hash that looks like this:

{
  "PartnershipId"=>"BD", 
  "ExactSearch"=>[
    {"Type"=>"ISBN", "Value"=>”9780821419755"}, 
    {"Type"=>"ISBN", "Value"=>”0821419757"}
  ]
}

However, this call yields incorrect results. A search of either ISBN individually shows that the item is available in BD, but trying the above search with two ISBNs returns a response of “unavailable”. This is because the hash — or rather, the JSON it’s converted into in request.rb — is improperly formed. According to Relais, the correct format should be:

{
  "PartnershipId": "BD",
  "ExactSearch": [{"Type": "ISBN", "Value": "9780821419755"}],
  "ExactSearch": [{"Type": "ISBN", "Value": "0821419757"}]
}

So a hash won’t work here because duplicate keys are needed. I tried to find a gentle way of modifying the code in find_item.rb to handle this, but I haven’t come up with anything yet.

Also, on a very minor note, TEST_API_BASE should be updated to https://bdtest.relais-host.com/ (rc.relais-host is no longer working properly).