Slow rendering of the files list about deft HOT 6 CLOSED

Update: Nvm, user error. :)

@Anks I'm seeing this error with your snippet after adding to dotspacemacs/user-config, any idea why?

(Spacemacs) Error in dotspacemacs/user-config: Wrong type argument: symbolp, (defalias (quote anks-deft-limit\
ing-fn) (function (lambda (orig-fun &rest args) (let ((deft-current-files (-take 30 deft-current-files))) (ap\
ply orig-fun args)))))

from deft.

Thanks for reporting this. I can confirm a similar result when profiling, although I only have about 300 notes at the moment.

I think rather than limiting the number of lines rendered (which would prevent being able to scroll down and see more), to solve the underlying issue a better approach would be a slight redesign where the widget and summary line for each file is created once and stored for re-use. I can't tackle that at the moment, but if anyone wants to take a shot at that I'll certainly accept at a PR.

from deft.

Small update: for my personal use, I ended up defining a advice function like this which limits the display to 30 files:

  ;; Overwrite `deft-current-files` for the `deft-buffer-setup` and limit it to 30 entries
  (defun anks-deft-limiting-fn (orig-fun &rest args)
    (let
        ((deft-current-files (-take 30 deft-current-files)))
      (apply orig-fun args)))

  (advice-add 'deft-buffer-setup :around #'anks-deft-limiting-fn)

This gives me snappy search, and 30 results are 'good enough'.

This is probably not the best solution, but works for me.

Note: the -take function is from dash.el

from deft.

@joech4n why added into a (defalias (quote ...)) block?
I just added directly under user-config, it works quite well

from deft.

I added built-in support for limiting the number of files shown via `deft-file-limit'. See the updated README and the docstring for details.

from deft.

@jrblevin Thank you!

from deft.